Re: [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory

2013-05-28 Thread Jeff Liu
On 05/28/2013 09:12 AM, xiaowei...@oracle.com wrote: > From: "Xiaowei.Hu" > > Suppress the error message from being printed in ocfs2_rename > Did same thing with Goldwyn Rodrigues last patch. > > While removing a non-empty directory, the kernel dumps a message: > (mv,29521,1):ocfs2_rename:1474

[Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory

2013-05-27 Thread xiaowei . hu
From: "Xiaowei.Hu" Suppress the error message from being printed in ocfs2_rename Did same thing with Goldwyn Rodrigues last patch. While removing a non-empty directory, the kernel dumps a message: (mv,29521,1):ocfs2_rename:1474 ERROR: status = -39 Signed-off-by: Xiaowei Hu --- fs/ocfs2/name

Re: [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory

2013-05-26 Thread Jeff Liu
On 05/24/2013 02:20 PM, xiaowei.hu wrote: > Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename? > It also may hit this unecessary error. This definitely is the same thing like ocfs2_unlink() that need to be fixed. Thanks, -Jeff > > Thanks, > xiaowei > > On 05/20/2013 11:06

Re: [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory

2013-05-23 Thread xiaowei.hu
Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename? It also may hit this unecessary error. Thanks, xiaowei On 05/20/2013 11:06 PM, Goldwyn Rodrigues wrote: > While removing a non-empty directory, the kernel dumps a message: > (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39

Re: [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory

2013-05-22 Thread Sunil Mushran
Acked-by: Sunil Mushran On Mon, May 20, 2013 at 8:06 AM, Goldwyn Rodrigues wrote: > While removing a non-empty directory, the kernel dumps a message: > (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 > > Suppress the error message from being printed in the dmesg so users > don't panic. > >

[Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory

2013-05-20 Thread Goldwyn Rodrigues
While removing a non-empty directory, the kernel dumps a message: (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 Suppress the error message from being printed in the dmesg so users don't panic. Signed-off-by: Goldwyn Rodrigues --- diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 04e