Re: [Ocfs2-devel] [PATCH] ocfs2: don't put and assign null to bh allocated outside

2018-05-08 Thread Changwei Ge
Friendly ping after one month's silence for this patch. Andrew had picked this patch into -mm tree. Can anyone help review my patch or give some comments.:-) Thanks, Changwei On 04/10/2018 07:35 PM, Changwei Ge wrote: > ocfs2_read_blocks() and ocfs2_read_blocks_sync() are both used to read >

Re: [Ocfs2-devel] [PATCH] ocfs2: don't put and assign null to bh allocated outside

2018-04-10 Thread Changwei Ge
Hi Jun, On 2018/4/11 9:43, piaojun wrote: > Hi Changwei, > > On 2018/4/11 9:14, Changwei Ge wrote: >> Hi Jun, >> >> Thanks for your review. >> >> On 2018/4/11 8:40, piaojun wrote: >>> Hi Changwei, >>> >>> On 2018/4/10 19:35, Changwei Ge wrote: ocfs2_read_blocks() and ocfs2_read_blocks_sync()

Re: [Ocfs2-devel] [PATCH] ocfs2: don't put and assign null to bh allocated outside

2018-04-10 Thread piaojun
Hi Changwei, On 2018/4/11 9:14, Changwei Ge wrote: > Hi Jun, > > Thanks for your review. > > On 2018/4/11 8:40, piaojun wrote: >> Hi Changwei, >> >> On 2018/4/10 19:35, Changwei Ge wrote: >>> ocfs2_read_blocks() and ocfs2_read_blocks_sync() are both used to read >>> several blocks from disk. Cur

Re: [Ocfs2-devel] [PATCH] ocfs2: don't put and assign null to bh allocated outside

2018-04-10 Thread Changwei Ge
Hi Jun, Thanks for your review. On 2018/4/11 8:40, piaojun wrote: > Hi Changwei, > > On 2018/4/10 19:35, Changwei Ge wrote: >> ocfs2_read_blocks() and ocfs2_read_blocks_sync() are both used to read >> several blocks from disk. Currently, the input argument *bhs* can be >> NULL or NOT. It depends

Re: [Ocfs2-devel] [PATCH] ocfs2: don't put and assign null to bh allocated outside

2018-04-10 Thread piaojun
Hi Changwei, On 2018/4/10 19:35, Changwei Ge wrote: > ocfs2_read_blocks() and ocfs2_read_blocks_sync() are both used to read > several blocks from disk. Currently, the input argument *bhs* can be > NULL or NOT. It depends on the caller's behavior. If the function fails > in reading blocks from dis

[Ocfs2-devel] [PATCH] ocfs2: don't put and assign null to bh allocated outside

2018-04-10 Thread Changwei Ge
ocfs2_read_blocks() and ocfs2_read_blocks_sync() are both used to read several blocks from disk. Currently, the input argument *bhs* can be NULL or NOT. It depends on the caller's behavior. If the function fails in reading blocks from disk, the corresponding bh will be assigned to NULL and put. Ob