Re: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-10 Thread Andrew Morton
On Wed, 9 Dec 2015 10:28:17 +0800 Junxiao Bi wrote: > Hi Andrew, > > On 12/09/2015 05:22 AM, Andrew Morton wrote: > > On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi wrote: > > > >> commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, > >> SGID of sub dir was not inherited

Re: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-08 Thread Junxiao Bi
Hi Andrew, On 12/09/2015 05:22 AM, Andrew Morton wrote: > On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi wrote: > >> commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, >> SGID of sub dir was not inherited from its parents dir. It is because SGID >> is set into "inode->i_m

Re: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-08 Thread Andrew Morton
On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi wrote: > commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, > SGID of sub dir was not inherited from its parents dir. It is because SGID > is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten > by "mode" w

Re: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-07 Thread Srinivas Eeda
Thanks Junxiao! Acked-by: Srinivas Eeda On 12/06/2015 08:09 PM, Junxiao Bi wrote: > commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, > SGID of sub dir was not inherited from its parents dir. It is because SGID > is set into "inode->i_mode" in ocfs2_get_init_inode(), bu

[Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue

2015-12-06 Thread Junxiao Bi
commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, SGID of sub dir was not inherited from its parents dir. It is because SGID is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten by "mode" which don't have SGID set later. Fixes: 8f1eb48758aa ("ocfs2: f