On 2013/5/29 10:42, Joseph Qi wrote:
If we use le32_add_cpu to set ocfs2_dinode i_flags, it may lead to the
corresponding flag corrupted. So we should change it to bitwise and/or
operation.
I think it should be use bitwise and or operation, because one bit stand
for one meaning.
Thanks for your patch, Joseph.
On 05/29/2013 10:42 AM, Joseph Qi wrote:
If we use le32_add_cpu to set ocfs2_dinode i_flags, it may lead to the
corresponding flag corrupted. So we should change it to bitwise and/or
operation.
Signed-off-by: Joseph Qi joseph...@huawei.com
---
On 2013/5/29 15:57, Jeff Liu wrote:
Thanks for your patch, Joseph.
On 05/29/2013 10:42 AM, Joseph Qi wrote:
If we use le32_add_cpu to set ocfs2_dinode i_flags, it may lead to the
corresponding flag corrupted. So we should change it to bitwise and/or
operation.
Signed-off-by: Joseph
On 05/29/2013 04:12 PM, shencanquan wrote:
On 2013/5/29 15:57, Jeff Liu wrote:
Thanks for your patch, Joseph.
On 05/29/2013 10:42 AM, Joseph Qi wrote:
If we use le32_add_cpu to set ocfs2_dinode i_flags, it may lead to the
corresponding flag corrupted. So we should change it to bitwise
You are right. Thanks for your review comments.
I will do the corresponding modification and resend the patch.
On 2013/5/29 18:17, Jeff Liu wrote:
On 05/29/2013 04:12 PM, shencanquan wrote:
On 2013/5/29 15:57, Jeff Liu wrote:
Thanks for your patch, Joseph.
On 05/29/2013 10:42 AM, Joseph Qi
If we use le32_add_cpu to set ocfs2_dinode i_flags, it may lead to the
corresponding flag corrupted. So we should change it to bitwise and/or
operation.
Signed-off-by: Joseph Qi joseph...@huawei.com
---
fs/ocfs2/namei.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
