Re: [Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi all, On 10/19/2016 01:19 PM, Eric Ren wrote: ocfs2_permission() and ocfs2_iop_get/set_acl() both call ocfs2_inode_lock(). The problem is that the call chain of ocfs2_permission() includes *_acl(). Possibly, there are three solutions I can think of. The first one is to implement the inode pe

Re: [Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi Christoph! Thanks for your attention. On 10/28/2016 02:20 PM, Christoph Hellwig wrote: Hi Eric, I've added linux-fsdevel to the cc list as this should get a bit broader attention. On Wed, Oct 19, 2016 at 01:19:40PM +0800, Eric Ren wrote: Mostly, we can avoid recursive locking by writing c

Re: [Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi Eric, I've added linux-fsdevel to the cc list as this should get a bit broader attention. On Wed, Oct 19, 2016 at 01:19:40PM +0800, Eric Ren wrote: > Mostly, we can avoid recursive locking by writing code carefully. However, as > the deadlock issues have proved out, it's very hard to handle th

Re: [Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi all, On 10/19/2016 01:19 PM, Eric Ren wrote: > The thrid one is to revert that problematic commit! It looks like > get/set_acl() > are always been called by other vfs callback like ocfs2_permission(). I think > we can do this if it's true, right? Anyway, I'll try to work out if it's > true;-

Re: [Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi Junxiao, On 10/19/2016 02:57 PM, Junxiao Bi wrote: > I had ever implemented generic recursive locking support, please check the > patch at > https://oss.oracle.com/pipermail/ocfs2-devel/2015-December/011408.html > , >

Re: [Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi Eric, > 在 2016年10月19日，下午1:19，Eric Ren 写道： > > Hi all! > > Commit 743b5f1434f5 ("ocfs2: take inode lock in ocfs2_iop_set/get_acl()") > results in another deadlock as we have discussed in the recent thread: >https://oss.oracle.com/pipermail/ocfs2-devel/2016-October/012454.html > > Before

[Ocfs2-devel] [RFC] Should we revert commit "ocfs2: take inode lock in ocfs2_iop_set/get_acl()"? or other ideas?

Hi all! Commit 743b5f1434f5 ("ocfs2: take inode lock in ocfs2_iop_set/get_acl()") results in another deadlock as we have discussed in the recent thread: https://oss.oracle.com/pipermail/ocfs2-devel/2016-October/012454.html Before this one, a similiar deadlock has been fixed by Junxiao: co