[jira] Commented: (OFBIZ-591) Shipping a serialized inventory item not handled correctly

2007-01-08 Thread Leon Torres (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463137 ] Leon Torres commented on OFBIZ-591: --- Jacopo, what if a particular item is defective? Basing status off of the quan

[jira] Updated: (OFBIZ-405) Showing invoice total with and without tax

2006-12-21 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ] Leon Torres updated OFBIZ-405: -- Attachment: invoicenotax-2.diff I tested the patch and found that it doesn't work at all. The problem is that the getInvoiceTaxTotal() method only checks for INV_S

[jira] Updated: (OFBIZ-554) Log the session ID in RequestHandler.java

2006-12-19 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-554?page=all ] Leon Torres updated OFBIZ-554: -- Attachment: logSessionId.patch This small patch adds the sessionId to some of the important log events in RequestHandler.java, and then some. > Log the session I

[jira] Created: (OFBIZ-554) Log the session ID in RequestHandler.java

2006-12-19 Thread Leon Torres (JIRA)
Log the session ID in RequestHandler.java - Key: OFBIZ-554 URL: http://issues.apache.org/jira/browse/OFBIZ-554 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Component

[jira] Commented: (OFBIZ-93) Support BillingAcct + PaymentMethod for Payment

2006-12-05 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-93?page=comments#action_12455725 ] Leon Torres commented on OFBIZ-93: -- Sorry, I meant the re-authorization step of #3. Was the line totalAmountCaptured = totalAmountCaptured.add(billingAccountCapt

[jira] Commented: (OFBIZ-93) Support BillingAcct + PaymentMethod for Payment

2006-12-05 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-93?page=comments#action_12455724 ] Leon Torres commented on OFBIZ-93: -- It looks like everything's been committed except for one line in PaymentGatewayServices.java: @@ -951,10 +994,13 @@

[jira] Commented: (OFBIZ-309) If a service is implemented as an interface, its settings for optional attributes are ignored!

2006-12-04 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-309?page=comments#action_12455481 ] Leon Torres commented on OFBIZ-309: --- Yes, it's still on trunk. Briefly, if you look at the reference for upsRateEstimate: https://localhost:8443/webtools/contro

[jira] Updated: (OFBIZ-185) Integrated Javadocs

2006-12-01 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-185?page=all ] Leon Torres updated OFBIZ-185: -- Attachment: integrated-javadocs.patch Here's a patch implementing this. Run ant docs to build the javadoc. And here are updated links for the kind of javadoc it pr

[jira] Commented: (OFBIZ-249) Re-factor BigDecimal calculations

2006-10-26 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-249?page=comments#action_12445008 ] Leon Torres commented on OFBIZ-249: --- As part of this issue, do the following refactoring: Define UtilNumber.BD_ZERO = new BigDecimal("0"); Replace all instances o

[jira] Commented: (OFBIZ-364) Let form widget treat input list as a subset of a larger list

2006-10-17 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-364?page=comments#action_12443048 ] Leon Torres commented on OFBIZ-364: --- I don't know how this change affects the row-count feature. Can someone check? I'm a little short on time to deal with this

[jira] Commented: (OFBIZ-364) Let form widget treat input list as a subset of a larger list

2006-10-17 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-364?page=comments#action_12443038 ] Leon Torres commented on OFBIZ-364: --- It's working without issues for me, although I don't know if putting a magical parameter in the context is the right way to i

[jira] Updated: (OFBIZ-364) Let form widget treat input list as a subset of a larger list

2006-10-06 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-364?page=all ] Leon Torres updated OFBIZ-364: -- Attachment: subset-form-list.patch Here's a patch that implements this feature. To test it, get all values of an entity, say StatusItem, and set "overrideFormList

[jira] Created: (OFBIZ-364) Let form widget treat input list as a subset of a larger list

2006-10-06 Thread Leon Torres (JIRA)
Let form widget treat input list as a subset of a larger list - Key: OFBIZ-364 URL: http://issues.apache.org/jira/browse/OFBIZ-364 Project: OFBiz (The Open for Business Project) Iss

[jira] Updated: (OFBIZ-336) Improve complex-alias to handle nulls and defaults

2006-09-29 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-336?page=all ] Leon Torres updated OFBIZ-336: -- Attachment: complex-alias-default-value2.patch Derby did not like the single quotations ''. It complained that CHAR value (the '0') was not compatible with DOUBLE

[jira] Updated: (OFBIZ-336) Improve complex-alias to handle nulls and defaults

2006-09-27 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-336?page=all ] Leon Torres updated OFBIZ-336: -- Attachment: complex-alias-default-value.patch Here's an implementation of default-value for complex alias. I removed two constructor methods in ComplexAliasField t

[jira] Commented: (OFBIZ-336) Improve complex-alias to handle nulls and defaults

2006-09-27 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-336?page=comments#action_12438173 ] Leon Torres commented on OFBIZ-336: --- Right now I'm trying to fix some of the order report view entities. They don't subtract the cancelQuantity, so I tried addin

[jira] Created: (OFBIZ-336) Improve complex-alias to handle nulls and defaults

2006-09-27 Thread Leon Torres (JIRA)
Improve complex-alias to handle nulls and defaults -- Key: OFBIZ-336 URL: http://issues.apache.org/jira/browse/OFBIZ-336 Project: OFBiz (The Open for Business Project) Issue Type: Improvement

[jira] Commented: (OFBIZ-240) selectAll on multi-forms

2006-09-22 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=comments#action_12437024 ] Leon Torres commented on OFBIZ-240: --- By title="somethingOrElse", I mean the title is a required attribute. If no title is specified, the selectAll checkbox won't

[jira] Updated: (OFBIZ-240) selectAll on multi-forms

2006-09-22 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=all ] Leon Torres updated OFBIZ-240: -- Attachment: selectAllSmallestImpact.patch Here's the smallest impact patch for this feature. To generate the select all, the user must define a in a form of type "

[jira] Commented: (OFBIZ-260) Cross Site Scripting Vulnerability (XSS)

2006-09-20 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-260?page=comments#action_12436366 ] Leon Torres commented on OFBIZ-260: --- I just realized that a compromised account is not necessary. Any public input that gets displayed as textarea internally is

[jira] Commented: (OFBIZ-260) Cross Site Scripting Vulnerability (XSS)

2006-09-20 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-260?page=comments#action_12436365 ] Leon Torres commented on OFBIZ-260: --- The attack would have to be extremely sophisticated and social: Imagine that the popup is inserted into some description fie

[jira] Created: (OFBIZ-309) If a service is implemented as an interface, its settings for optional attributes are ignored!

2006-09-14 Thread Leon Torres (JIRA)
If a service is implemented as an interface, its settings for optional attributes are ignored! -- Key: OFBIZ-309 URL: http://issues.apache.org/jira/browse/OFBIZ-309

[jira] Commented: (OFBIZ-203) Freemarker postal address formatter macro

2006-09-12 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-203?page=comments#action_12434342 ] Leon Torres commented on OFBIZ-203: --- Hi David, I wanted only to present counterarguments for the benefit of other readers. :-) I'll post to the list about my a

[jira] Commented: (OFBIZ-203) Freemarker postal address formatter macro

2006-09-12 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-203?page=comments#action_12434279 ] Leon Torres commented on OFBIZ-203: --- I recommend giving the ftl and bsh files a shot to see what output it can generate. It's pretty neat the way it currently wo

[jira] Commented: (OFBIZ-203) Freemarker postal address formatter macro

2006-09-12 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-203?page=comments#action_12434275 ] Leon Torres commented on OFBIZ-203: --- In response to: "I can see that this must have required a fair amount of work, and that's exactly my concern." Well, if you

[jira] Commented: (OFBIZ-224) Problem with approximations if the ShoppingCart.basePrice has more than three decimal digits.

2006-09-12 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-224?page=comments#action_12434176 ] Leon Torres commented on OFBIZ-224: --- This raises an interesting issue in my head: We are assuming that these prices (currency and currency-precise) are two decim

[jira] Commented: (OFBIZ-203) Freemarker postal address formatter macro

2006-09-05 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-203?page=comments#action_12432625 ] Leon Torres commented on OFBIZ-203: --- Apply the ofbizPostalAddress.patch to framework/webapp/. I'd like to note futher that this feature can be backported to older

[jira] Created: (OFBIZ-203) Freemarker postal address formatter macro

2006-09-05 Thread Leon Torres (JIRA)
Freemarker postal address formatter macro - Key: OFBIZ-203 URL: http://issues.apache.org/jira/browse/OFBIZ-203 Project: OFBiz (The Open for Business Project) Issue Type: New Feature Component

[jira] Commented: (OFBIZ-185) Integrated Javadocs

2006-08-25 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-185?page=comments#action_12430698 ] Leon Torres commented on OFBIZ-185: --- The motivation behind this is to improve documentation for developers. One of the annoyances of development is having to act

[jira] Created: (OFBIZ-185) Integrated Javadocs

2006-08-25 Thread Leon Torres (JIRA)
Integrated Javadocs --- Key: OFBIZ-185 URL: http://issues.apache.org/jira/browse/OFBIZ-185 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Affects Versions: SVN trunk Reporter: Leon Torr

[jira] Created: (OFBIZ-158) updateReturnItemsStatus service changing RETURN_COMPLETED items to RETURN_ACCEPTED

2006-08-15 Thread Leon Torres (JIRA)
updateReturnItemsStatus service changing RETURN_COMPLETED items to RETURN_ACCEPTED -- Key: OFBIZ-158 URL: http://issues.apache.org/jira/browse/OFBIZ-158 Project: OFBiz (T

[jira] Commented: (OFBIZ-120) Use separate OrderPaymentPreference with maxAmount for biling account and other payment methods

2006-08-04 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-120?page=comments#action_12425845 ] Leon Torres commented on OFBIZ-120: --- Also, the checkout flow needs to be modified so that shipping and tax are calculated before payment methods are generated. T

[jira] Updated: (OFBIZ-120) Use separate OrderPaymentPreference with maxAmount for biling account and other payment methods

2006-08-04 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-120?page=all ] Leon Torres updated OFBIZ-120: -- Attachment: billingAccount.patch The billingAccount.patch is the initial attempt at satisfying this requirement. There's more work to be done: set the maxAmount f

[jira] Commented: (OFBIZ-120) Use separate OrderPaymentPreference with maxAmount for biling account and other payment methods

2006-08-04 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-120?page=comments#action_12425826 ] Leon Torres commented on OFBIZ-120: --- That patch also fixes numerous bugs in the legacy ftl and servlet code. > Use separate OrderPaymentPreference with maxAmount

[jira] Commented: (OFBIZ-104) Re-factor PaymentGatewayServices processCaptureResult

2006-07-25 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-104?page=comments#action_12423467 ] Leon Torres commented on OFBIZ-104: --- I'm assuming the answer to the first part is to use the invoiceId passed in to get the Invoice, and then one of the parties

[jira] Commented: (OFBIZ-108) DataFiles tool improvements to support CSV, tabs, empty columns, default values, sequences, etc.

2006-07-25 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-108?page=comments#action_12423365 ] Leon Torres commented on OFBIZ-108: --- Also, I think there should be an option to ignore empty columns. When generating CSV, it is common to get blank columns such

[jira] Commented: (OFBIZ-93) Support BillingAcct + PaymentMethod for Payment

2006-07-17 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-93?page=comments#action_12421735 ] Leon Torres commented on OFBIZ-93: -- Can't we distinguish between B2B and B2C using a BillingAccountType? These are clearly two different kinds of accounts, so we s

[jira] Commented: (OFBIZ-81) Support for PaymentMethod.description

2006-07-14 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-81?page=comments#action_12421224 ] Leon Torres commented on OFBIZ-81: -- Hi Ashish, I'm looking through the July 15 patch above. It's exposing the GL Account ID to a customer in ecommerce who is looki

[jira] Commented: (OFBIZ-86) Support for Store Credit Valid Days

2006-07-12 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-86?page=comments#action_12420708 ] Leon Torres commented on OFBIZ-86: -- Wouldn't (nowTimestamp + this many days + (time to end of day)) work better for expiration date? That way users and customer's won't be sur

[jira] Commented: (OFBIZ-53) Problem with adding item during modify order when there is no default price

2006-07-06 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-53?page=comments#action_12419623 ] Leon Torres commented on OFBIZ-53: -- And also in 419743 > Problem with adding item during modify order when there is no default price >

[jira] Commented: (OFBIZ-53) Problem with adding item during modify order when there is no default price

2006-07-06 Thread Leon Torres (JIRA)
[ http://issues.apache.org/jira/browse/OFBIZ-53?page=comments#action_12419619 ] Leon Torres commented on OFBIZ-53: -- fixed in revision 419736. > Problem with adding item during modify order when there is no default price > --

[JIRA] Commented: (OFBIZ-385) Authorize.NET Payment Gateway Implementation

2006-06-27 Thread Leon Torres (JIRA)
[ http://jira.undersunconsulting.com/browse/OFBIZ-385?page=comments#action_13590 ] Leon Torres commented on OFBIZ-385: --- Hi Fred, The authnet_20060614.tgz, authnetcredit.patch have been committed into ofbiz accounting as of r 7883. It would be nice