Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-09 Thread Jacques Le Roux
Hi Adam, I can't answer accuratly because I have no time to put on this now. However I may help a bit if needed. You have certainly view the last message about JPublish by David else here it is attached. Jacques From: "Adam Heath" <[EMAIL PROTECTED]> > What is the time-frame on removing jpubli

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-06 Thread Adam Heath
Jacques Le Roux wrote: > I'm the one that commited the bsf patch and finally reverted it back. > If you were aware of a problem and knew that a patch existed why did > not you submitted this patch or simply tell about it ? Of course I may > have figured it out myself and use the new JPublish libra

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-06 Thread Adam Heath
Si Chen wrote: > Adam, > > If there were some older patches that got missed two years ago, maybe > it's good to submit them again. We do have more committers back then. My general feeling from a bit ago, was that patches tended to languish, and not get applied. Once instance, I filed a bug duri

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-06 Thread Adam Heath
David E Jones wrote: > > On Nov 1, 2006, at 3:48 PM, Adrian Crum wrote: > >> Si, >> >> Adam was a big contributor before you came along. At the time he was >> considered a "trusted" source. > > Yes and no. From where I'm sitting I'd say Si has done and continues to > do far more for OFBiz and ev

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-02 Thread David Welton
For everyone: there are many ways to review a patch: c) apply the patch and verify if the system builds and runs correctly (ant clean, ant build) with no new warnings or error messages in the log files; if xml files have been updated, check the syntax agains their xsd files using an xml parser

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-02 Thread Jacopo Cappellato
Chris, your post is interesting: Chris Howe wrote: ... 2) What are the obstacles in attracting more patches/improvements and how can we get more non-commiter involvement in JIRA reviews? The number of patches and contributors is slowly growing every day and this is a great thing. However it

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-02 Thread Jacopo Cappellato
Hi Adam, Adam Heath wrote: ... Can we make it a release goal to update the libraries to something much more modern? I'm willing to help produce a list, giving each library, the version in use, the upstream location, and the most recent version. this information will be indeed useful; the best

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Chris Howe
As I have been guilty of needing a jab in the ribs like this in the past...That's enough bickering. Amongst the attitude/responsibility checking that has gone on in this thread there are only two questions that require responses. 1) Can we/is it necessary to determine a better plan of action for

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Jacques Le Roux
From: "Adam Heath" <[EMAIL PROTECTED]> > Si Chen wrote: > > I don't know about the particulars of the commons-fileupload library, > > but the problem with the bsf is that it interfered with the currently > > used jpublish. If you can supply an upgrade combination of bsf and > > jpublish that still

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread David E Jones
On Nov 1, 2006, at 3:48 PM, Adrian Crum wrote: Si, Adam was a big contributor before you came along. At the time he was considered a "trusted" source. Yes and no. From where I'm sitting I'd say Si has done and continues to do far more for OFBiz and every user of OFBiz than Adam or anyone

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread David E Jones
On Nov 1, 2006, at 3:00 PM, Adam Heath wrote: Si Chen wrote: I don't know about the particulars of the commons-fileupload library, but the problem with the bsf is that it interfered with the currently used jpublish. If you can supply an upgrade combination of bsf and jpublish that still works

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Si Chen
I wasn't suggesting that he was not, and I am aware that he was a contributor before. As this is a public list, I was hoping to explain why (at least from my perspective) sometimes patches aren't applied. On Nov 1, 2006, at 2:48 PM, Adrian Crum wrote: Si, Adam was a big contributor befo

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Adrian Crum
Si, Adam was a big contributor before you came along. At the time he was considered a "trusted" source. Si Chen wrote: Adam, If there were some older patches that got missed two years ago, maybe it's good to submit them again. We do have more committers back then. As to the general qu

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Si Chen
Adam, If there were some older patches that got missed two years ago, maybe it's good to submit them again. We do have more committers back then. As to the general question of why patches don't get applied "by those in charge," obviously we could all work harder for the good of the proje

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Adam Heath
Si Chen wrote: > I don't know about the particulars of the commons-fileupload library, > but the problem with the bsf is that it interfered with the currently > used jpublish. If you can supply an upgrade combination of bsf and > jpublish that still works, I think that should work for me (and > ho

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread BJ Freeman
I actually had to compile the org.apache.bsf from apache SVN to get the latest SVN to compile. had to replace the import com.ibm.bsf with the import org.apache.bsf Adam Heath sent the following on 11/1/2006 12:52 PM: Recently, I filed a bug(OFBIZ-401), to update bsf.jar to something more modern

Re: Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Si Chen
I don't know about the particulars of the commons-fileupload library, but the problem with the bsf is that it interfered with the currently used jpublish. If you can supply an upgrade combination of bsf and jpublish that still works, I think that should work for me (and hopefully the other

Use of ancient libraries in ofbiz, and release candidates

2006-11-01 Thread Adam Heath
Recently, I filed a bug(OFBIZ-401), to update bsf.jar to something more modern. This was backed out, as ofbiz makes use of an ancient jpublish that also uses the older bsf. Just recently, I had another case occur, with an old library. commons-fileupload is also very old, and the current version h