RE: [PATCH 1/3] Add multi calls support for HFP voicecall driver

Hi Denis, Denis Kenzior wrote: > Hi Zhenhua, > >> +static void reset_to_single_call(struct voicecall_data *vd) { >> + struct ofono_call *oc = vd->calls->data; >> + >> + vd->call = oc; >> + vd->cind_val[HFP_INDICATOR_CALL] = 1; >> + >> + if (oc->direction == 1) >> +

RE: [PATCH 4/4] Fix: Fill in the phone number info for outgoing call

Hi Denis, Denis Kenzior wrote: > Hi Zhenhua, > >> There're two cases of outgoing call: dial from HF or dial from phone. >> >> In the first case, some phones may not support enhanced call status >> (AT+CLCC) to query outgoing number. So we need to pass struct >> atd_cb_data to fill in the number

Re: [PATCH 1/3] Add multi calls support for HFP voicecall driver

Hi Zhenhua, >+static void reset_to_single_call(struct voicecall_data *vd) >+{ >+ struct ofono_call *oc = vd->calls->data; >+ >+ vd->call = oc; >+ vd->cind_val[HFP_INDICATOR_CALL] = 1; >+ >+ if (oc->direction == 1) >+ vd->cind_val[HFP_INDICATOR_CALLSETUP] = 1;

Re: [PATCH] Fixed modem options to work with capitalized variable names in modem.conf

Hi Ryan, > Hello, > > This patch fixes the calypso driver when setting the modemconf variables. Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] Fixed modem options to work with capitalized variable names in modem.conf

Hello, This patch fixes the calypso driver when setting the modemconf variables. Regards, Ryan --- plugins/calypso.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/plugins/calypso.c b/plugins/calypso.c index eba55dd..ddbec73 100644 --- a/plugins/calypso.c

Re: [PATCH 4/4] Fix style issue of bit left-shifting

Hi Zhenhua, Applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/4] Add call_compare_by_phone_number utility function

Hi Zhenhua, This one has been applied. Do note that Outlook is mangling your patches. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 4/4] Fix: Fill in the phone number info for outgoing call

Hi Zhenhua, > This is the latest version. Sorry for the noising from previous patches. > > There're two cases of outgoing call: dial from HF or dial from > phone. > > In the first case, some phones may not support enhanced call status > (AT+CLCC) to query outgoing number. So we need to pass struct

Re: [PATCH 1/2] Fix should invoke microphone_volume instead of speaker_volume

Hi Zhenhua, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono