Hi Zhenhua,
> +gboolean g_at_util_set_io(GIOChannel *io)
Rename this g_at_util_setup_io
> +{
> + GIOFlags io_flags;
> +
> + if (g_io_channel_set_encoding(io, NULL, NULL) !=
> + G_IO_STATUS_NORMAL)
> + return FALSE;
> +
> + io_flags = g_io_channel_get_f
Hi Zhenhua,
> +
> +#include
> +
> +#include "ringbuffer.h"
> +#include "gatresult.h"
Is this include really necessary?
> +#include "gatserver.h"
> +
> +#define DBG(fmt, arg...) g_print("%s:%s() " fmt, __FILE__, __FUNCTION__ ,
> ## arg) +
Move this to gat.h
> +struct _GAtServer {
> + gint
Hi Denis,
> > +#include "gatserver.h"
> > +
> > +#define DBG(fmt, arg...) g_print("%s:%s() " fmt, __FILE__, __FUNCTION__ ,
> > ## arg) +
>
> Move this to gat.h
can we actually not be using DBG inside gatchat. Why is that suddenly
needed?
Regards
Marcel
__
Hi Marcel,
> Hi Denis,
>
> > > +#include "gatserver.h"
> > > +
> > > +#define DBG(fmt, arg...) g_print("%s:%s() " fmt, __FILE__,
> > > __FUNCTION__ , ## arg) +
> >
> > Move this to gat.h
>
> can we actually not be using DBG inside gatchat. Why is that suddenly
> needed?
Actually good point. I a
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +gboolean g_at_util_set_io(GIOChannel *io)
>
> Rename this g_at_util_setup_io
>
>> +typedef void (*GAtDisconnectFunc)(gpointer user_data); typedef void
>> +(*GAtDebugFunc)(const char *str, gpointer user_data);
>
> These don't belong here, creat
