FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. Denis Kenzior denk...@gmail.com wrote: +static void ste_release_specific(struct ofono_voicecall *vc, int id, +ofono_voicecall_cb_t cb, void *data) { +struct voicecall_data *vd = ofono_voicecall_get_data(vc); +struct release_id_req *req =

[PATCH 1/2] Remove unneeded code to disable the modem on hfp

ofono_modem_remove() already disables the modem. --- plugins/hfp.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/plugins/hfp.c b/plugins/hfp.c index 867b194..2d0faa8 100644 --- a/plugins/hfp.c +++ b/plugins/hfp.c @@ -397,9 +397,6 @@ static DBusMessage

[PATCH 2/2] Handle the error path from service_level_connection

--- plugins/hfp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/hfp.c b/plugins/hfp.c index 2d0faa8..d9d3bda 100644 --- a/plugins/hfp.c +++ b/plugins/hfp.c @@ -377,7 +377,7 @@ static int service_level_connection(struct ofono_modem *modem, int fd) static

[PATCH] Add STE voice call support.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Makefile.am |1 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |3 + drivers/stemodem/voicecall.c | 596 ++ plugins/ste.c|2 +- 5

Re: [PATCH] Add STE voice call support.

Hi Sjur, --- Makefile.am |1 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |3 + drivers/stemodem/voicecall.c | 596 ++ plugins/ste.c|2 +- 5 files changed, 603 insertions(+), 1

Re: FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Sjur, All of this logic needs to go away. The core already handles all of this, including selection of ATH/CHLD, waiting/held. Please review src/voicecall.c. If the core logic is not sufficient or does not properly handle a certain case, then lets see if we can fix the core first.

Re: [PATCH 2/2] Handle the error path from service_level_connection

Hi Gustavo, --- plugins/hfp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Patch looks good, but doesn't apply: Applying: Handle the error path from service_level_connection error: patch failed: plugins/hfp.c:377 error: plugins/hfp.c: patch does not apply Patch failed at

[PATCH] Handle the error path from service_level_connection

--- plugins/hfp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/hfp.c b/plugins/hfp.c index 5b2cdae..0e2e359 100644 --- a/plugins/hfp.c +++ b/plugins/hfp.c @@ -367,7 +367,7 @@ static int service_level_connection(struct ofono_modem *modem, int fd) static

Re: [PATCH] Handle the error path from service_level_connection

Hi Gustavo, --- plugins/hfp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Sjur, oFono already takes care of this for single calls (see src/voicecall.c voicecall_hangup.) So this is only an issue in the case of three way calls, is this what you're referring to here? Kind of. This is very good, it takes care of the situation with emergency call which

[PATCH] Add ability to select modem on test-voicecall

--- test/test-voicecall | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/test/test-voicecall b/test/test-voicecall index 13f371a..2da7703 100755 --- a/test/test-voicecall +++ b/test/test-voicecall @@ -39,11 +39,9 @@ if __name__ == __main__: global