[PATCH] Make VPATH build work

Sometimes, you may need to distinguish the source tree and the build tree, when you want to keep the source tree uncluttered, or you need to build the source with several different configurations, or even your source tree is read only. This feature is called VPATH build and the patch is to make

Re: [patch 5/6] IP support for PPP

Hi Kristen, +static guint32 bytes_to_32(guint8 *bytes) +{ + union addr { + guint8 bytes[4]; + guint32 word; + } a; + + memcpy(a.bytes, bytes, 4); + return(ntohl(a.word)); +} This works, but is pretty ugly. Doesn't GLib has functions to

[PATCH 1/7] Barring services can only be activated/deactivated.

From: Pekka Pessi pekka.pe...@nokia.com Signed-off-by: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 2a04b25..13d625e 100644 --- a/src/call-barring.c +++

[PATCH 6/7] Added call-barring-api.txt.

From: Pekka Pessi pekka.pe...@nokia.com Signed-off-by: Pekka Pessi pekka.pe...@nokia.com --- doc/call-barring-api.txt | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) create mode 100644 doc/call-barring-api.txt diff --git

[PATCH 3/7] Number of barring services is constant.

From: Pekka Pessi pekka.pe...@nokia.com Signed-off-by: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 530d64b..eedb41d 100644 --- a/src/call-barring.c

[PATCH 4/7] Network password has exactly 4 digits.

From: Pekka Pessi pekka.pe...@nokia.com Signed-off-by: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index eedb41d..f3252e1 100644 ---

[PATCH 2/7] Return newly-queried barring status.

From: Pekka Pessi pekka.pe...@nokia.com Signed-off-by: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 13d625e..530d64b 100644 --- a/src/call-barring.c +++

Re: Barring API

2010/3/16 Denis Kenzior denk...@gmail.com: The signals and properties are actually different.  The signals are reported via IncomingBarringInEffect and OutgoingBarringInEffect are reported by the classical 27.007 modem through +CSSI/+CSSU.  They're just simple notifications. The

Re: [PATCH 1/7] Barring services can only be activated/deactivated.

Hi Pekka, From: Pekka Pessi pekka.pe...@nokia.com Signed-off-by: Pekka Pessi pekka.pe...@nokia.com For future reference please remember that we do not use the Signed-off by in oFono. Please configure your client not to include that. --- src/call-barring.c |4 ++-- 1 files

Re: [PATCH 3/7] Number of barring services is constant.

Hi Pekka, src/call-barring.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 4/7] Network password has exactly 4 digits.

Hi Pekka, +/* Network password has exactly 4 digits */ +static inline int is_valid_password(const char *pass) +{ + return is_valid_pin(pass) strlen(pass) == 4; +} + So I suggest not doing it this way, instead let us modify is_valid_pin to take an additional argument, namely whether

Re: [PATCH 5/7] Interrogation of a barring does not require password.

Hi Pekka, + if (type != SS_CONTROL_TYPE_QUERY !is_valid_password(sia)) goto bad_format; I applied this patch with slight modification until is_valid_pin is fixed. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 6/7] Added call-barring-api.txt.

Hi Pekka, --- doc/call-barring-api.txt | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) create mode 100644 doc/call-barring-api.txt +Signals PropertyChanged(string property, variant value) + +

Re: [PATCH 7/7] Fix: isimodem handling of call barring services.

Hi Denis, 2010/3/18 Denis Kenzior denk...@gmail.com: -     if (!cbd || !passwd || strlen(passwd) 4 || cls != 7) +     if (!cbd || !lock) +             goto error; +     if (!passwd || strlen(passwd) != 4 || strspn(passwd, 0123456789) != 4)               goto error; I suggest not doing

Re: [PATCH 7/7] Fix: isimodem handling of call barring services.

Hi Pekka, Hi Denis, 2010/3/18 Denis Kenzior denk...@gmail.com: - if (!cbd || !passwd || strlen(passwd) 4 || cls != 7) + if (!cbd || !lock) + goto error; + if (!passwd || strlen(passwd) != 4 || strspn(passwd, 0123456789) != 4) goto error; I suggest not

[PATCH] huawei: use GSM permissive parser instead of V1.

With V1 parser the driver fails to detect when a SMS is successfully sent and keeps re-trying until Max retries. --- plugins/huawei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 1492446..41ad636 100644 --- a/plugins/huawei.c

Re: [PATCH] huawei: use GSM permissive parser instead of V1.

Hi João, Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [patch 2/6] Generic PPP control protocol

On Wed, 17 Mar 2010 00:06:34 -0700 Marcel Holtmann mar...@holtmann.org wrote: +struct pppcp_data; Why is this needed? this is needed because we have some circular dependencies in the pppcp_data structure and the pppcp_actions structure. ___