Hi Denis,
On 03/23/2010 02:27 AM, Denis Kenzior wrote:
Hi Zhenhua,
---
gatchat/gatserver.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index 1ffc2c3..9683fa3 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
Rebase with latest upstream and resent it.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
---
gatchat/gatserver.c | 110 ++-
1 files changed, 109 insertions(+), 1 deletions(-)
diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index 6579b38..c207bd8 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
@@ -308,9 +308,117 @@ nex
On Tuesday 23 March 2010 04:22:00 Marcel Holtmann, you wrote:
> If you have variables that are only valid inside the scope of a
> statement, then I prefer if you only declare them there. This makes the
> code a bit simpler to read. Check the patch I just pushed to give you an
> example.
If you're
Hi Remi,
> > If you have variables that are only valid inside the scope of a
> > statement, then I prefer if you only declare them there. This makes the
> > code a bit simpler to read. Check the patch I just pushed to give you an
> > example.
>
> If you're serious about that, you should turn on C
On Mon, 22 Mar 2010 23:45:14 -0700
Marcel Holtmann wrote:
> please try to keep the code flow inside the functions as simple as
> possible. Otherwise things like this happen.
One suggestion I have for the future is to actually send your patches
to the mailing list for review, even if you've alrea
Hi Yang,
> ---
> src/stkutil.c | 88
> +
src/stkutil.h |
> 11 +++
> 2 files changed, 99 insertions(+), 0 deletions(-)
Your patch was fine as is and I applied it, however I still managed to nitpick
some style issues which I fixed
On Mon, 22 Mar 2010 23:45:14 -0700
Marcel Holtmann wrote:
> And there was another problem with one variable being
> guint16, but the is_option casts it back to guint8. We can't really have
> that. Once you start casting on that scale the compiler will not warn
> you about type mismatches or if th
From: Pekka Pessi
Add support for lock codes AG and AC (MMI codes 333 and 353. respectively).
---
drivers/isimodem/call-barring.c | 153 ---
drivers/isimodem/ss.h | 28
2 files changed, 63 insertions(+), 118 deletions(-)
diff --git a/dri
Hi Kristen,
> > And there was another problem with one variable being
> > guint16, but the is_option casts it back to guint8. We can't really have
> > that. Once you start casting on that scale the compiler will not warn
> > you about type mismatches or if the value of argument is too big for its
On Tue, 23 Mar 2010 10:56:00 -0700
Marcel Holtmann wrote:
> Hi Kristen,
>
> > > And there was another problem with one variable being
> > > guint16, but the is_option casts it back to guint8. We can't really have
> > > that. Once you start casting on that scale the compiler will not warn
> > > y
Hi Kristen,
> On Tue, 23 Mar 2010 10:56:00 -0700
>
> Marcel Holtmann wrote:
> > Hi Kristen,
> >
> > > > And there was another problem with one variable being
> > > > guint16, but the is_option casts it back to guint8. We can't really
> > > > have that. Once you start casting on that scale the co
Hi Kristen,
> > > > And there was another problem with one variable being
> > > > guint16, but the is_option casts it back to guint8. We can't really have
> > > > that. Once you start casting on that scale the compiler will not warn
> > > > you about type mismatches or if the value of argument is
Hi Zhenhua,
> ---
> gatchat/gatserver.c | 110
> ++- 1 files changed,
109
> insertions(+), 1 deletions(-)
>
> diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
> index 6579b38..c207bd8 100644
> --- a/gatchat/gatserver.c
> +++ b/gatchat/gats
Hi Pekka,
> From: Pekka Pessi
>
> Add support for lock codes AG and AC (MMI codes 333 and 353. respectively).
First of all, please keep your commit messages less than 72 characters long
and headings less than 50 characters long.
Secondly, please keep your patches whitespace clean, there are s
15 matches
Mail list logo
