Hi Kristen,
> Here are a couple bug fixes for the PPP authentication. First patch
> fixes the seg fault when the secret is empty, as reported by marcel.
> Second, if we do fail to authenticate, we need to change ppp phases
> to terminate the link.
>
> Kristen Carlson Accardi (2):
> ppp: allow
Hi all,
as per an IRC conversation with Denis, I post here a link [1] to the
toolchain me and the Neophysis team use to compile test applications and
libraries without the need to use our build server.
The toolchain is provided as a .tar.bz2 archive, you can unpack it in
/usr/local dir to rebui
Here are some patches which fix some issues with the error paths in
the PPP control protocol code.
Kristen Carlson Accardi (5):
ppp: fix segfault in pppcp_send_code_reject()
ppp: comment fix
ppp: send Protocol-Reject
ppp: use common code to get options from pppcp packet data
ppp: handle
fix memory corruption caused by misplaced paren when memcpying
rejected packet data into Code-Reject packet.
---
gatchat/ppp_cp.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index 137f6b9..39e872b 100644
--- a/gatchat/ppp_cp.
Put some additional clarification in comment for receiving Code-Reject
and Protocol-Reject packets.
---
gatchat/ppp_cp.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index 39e872b..f83cfba 100644
--- a/gatchat/ppp_cp.c
+++ b/ga
---
gatchat/ppp_cp.c | 71 ++---
1 files changed, 40 insertions(+), 31 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index 263fa8b..d7d70b7 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -1140,6 +1140,22 @@ static void rem
change ppp_decode to store the length of the decoded frame, so that
if we have a packet with a protocol we don't understand, we can send
Protocol-Reject packets. Modify ppp_cp code to add support for sending
Protocol-Reject packet.
---
gatchat/ppp.c | 29 +++--
gatch
if our peer sends us a Config-Reject packet, we must delete that
config item and not request that it be negotiated when we send our
next Config-Request.
---
gatchat/ppp_cp.c | 49 ++---
1 files changed, 38 insertions(+), 11 deletions(-)
diff --git a/g
Hi Kristen,
> I started tested the PPP code and run into a simple crash when not
> providing username and password. This should be possible.
>
> Program terminated with signal 11, Segmentation fault.
> #0 0x003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
> (gdb) bt
> #0 0x003457e
Hi Kristen,
> Here are some patches which fix some issues with the error paths in
> the PPP control protocol code.
>
> Kristen Carlson Accardi (5):
> ppp: fix segfault in pppcp_send_code_reject()
> ppp: comment fix
> ppp: send Protocol-Reject
> ppp: use common code to get options from ppp
Here are a couple bug fixes for the PPP authentication. First patch
fixes the seg fault when the secret is empty, as reported by marcel.
Second, if we do fail to authenticate, we need to change ppp phases
to terminate the link.
Kristen Carlson Accardi (2):
ppp: allow empty secret for chap chall
Just do a checksum over the identifier if we have an empty password
for our chap secret.
---
gatchat/ppp_auth.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
index 6c3913e..95b2f96 100644
--- a/gatchat/ppp_auth.c
+++ b/gatchat/pp
---
gatchat/ppp_auth.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
index 95b2f96..fe3c501 100644
--- a/gatchat/ppp_auth.c
+++ b/gatchat/ppp_auth.c
@@ -128,7 +128,8 @@ static void chap_process_failure(struct auth_data *data,
gu
On Fri, 26 Mar 2010 19:24:46 -0700
Marcel Holtmann wrote:
> Hi Kristen,
>
> > I started tested the PPP code and run into a simple crash when not
> > providing username and password. This should be possible.
> >
> > Program terminated with signal 11, Segmentation fault.
> > #0 0x003457e7f2f
On Fri, 26 Mar 2010 19:29:00 -0700
Marcel Holtmann wrote:
> Hi Kristen,
>
> > Here are some patches which fix some issues with the error paths in
> > the PPP control protocol code.
> >
> > Kristen Carlson Accardi (5):
> > ppp: fix segfault in pppcp_send_code_reject()
> > ppp: comment fix
>
Hi Kristen,
> > > I started tested the PPP code and run into a simple crash when not
> > > providing username and password. This should be possible.
> > >
> > > Program terminated with signal 11, Segmentation fault.
> > > #0 0x003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
> > > (gdb
Hi Kristen,
> Here are a couple bug fixes for the PPP authentication. First patch
> fixes the seg fault when the secret is empty, as reported by marcel.
> Second, if we do fail to authenticate, we need to change ppp phases
> to terminate the link.
>
> Kristen Carlson Accardi (2):
> ppp: allow
17 matches
Mail list logo