[PATCH 6/6] calypso: Create STK atom and reorder initialisation.

See comment in the code. The Sim Toolkit apps seem to work rather reliably with this, tested on both PIN-enabled and unprotected cards. --- plugins/calypso.c | 81 +++- 1 files changed, 54 insertions(+), 27 deletions(-) diff --git a/plugins/calyp

[PATCH 5/6] atutil: Parse CMS and CME error codes.

From: root --- drivers/atmodem/atutil.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/atutil.c b/drivers/atmodem/atutil.c index 5dad679..e668602 100644 --- a/drivers/atmodem/atutil.c +++ b/drivers/atmodem/atutil.c @@ -40,6 +40,12 @@ void decode_at_

[PATCH 4/6] calypso: Enable AT extended error codes.

The STK driver tries to interpret the codes. --- plugins/calypso.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/calypso.c b/plugins/calypso.c index 7798e10..5367684 100644 --- a/plugins/calypso.c +++ b/plugins/calypso.c @@ -178,6 +178,8 @@ static void setup_mod

[PATCH 3/6] calypsomodem: Add a Calypso STK driver.

--- Makefile.am |3 +- drivers/calypsomodem/calypsomodem.c |2 + drivers/calypsomodem/calypsomodem.h |5 + drivers/calypsomodem/stk.c | 277 +++ 4 files changed, 286 insertions(+), 1 deletions(-) create mode 100644 driv

[PATCH 2/6] calypso: Check if SIM is present on modem startup.

Like in case of MBM modem, the SIM slot is not easily accessible while the device is running so we assume there's no need to check for SIM presence after startup. --- plugins/calypso.c | 36 +--- 1 files changed, 33 insertions(+), 3 deletions(-) diff --git a/plug

[PATCH 1/6] phonesim: Don't use VENDOR_PHONESIM for Calypso.

Also move the STK initialisation to post-sim because it is more logical there (even if it makes no difference under phonesim). I'm not sure if there's any user of the "calypso" mode in phonesim driver now, perhaps it can be removed. --- plugins/phonesim.c |6 -- 1 files changed, 4 inserti

Re: [SMS D-Bus v5 14/17] automake: fix generation of symlinks for headers

Hi Inaky, > When running 'make distcheck' from a vpath build directory (ie: one > that is not where the source lives), the target headers in > include/ofono are not generated properly due to a typo in the > Makefile.am, that is using _srcdir where _buildir should be being > used. > --- > Makefile

[SMS D-Bus v5 17/17] sms: add test case for state change signals

From: Inaky Perez-Gonzalez --- test/test-sms-msg-state-change | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100755 test/test-sms-msg-state-change diff --git a/test/test-sms-msg-state-change b/test/test-sms-msg-state-change new file mode 100755 i

[SMS D-Bus v5 16/17] sms: add test case for message cancel

From: Inaky Perez-Gonzalez --- test/test-sms-msg-cancel | 173 ++ 1 files changed, 173 insertions(+), 0 deletions(-) create mode 100755 test/test-sms-msg-cancel diff --git a/test/test-sms-msg-cancel b/test/test-sms-msg-cancel new file mode 100755 in

[SMS D-Bus v5 15/17] sms: document variable usage in sms_msg_send()

From: Inaky Perez-Gonzalez --- src/sms.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index e648fd0..2b21e0c 100644 --- a/src/sms.c +++ b/src/sms.c @@ -851,6 +851,9 @@ enum sms_msg_send_flags { * is created by tx_queue_entry_new() and g_queue

[SMS D-Bus v5 14/17] automake: fix generation of symlinks for headers

From: Inaky Perez-Gonzalez When running 'make distcheck' from a vpath build directory (ie: one that is not where the source lives), the target headers in include/ofono are not generated properly due to a typo in the Makefile.am, that is using _srcdir where _buildir should be being used. --- Make

[SMS D-Bus v5 13/17] sms: test code for message's D-Bus GetProperties

From: Inaky Perez-Gonzalez --- test/test-sms-msg-get-properties | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) create mode 100755 test/test-sms-msg-get-properties diff --git a/test/test-sms-msg-get-properties b/test/test-sms-msg-get-properties new file mod

[SMS D-Bus v5 12/17] sms: document SMS Message's D-Bus 'To' property

From: Inaky Perez-Gonzalez --- doc/sms-api.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/sms-api.txt b/doc/sms-api.txt index 2bf588f..70eb492 100644 --- a/doc/sms-api.txt +++ b/doc/sms-api.txt @@ -109,3 +109,8 @@ Properties string State

[SMS D-Bus v5 11/17] sms: Implement D-Bus SMS-MSG::GetProperties

From: Inaky Perez-Gonzalez Currently this only returns the state of the SMS message and the destination number. Note we make the @receiver field in 'struct tx_queue_entry' be always filled out in __ofono_sms_txq_submit() as now it is always needed for the properties, not only when a Status Report

[SMS D-Bus v5 10/17] sms: introduce sms_msg_cancel and its D-Bus wrapper

From: Inaky Perez-Gonzalez This introduces the ability to cancel a pending SMS message, accessible via an internal API and over a D-Bus wrapper. Sending a note to the network to cancel an in-transit message is not yet implemented. Note the test case code requires follow up commits that propagat

[SMS D-Bus v5 09/17] sms: send PropertyChanged signals on state change

From: Inaky Perez-Gonzalez This hooks sms_msg_stch_dbus_cb() into the SMS state change callback so that a D-Bus signal will be emitted whenever an SMS Message transitions state. This allows a client to track, if desired, what is going on with the SMS Message it cares about. --- src/sms.c | 36

[SMS D-Bus v5 08/17] sms: export outgoing messages over D-Bus

From: Inaky Perez-Gonzalez Splits sms_send_message() into a D-Bus front end and an internal API: - sms_msg_send(), a full C interface for SMS sending - dbus_sms_msg_send(): adapts sms_msg_send() to be a D-Bus call, exporting the object on the bus, returning its name and setting up all the c

[SMS D-Bus v5 07/17] sms: introduce a state change callback for messages

From: Inaky Perez-Gonzalez When the SMS message going through the TX hoops changes states, call the given callback function (if any). This will be used later to hook up the D-Bus propagation of property changed signals. Note this will do away with the ofono_sms_txq_submit_cb callback, as it can

[SMS D-Bus v5 06/17] sms: introduce the Wait-for-Status-Report state

From: Inaky Perez-Gonzalez A WSR (Waiting for Status Report) state definition is added to the state transtition machine; as well, a queue (ofono_sms->tx_wfaq) where messages waiting for an status report are queued. When the message's delivery is acknowledged, the message is removed from the queue

[SMS D-Bus v5 05/17] sms: introduce bare state machine and transitions

From: Inaky Perez-Gonzalez This adds state to outgoing/in-transit SMS messages. This will be used later on for persistence / D-Bus, when the SMS life cycle is expanded. The state is a variable in the 'struct tx_queue_entry' which gets updated as messages go through the hoops. --- src/ofono.h |

[SMS D-Bus v5 04/17] sms: document handle_sms_status_report()

From: Inaky Perez-Gonzalez --- src/sms.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index dce7d36..d0563d0 100644 --- a/src/sms.c +++ b/src/sms.c @@ -930,6 +930,15 @@ static void handle_deliver(struct ofono_sms *sms, const struct sms *

[SMS D-Bus v5 03/17] sms: document the org.ofono.SmsMessage interface

From: Inaky Perez-Gonzalez --- doc/sms-api.txt | 49 +++-- 1 files changed, 47 insertions(+), 2 deletions(-) diff --git a/doc/sms-api.txt b/doc/sms-api.txt index 1fc32ac..2bf588f 100644 --- a/doc/sms-api.txt +++ b/doc/sms-api.txt @@ -22,9 +22,27 @@

[SMS D-Bus v5 02/17] sms: _txq_submit() returns pointer to object

From: Inaky Perez-Gonzalez This makes __ofono_sms_txq_submit() return a pointer to the newly allocated message object, from where the message ID can be recovered. This is needed for future commits where the object pointer is needed to use it as the handle for the D-Bus wrapping functionality. Th

[SMS D-Bus v5 01/17] sms: replace sequential SMS message ID with hash

From: Inaky Perez-Gonzalez The SMS messages's ID number (used for history, D-Bus naming and storage in external database) is updated to use a hash (based on PDUs and submission time) to further avoid ID collision concerns. --- src/sms.c | 50 +-

[SMS D-Bus v5 00/17] pull request

From: Inaky Perez-Gonzalez v5 (there have been more than five submissions, but whatever) contains the following changes as requested by Dennis: - multi fragment message ref and the unique message ID are decoupled now. this allows... - UUID is generated in tx_queue_entry_new() - UUID is expan

Re: [SMS D-Bus 02/19] sms: introduce message ID API

On Thu, 2010-08-05 at 13:21 -0500, Denis Kenzior wrote: > > I still could use clarification on which other fields of the 'struct > > sms' union you want to have hashed other than the PDU payloads. > > > > All of them. Again, it might be much simpler to do this over the > fragments when they are

Re: [PATCH] simfilesystem: make EFimg a linear fixed file type

Hi Kristen, On 08/05/2010 04:33 PM, Kristen Carlson Accardi wrote: > --- > src/simfilesystem.cpp |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.o

[PATCH] simfilesystem: make EFimg a linear fixed file type

--- src/simfilesystem.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/simfilesystem.cpp b/src/simfilesystem.cpp index 6781ac9..d193328 100644 --- a/src/simfilesystem.cpp +++ b/src/simfilesystem.cpp @@ -110,7 +110,7 @@ static SimFileInfo const knownFiles[] = {

[PATCH 7/7] test: add get-icon script

--- test/get-icon | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100755 test/get-icon diff --git a/test/get-icon b/test/get-icon new file mode 100755 index 000..680ae13 --- /dev/null +++ b/test/get-icon @@ -0,0 +1,25 @@ +#!/usr/bin/python + +i

[PATCH 6/7] sim: implement GetIcon dbus interface

--- src/sim.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index e19fb06..2b0b20e 100644 --- a/src/sim.c +++ b/src/sim.c @@ -731,6 +731,50 @@ static DBusMessage *sim_enter_pin(DBusConnection *conn, DBu

[PATCH 5/7] sim: read an image from an EFiidf

--- include/sim.h |6 +++ src/sim.c | 127 + 2 files changed, 133 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 6c5a657..1303203 100644 --- a/include/sim.h +++ b/include/sim.h @@ -113,6 +113,9 @@ typ

[PATCH 4/7] sim: allow partial reads of files

--- include/sim.h |5 + src/sim.c | 54 -- 2 files changed, 49 insertions(+), 10 deletions(-) diff --git a/include/sim.h b/include/sim.h index 36a99b9..6c5a657 100644 --- a/include/sim.h +++ b/include/sim.h @@ -198,6 +198,11 @@ int

[PATCH 2/7] stkutil: change uint32_t to guint32

This helps avoid needing to include any extra header files if stkutil.h is included in sim.c --- src/stkutil.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index ea9294c..44d167a 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -852,7 +85

[PATCH 3/7] sim: read EFimg

Read EFimg when the sim is ready, and store it in memory. --- src/sim.c | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index d2ed780..6d723bb 100644 --- a/src/sim.c +++ b/src/sim.c @@ -88,6 +88,8 @@ stru

[PATCH 0/7] add support for icons

This is still a wip, but I wanted to get your feedback on what I've got so far. The patch "allow partial reads of files" is still pretty much what I had before, so I haven't addressed any of your issues with it. It still doesn't do files > 256, and I'm just using the existing read functions with

[PATCH 1/7] simutil: add fileid for EFimg

--- src/simutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 29194ca..1cfc4af 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -22,6 +22,7 @@ enum sim_fileid { SIM_EFPL_FILEID = 0x2f05, SIM_EF_ICCID_FILEID = 0x2fe2

Re: [PATCH] huawei: Fix SIM state logic

Hi João, On 08/05/2010 02:13 PM, João Paulo Rechi Vita wrote: > Add support for voice-only SIM cards and enable phonebook atom for > non-voice modems. > --- Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://l

Re: [RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

Hi Sjur, On 08/05/2010 02:04 PM, Sjur Brændeland wrote: > Hi Denis, > > Denis Kenzior wrote: >>> I'm picking up a really old thread here... >> Yes a really old thread ;) > Better late than never, right? :-) > > ... Definitely :) I'm very glad you brought this back up. >>> However, I think we

[PATCH] huawei: Fix SIM state logic

Add support for voice-only SIM cards and enable phonebook atom for non-voice modems. --- plugins/huawei.c | 76 - 1 files changed, 51 insertions(+), 25 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 47d59d0..f8ada24 100644

Re: [RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

Hi Denis, Denis Kenzior wrote: >> I'm picking up a really old thread here... >Yes a really old thread ;) Better late than never, right? :-) ... >> However, I think we can solve this even simpler if we just >> call hangup for any ALERTING/DIALING call.. >This is a real gray area. On some devices

Re: [SMS D-Bus 02/19] sms: introduce message ID API

On Thu, 2010-08-05 at 13:21 -0500, Denis Kenzior wrote: > Hi Inaky, > > On 08/05/2010 01:07 PM, Inaky Perez-Gonzalez wrote: > > On Thu, 2010-08-05 at 13:02 -0500, Denis Kenzior wrote: > >> Hi Inaky, > >> > The current message id is 32 bits. Why are we stopping at 16? We could > go al

Re: [SMS D-Bus 03/19] sms: implement SHA256-based message IDs [incomplete]

On Thu, 2010-08-05 at 12:20 -0500, Denis Kenzior wrote: > Hi Inaky, > > On 08/03/2010 06:50 PM, Inaky Perez-Gonzalez wrote: > > From: Inaky Perez-Gonzalez > > > > This patch removes the sequential SMS message identification gig and > > replaces it with a 16-bit hash cookie based off message con

Re:

2010/8/5 João Paulo Rechi Vita : > > Changed sim_state to an enum type and removed an extra check which was causing > issues with pin-locked sim cards. Sorry, I've messed up a bit with git-send-email. This comment is regarding the reviewed version of "[PATCH] huawei: Fix SIM state logic". -- Joã

Re: [SMS D-Bus 02/19] sms: introduce message ID API

Hi Inaky, On 08/05/2010 01:07 PM, Inaky Perez-Gonzalez wrote: > On Thu, 2010-08-05 at 13:02 -0500, Denis Kenzior wrote: >> Hi Inaky, >> The current message id is 32 bits. Why are we stopping at 16? We could go all the way to 64 if needed... >>> >>> Well, at the end what gets sent to t

[PATCH] huawei: Fix SIM state logic

Add support for voice-only SIM cards and enable phonebook atom for non-voice modems. --- plugins/huawei.c | 79 +- 1 files changed, 54 insertions(+), 25 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 47d59d0..76dfbb8 10064

[no subject]

Changed sim_state to an enum type and removed an extra check which was causing issues with pin-locked sim cards. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [SMS D-Bus 02/19] sms: introduce message ID API

On Thu, 2010-08-05 at 13:02 -0500, Denis Kenzior wrote: > Hi Inaky, > > >> The current message id is 32 bits. Why are we stopping at 16? We could > >> go all the way to 64 if needed... > > > > Well, at the end what gets sent to the network is 16 bits right? > > So I think we're all confused h

Re: [SMS D-Bus 02/19] sms: introduce message ID API

Hi Inaky, >> The current message id is 32 bits. Why are we stopping at 16? We could >> go all the way to 64 if needed... > > Well, at the end what gets sent to the network is 16 bits right? So I think we're all confused here. This ID is not being sent to the network. It is only used for uniq

Re: [PATCH v3 2/2] huawei: add gprs context

Hi Kale On Thu, 2010-08-05 at 08:54 +0300, Kalle Valo wrote: > > >> Oh man, I have to fix my emacs settings :/ > > > > Did you find a set of emacs offset settings to get to oFono's liking? > > I've been fiddling with it for a while, but keep alking in circles > > around it. It's been too lo

Re: [SMS D-Bus 02/19] sms: introduce message ID API

On Thu, 2010-08-05 at 12:10 -0500, Denis Kenzior wrote: > Hi Inaky, > > On 08/03/2010 06:50 PM, Inaky Perez-Gonzalez wrote: > > From: Inaky Perez-Gonzalez > > > > This adds a simple API to use for generating unique IDs for SMS > > messages. Will be used by follow up commits. > > > > The ID is

Re: [SMS D-Bus 03/19] sms: implement SHA256-based message IDs [incomplete]

Hi Inaky, On 08/03/2010 06:50 PM, Inaky Perez-Gonzalez wrote: > From: Inaky Perez-Gonzalez > > This patch removes the sequential SMS message identification gig and > replaces it with a 16-bit hash cookie based off message contents. > > FIXME: [incomplete] need to figure out how to do so that id

Re: [SMS D-Bus 02/19] sms: introduce message ID API

Hi Inaky, On 08/03/2010 06:50 PM, Inaky Perez-Gonzalez wrote: > From: Inaky Perez-Gonzalez > > This adds a simple API to use for generating unique IDs for SMS > messages. Will be used by follow up commits. > > The ID is not generic, but specifc to SMS messages (due to having to > dig inside 'st

Re: [SMS D-Bus 06/19] struct tx_queue_entry: add a destructor

Hi Inaky, On 08/03/2010 06:50 PM, Inaky Perez-Gonzalez wrote: > From: Inaky Perez-Gonzalez > > Introduce a destructor function to encapsulate all the release steps > for this data type, as more are to be added later. This patch has been applied. Thanks. Regards, -Denis ___

Re: [SMS D-Bus 01/19] write_file: make transaction-safe

Hi Inaky, On 08/03/2010 06:50 PM, Inaky Perez-Gonzalez wrote: > From: Inaky Perez-Gonzalez > > write_file(), as written wasn't transaction-safe; a crash bewtween a > file being open and the buffer being written before a safe close would > leave the file with a set of undetermined contents. > >

Re: [RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

Hi Sjur, On 08/04/2010 09:21 AM, Sjur Brændeland wrote: > From: Sjur Brændeland > > This patch splits the callback hangup into hangup_all and hangup_active. > > --- > Hi Denis, > I'm picking up a really old thread here... Yes a really old thread ;) > >> Denis Kenzior wrote: > c) If you h

Re: [PATCH 4/5] Add dun_disable() to power down the modem

Hi Gustavo, On 08/04/2010 05:22 AM, Gustavo F. Padovan wrote: > When setting Powered to 0 the link rfcomm is disconnected. > --- > plugins/dun.c | 42 -- > 1 files changed, 40 insertions(+), 2 deletions(-) > > diff --git a/plugins/dun.c b/plugins/dun.c >

Re: [PATCH 3/5] Add dun_enable() function

Hi Gustavo, > +static void dun_connect_reply(DBusPendingCall *call, gpointer user_data) > +{ > + struct ofono_modem *modem = user_data; > + struct dun_data *data = ofono_modem_get_data(modem); > + const char *dev; > + DBusError derr; > + DBusMessage *reply, *msg; > + > + re

Re: [PATCH 1/5] bluetooth: define DBUS_TIMEOUT macro

Hi Gustavo, On 08/04/2010 05:22 AM, Gustavo F. Padovan wrote: > --- > plugins/bluetooth.h |2 ++ > plugins/hfp.c |6 +++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ of

RE: Huawei EM770W SIM card issues

Hi Florian, Florian Mayer (Mayer Electronics) wrote: > Hello, > > we encountered the following problem with the EM770W: If the > SIM card is > plugged in after our test system is powered on, it is not > recognised in > ofono. Even if we restart ofonod after plugging in the SIM > card. We use > th

Huawei EM770W SIM card issues

Hello, we encountered the following problem with the EM770W: If the SIM card is plugged in after our test system is powered on, it is not recognised in ofono. Even if we restart ofonod after plugging in the SIM card. We use the 2.6.35~rc5 kernel from Meego 1.1 trunk because we encountered pro