Re: [RFC PATCH 8/8] doc: update sim-api

Hi Petteri, > --- > doc/sim-api.txt |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/doc/sim-api.txt b/doc/sim-api.txt > index d5bf279..c502772 100644 > --- a/doc/sim-api.txt > +++ b/doc/sim-api.txt > @@ -125,3 +125,7 @@ Propertiesboolean Present [readonly

Re: [PATCH 04/13] doc: Update property name to match code.

Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: > --- > doc/stk-api.txt |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists

[PATCH 13/13] [RfC] API for STK driver to signal executed commands.

Some modems are able to handle some proactive commands in their firmware or otherwise, if the command doesn't require input from user. Nevertheles ofono may need to update internal state or notify the user where necessary. With this api the driver can notify core that a command is being executed i

[PATCH 12/13] stk: Handle the Play Tone proactive command.

A memory leak in error path has been fixed since the previous version. --- src/stk.c | 139 + 1 files changed, 139 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index c06bf99..b3d2b40 100644 --- a/src/stk.c +++ b/src/

[PATCH 11/13] stkagent: Add PlayTone and LoopTone requests.

--- src/stkagent.c | 94 src/stkagent.h | 13 2 files changed, 107 insertions(+), 0 deletions(-) diff --git a/src/stkagent.c b/src/stkagent.c index 354b87d..e123bd2 100644 --- a/src/stkagent.c +++ b/src/stkagent.c @@ -861,3 +86

[PATCH 10/13] stk: Apply STK text attributes as html.

--- src/stk.c | 146 +++-- 1 files changed, 122 insertions(+), 24 deletions(-) diff --git a/src/stk.c b/src/stk.c index 01f4e0b..c06bf99 100644 --- a/src/stk.c +++ b/src/stk.c @@ -256,6 +256,22 @@ void __ofono_cbs_sim_download(struct ofono_

[PATCH 08/13] stk: IdleModeIcon and MainMenuIcon properties.

--- src/stk.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index 3635579..863a6dd 100644 --- a/src/stk.c +++ b/src/stk.c @@ -72,6 +72,7 @@ struct ofono_stk { guint remove_agent_source; struct extern_req *exter

[PATCH 09/13] stk: Simplify and add icon to alphaId api.

The assumption is now that stk_alpha_id_set will handle NULL or empty alphaIds or icons. --- src/stk.c | 36 ++-- 1 files changed, 10 insertions(+), 26 deletions(-) diff --git a/src/stk.c b/src/stk.c index 863a6dd..01f4e0b 100644 --- a/src/stk.c +++ b/src/stk.c @

[PATCH 07/13] stk: Add icon ID information in stk_menu.

--- src/stk.c | 25 ++--- src/stkagent.c |2 +- src/stkagent.h |2 +- 3 files changed, 24 insertions(+), 5 deletions(-) diff --git a/src/stk.c b/src/stk.c index c5478b8..3635579 100644 --- a/src/stk.c +++ b/src/stk.c @@ -256,19 +256,28 @@ void __ofono_cbs_sim_do

[PATCH 06/13] stk: Pass icon IDs in stk agent request parameters.

--- src/stk.c | 28 ++-- src/stkagent.c | 39 +++ src/stkagent.h | 32 ++-- 3 files changed, 55 insertions(+), 44 deletions(-) diff --git a/src/stk.c b/src/stk.c index 3792d2f..c5478b8 100644 --- a/

[PATCH 05/13] doc: Add STK properties relevant for icons.

--- doc/stk-api.txt | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index e4993c1..c29872a 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -61,17 +61,27 @@ Properties string IdleModeText idle. Th

[PATCH 04/13] doc: Update property name to match code.

--- doc/stk-api.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index f5b9ebc..e4993c1 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -55,10 +55,10 @@ Signals PropertyChanged(string property, variant value)

[PATCH 03/13] atmodem: Handle pauses in DTMF string

--- drivers/atmodem/voicecall.c | 163 +++ 1 files changed, 135 insertions(+), 28 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index b3c658f..54cbe4f 100644 --- a/drivers/atmodem/voicecall.c +++ b/drivers/atmodem/voic

[PATCH 02/13] stk: Handle the Send DTMF proactive command.

In this version 'p' is used as the pause character in DTMF strings as it seems in more widespread use than comma. ISImodem already understands 'p'. atmodem support comes in the next patch. --- src/stk.c | 177 +--- 1 files changed, 168 ins

[PATCH 01/13] voicecall: __ofono_voicecall_send_tone internal api.

This provides a way for other atoms to send DTMF tones during a call. --- src/ofono.h |4 src/voicecall.c | 16 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 6c7f649..6efd9ac 100644 --- a/src/ofono.h +++ b/src/ofono.

Re: CDMA SMS Handling

Hi Rajesh, > I did an analysis of the existing smsutils fuctionalities for the code > reusability. If we can make the struct sms common for both GSM and CDMA > by having them as union members, then we can re-use sms assembly > serialization and fragmentation/de-fragmentation logic with only minor

Re: [RFC online/offline atoms PATCH 3/4] gprs: watch modem state

Hi Pekka, On 10/05/2010 06:35 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Indicate detach when modem is in offline state. > --- > src/gprs.c | 26 ++ > 1 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/src/gprs.c b/src/gprs.c > index 3f08

Re: [RFC online/offline atoms PATCH 2/4] sms: watch modem state

Hi Pekka, On 10/05/2010 06:35 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Allow use of SMS atom in online and offline states. The messages are > queued but not sent in offline mode. Errors occurring when an SMS is > being sent while transition from online to offline are handled > g

Re: [RFC online/offline atoms PATCH 1/4] modem: add modem state watch

Hi Andras & Pekka, > diff --git a/src/ofono.h b/src/ofono.h > index 6c7f649..9021f51 100644 > --- a/src/ofono.h > +++ b/src/ofono.h > @@ -177,6 +177,21 @@ unsigned int > __ofono_modemwatch_add(ofono_modemwatch_cb_t cb, void *user, > ofono_destroy_func destr

Re: [PATCH 1/2] stkagent: Add PlayTone and LoopTone requests.

Hi Andrew, On 10/11/2010 02:51 AM, Andrzej Zaborowski wrote: > --- > src/stkagent.c | 94 > > src/stkagent.h | 13 > 2 files changed, 107 insertions(+), 0 deletions(-) Both patches look good to me, but no longer apply. Can y

Re: [PATCH v2 0/3] Patch Description

Hi Yang, On 09/30/2010 12:52 PM, Yang Gu wrote: > This series of patches fix the compilation problem, as well as some memory > leak. But the main focus is to enable Qt script so that phonesim GUI can be > controlled using JavaScript. In the meantime, D-Bus support is added for the > sake of tes

Re: [PATCH 1/2] stk: Expose icon IDs on D-Bus.

Hi Andrew, On 10/07/2010 09:20 AM, Andrzej Zaborowski wrote: > Update the docs to match the properties in stk.c. > --- > doc/stk-api.txt | 16 ++- > src/stk.c | 112 > ++- > src/stkagent.c | 41 > src/stkage

Re: huawei e1550

В Срд, 13/10/2010 в 15:51 +0300, Kalle Valo пишет: > Alexander A Khryukin writes: > > > # patch -p1 < ofono.patch > > > > patching file plugins/huawei.c > > Hunk #1 FAILED at 624. > > 1 out of 1 hunk FAILED -- saving rejects to file plugins/huawei.c.rej > > > > im using > > http://www.kernel.org

Re: [PATCH] Add Ericsson c3607w and HP f3607gw/f3307 devices to udev rules file

Hi Torgny, On 10/12/2010 07:41 AM, Torgny Johansson wrote: > --- > plugins/ofono.rules | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) > Patch has been applied with a slightly modified commit header. Regards, -Denis ___ o

Re: [PATCH] Document the SS control string API

Hi Alexander, On 10/13/2010 06:33 AM, Alexander Kanavin wrote: > --- > doc/supplementaryservices-api.txt | 95 +++- > 1 files changed, 92 insertions(+), 3 deletions(-) > > + The first return argument and the corresponding > +

Re: [PATCH 3/4] simfs: fix incorrect math when calculating length to copy

Hi Kristen, On 10/04/2010 05:33 PM, Kristen Carlson Accardi wrote: > --- > src/simfs.c | 21 - > 1 files changed, 12 insertions(+), 9 deletions(-) > I fixed this slightly differently, can you check that my fix is correct? Regards, -Denis __

Re: [PATCH 2/4] sim: implement GetIcon

Hi Kristen, On 10/04/2010 05:33 PM, Kristen Carlson Accardi wrote: > --- > src/sim.c | 187 > + > 1 files changed, 187 insertions(+), 0 deletions(-) > I applied this patch but refactored it afterwards to avoid a potential memory leak

Re: huawei e1550

В Срд, 13/10/2010 в 15:14 +0300, Kalle Valo пишет: > Alexander A Khryukin writes: > > >> Sorry, I wasn't able to immeadiately say from the logs what went wrong. > >> Can you get a log which includes AT commands? It would help a lot. > >> > >> Just run this command to get the logs: > >> > >> OFO

Re: huawei e1550

Alexander A Khryukin writes: > # patch -p1 < ofono.patch > > patching file plugins/huawei.c > Hunk #1 FAILED at 624. > 1 out of 1 hunk FAILED -- saving rejects to file plugins/huawei.c.rej > > im using > http://www.kernel.org/pub/linux/network/ofono/ofono-0.31.tar.bz2 My patch was against lates

Re: huawei e1550

В Срд, 13/10/2010 в 15:14 +0300, Kalle Valo пишет: > Alexander A Khryukin writes: > > >> Sorry, I wasn't able to immeadiately say from the logs what went wrong. > >> Can you get a log which includes AT commands? It would help a lot. > >> > >> Just run this command to get the logs: > >> > >> OFO

Re: huawei e1550

Alexander A Khryukin writes: >> Sorry, I wasn't able to immeadiately say from the logs what went wrong. >> Can you get a log which includes AT commands? It would help a lot. >> >> Just run this command to get the logs: >> >> OFONO_AT_DEBUG=1 /usr/sbin/ofonod -n >> >> What's the exact version o

Re: huawei e1550

В Птн, 08/10/2010 в 21:25 +0300, Kalle Valo пишет: > Hi Alexander, > > Alexander A Khryukin writes: > > > В Птн, 08/10/2010 в 16:20 +0400, Alexander A Khryukin пишет: > >> Hi all. > >> I have a huawei 1550 GSM-modem. > >> When i plug it to usb > >> > >> > > [...] > > > Hm, now network visib

[PATCH] Document the SS control string API

--- doc/supplementaryservices-api.txt | 95 +++- 1 files changed, 92 insertions(+), 3 deletions(-) diff --git a/doc/supplementaryservices-api.txt b/doc/supplementaryservices-api.txt index 5ef123e..d80770a 100644 --- a/doc/supplementaryservices-api.txt +++ b/doc/

Re: [PATCH 2/3] Fix COLR typo

Hi Alex, > >> src/call-settings.c |2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > > > > patch has been applied. Thanks. > > Why hasn't the third patch been applied? I'll resend it now - there's been > a small tweak. because it never showed up ;) Please re-send it. Regard

Re: [PATCH 2/3] Fix COLR typo

On 07.10.2010 14:11, ext Marcel Holtmann wrote: src/call-settings.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Why hasn't the third patch been applied? I'll resend it now - there's been a small tweak. Regards, Alex __

[PATCH] isimodem/sms: do not try to save SCA to SIM

From: Pekka Pessi It does not make sense to overwrite the SCA on SIM card, especially with random bytes from the stack. AT command +CSCA does not write to SIM either, rather it saves the SCA address to be used with further text mode SMSs. --- drivers/isimodem/sms.c | 87 --

[RFC] AGPS Support

Please find attached a proposal for both a DBUS and Modem API for AGPS support. There are some minor changes compared to the proposal from May 14, 2010. This proposal introduces two AGPS features: 1) Fine time injection - the cellular modem has access to accurate timing information that can hel