[PATCH 0/3] Emergency Calls (2nd round)

2010-11-09 Thread Andras Domokos
From: Andras Domokos Here is a new proposal for emergency calls handling. Steps in handling emergency calls: - subscribe to modem online notifications (add modem online watcher) - an emergency call detected (phone number is emergency number) - increment emergency mode - switch modem online if

[RFC PATCH 1/3] modem: add modem online-offline watch

2010-11-09 Thread Andras Domokos
Signed-off-by: Andras Domokos --- src/modem.c | 46 ++ src/ofono.h |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 3776461..f73cc1d 100644 --- a/src/modem.c +++ b/src/modem.c @@ -72,6 +

[RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-09 Thread Andras Domokos
Signed-off-by: Andras Domokos --- src/modem.c | 53 + src/ofono.h |4 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index f73cc1d..d7ad90e 100644 --- a/src/modem.c +++ b/src/modem.c @@ -72,

[RFC PATCH 3/3] voicecall: add emergency call handling

2010-11-09 Thread Andras Domokos
Signed-off-by: Andras Domokos --- src/voicecall.c | 101 ++- 1 files changed, 100 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index bd64432..0268ce1 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -52,6

Re: [RFC PATCH 1/3] modem: add modem online-offline watch

2010-11-09 Thread Marcel Holtmann
Hi Andras, > Signed-off-by: Andras Domokos please redo the patches without the Signed-off-by line. It is mentioned in doc/coding-style.txt that we do not use this. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinf

Re: [RFC PATCH 1/3] modem: add modem online-offline watch

2010-11-09 Thread Denis Kenzior
Hi Andras, On 11/09/2010 02:59 AM, Andras Domokos wrote: > > Signed-off-by: Andras Domokos As Marcel already mentioned, we do not use Signed-off-by. Otherwise this patch looks good to me. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:/

Re: [RFC PATCH 3/3] voicecall: add emergency call handling

2010-11-09 Thread Denis Kenzior
Hi Andras, On 11/09/2010 03:00 AM, Andras Domokos wrote: > > Signed-off-by: Andras Domokos > --- > src/voicecall.c | 101 > ++- > 1 files changed, 100 insertions(+), 1 deletions(-) > > diff --git a/src/voicecall.c b/src/voicecall.c > index

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-09 Thread Denis Kenzior
Hi Andras, On 11/09/2010 02:59 AM, Andras Domokos wrote: > > Signed-off-by: Andras Domokos > --- > src/modem.c | 53 + > src/ofono.h |4 > 2 files changed, 57 insertions(+), 0 deletions(-) > > diff --git a/src/modem.c b/src/modem.c

Re: [PATCH] Add test/reset-pin

2010-11-09 Thread Denis Kenzior
Hi Pekka, On 11/08/2010 02:28 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > test/reset-pin | 23 +++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100755 test/reset-pin > Patch has been applied, thanks. Regards, -Denis _

Re: [PATCHv2 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

2010-11-09 Thread Sjur Brændeland
Hi Marcel. > I do need another look at the RTNL magic and casting. That always drives > my crazy when I look at that. In the meantime, please address these > details first. I have some RTNL unit tests ready if your're interested. Also I hope I have closed most open issues from your review in the

Re: [PATCH] Added implementation for "ReportVoiceCall", "ReportTextMessage", "Release" methods and related code.Please take a look and give me feedback on the code quality , thinks that need to be ch

2010-11-09 Thread Denis Kenzior
On 11/03/2010 06:20 PM, Rajyalakshmi Bommaraju wrote: > --- > Makefile.am |6 + > plugins/history.c | 438 + > plugins/history_agent.c | 453 > +++ > plugins/history_agent.h | 103

[PATCH] Force requirement for filename option in cmd line

2010-11-09 Thread Gustavo F. Padovan
--- src/main.cpp |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index d601ac2..d4327b1 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -35,7 +35,7 @@ static void usage() int main(int argc, char **argv) { QApplication app(argc, argv

[PATCH] Add SIM reset button

2010-11-09 Thread Gustavo F. Padovan
AT+CRST now send a reset resquest command --- src/control.cpp|6 ++ src/control.h |1 + src/controlbase.ui | 16 3 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 2e22f69..1fa1978 100644 --- a/src/control

Re: [PATCH] Add test/reset-pin

2010-11-09 Thread Marcel Holtmann
Hi Pekka, > > --- > > test/reset-pin | 23 +++ > > 1 files changed, 23 insertions(+), 0 deletions(-) > > create mode 100755 test/reset-pin > > > > Patch has been applied, thanks. I saw that Denis fixed the Makefile.am for you. Please keep in mind to ensure that test scri

Re: [PATCH] Force requirement for filename option in cmd line

2010-11-09 Thread Denis Kenzior
Hi Gustavo, On 11/09/2010 12:45 PM, Gustavo F. Padovan wrote: > --- > src/main.cpp |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:/

RE: Can I modify CallingLineRestriction(the Property of CallSetting) value to "disabled" or "enabled"

2010-11-09 Thread Ding, HaitaoX
Hi, yang Thanks a lot for your feedback. According to your tip , I tried to set "HideCallerId" to "default", "disabled" and "enabled", and I can verify by run list-modem script that "HideCallerId" had been modified . but I still could find phone number on both called party and calling party