[PATCH 1/9] coding-style: add rule about checking NULL pointer

2010-11-27 Thread Lucas De Marchi
--- doc/coding-style.txt | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index eccdacc..76e6053 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -209,6 +209,27 @@ However if the enum comes from

[PATCH 0/9] coding-style: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch series creates a new coding style rule about checking pointers to NULL and change the source code accordingly. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 3/9] unit: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- unit/test-caif.c|2 +- unit/test-mux.c |2 +- unit/test-simutil.c |4 ++-- 3 files changed, 4 insertions(+), 4

[PATCH 4/9] gisi: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- gisi/client.c | 46 +++--- gisi/iter.c |2 +- gisi/server.c |6 +++--- gisi/ve

[PATCH 5/9] examples: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- examples/nettime.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/nettime.c b/examples/nettime

[PATCH 6/9] gatchat: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- gatchat/gatchat.c | 46 +++--- gatchat/gathdlc.c |8 gatchat/gatio.

[PATCH 7/9] gdbus: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- gdbus/object.c | 24 gdbus/polkit.c |2 +- gdbus/watch.c | 21 ++--- 3 files cha

[PATCH 8/9] plugins: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- plugins/bluetooth.c |6 +++--- plugins/calypso.c |4 ++-- plugins/hfp.c | 20 ++---

RE: [PATCH 1/9] coding-style: add rule about checking NULL pointer

2010-11-27 Thread Rajesh.Nagaiah
Hi Lucas > +M13: Check for pointer being NULL > += > + > +When checking if a pointer or a return value is NULL, explicitly > +compare to NULL rather than use the shorter check with "!" operator. > + > +Example: > +1) > +array = g_try_new0(int, 20); > +if (!array)

Re: [RFC 1/7] simutil: Add EFcfis and EFcphs-cff file Ids

2010-11-27 Thread Denis Kenzior
Hi Jeevaka, On 11/26/2010 12:23 AM, Jeevaka Badrappan wrote: > --- > src/simutil.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofo

Re: [PATCH] Add support for TTY query

2010-11-27 Thread Denis Kenzior
Hi Lucas, On 11/26/2010 06:06 PM, Lucas De Marchi wrote: > --- > src/default.xml |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.o

Re: [PATCH] phonesim: implement ctm atom

2010-11-27 Thread Denis Kenzior
Hi Lucas, On 11/26/2010 06:44 PM, Lucas De Marchi wrote: > --- > plugins/phonesim.c | 140 > ++-- > 1 files changed, 136 insertions(+), 4 deletions(-) > > diff --git a/plugins/phonesim.c b/plugins/phonesim.c > index d2faf42..be2f931 100644 > ---

Re: [PATCH 1/9] coding-style: add rule about checking NULL pointer

2010-11-27 Thread Lucas De Marchi
On Sat, Nov 27, 2010 at 1:57 PM, wrote: >> +3) >> +array = g_try_new0(int, 20); >> +if (!array)  // Correct > > Shouldn't be if (array == NULL) // Correct :)? You are right. Thanks, fixed. Lucas De Marchi ___ ofono mailing list ofono@ofono.org http:/

[PATCH 1/2] phonesim: implement ctm atom

2010-11-27 Thread Lucas De Marchi
--- plugins/phonesim.c | 150 ++-- 1 files changed, 146 insertions(+), 4 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d2faf42..d10eda8 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -46,6 +46,7 @@ #include

[PATCH 2/2] TODO: Mark CTM task as done

2010-11-27 Thread Lucas De Marchi
--- TODO | 11 --- doc/features.txt |7 +++ 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/TODO b/TODO index c484871..4443ac1 100644 --- a/TODO +++ b/TODO @@ -479,17 +479,6 @@ Miscellaneous Complexity: C2 Owner: Gustavo F Padovan -- TTY (hear

[PATCH 1/9] coding-style: add rule about checking NULL pointer

2010-11-27 Thread Lucas De Marchi
--- doc/coding-style.txt | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index eccdacc..9dfdc09 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -209,6 +209,27 @@ However if the enum comes from

[PATCH 4/9] gisi: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- gisi/client.c | 46 +++--- gisi/iter.c |2 +- gisi/server.c |6 +++--- gisi/ve

[PATCH 3/9] unit: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- unit/test-caif.c|2 +- unit/test-mux.c |2 +- unit/test-simutil.c |4 ++-- 3 files changed, 4 insertions(+), 4

[PATCH 5/9] examples: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- examples/nettime.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/nettime.c b/examples/nettime

[PATCH 6/9] gatchat: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- gatchat/gatchat.c | 46 +++--- gatchat/gathdlc.c |8 gatchat/gatio.

[PATCH 7/9] gdbus: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- gdbus/object.c | 24 gdbus/polkit.c |2 +- gdbus/watch.c | 21 ++--- 3 files cha

[PATCH 8/9] plugins: explicitly compare pointers to NULL

2010-11-27 Thread Lucas De Marchi
This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // --- plugins/bluetooth.c |6 +++--- plugins/calypso.c |4 ++-- plugins/hfp.c | 20 ++---

RE: [PATCH 1/5] text-telephony: add public header

2010-11-27 Thread Bastian, Waldo
> > + void (*remove)(struct ofono_ctm *tt); > > + void (*query_tty)(struct ofono_ctm *tt, > > + ofono_ctm_query_cb_t cb, > > + void *data); > > + void (*set_tty)(struct ofono_ctm *tt, > > + int enable, > > I also ch