[RFC] magic numbers (145,129)

2011-01-16 Thread George Matveev
Hi, this is proposal for a patch series which would replace magic numbers 145 and 129 with well defined enumeration. Currently we have the following (eliminating sms and CAIF related code): geo@fermat:/home/work/ofono/ofono$ grep -nr 145 drivers src|grep -v sms|grep -v CAIF

RE: [RFC] magic numbers (145,129)

2011-01-16 Thread Rajesh.Nagaiah
Hi George, Hi, this is proposal for a patch series which would replace magic numbers 145 and 129 with well defined enumeration. Currently we have the following (eliminating sms and CAIF related code): geo@fermat:/home/work/ofono/ofono$ grep -nr 145 drivers src|grep -v sms|grep -v

Re: [RFC PATCH 4/4] Dummy example GPRS context provisioning driver

2011-01-16 Thread Jukka Saunamaki
Hello On Sat, 2011-01-15 at 02:30 +0100, Marcel Holtmann wrote: I would advise the UI against using the name from the context information and better using the one from the network registration instead. Well that would make sense... Therefore the operators don't do it ;-) For