---
src/modem.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/modem.c b/src/modem.c
index 553549e..a92107e 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -805,11 +805,14 @@ static DBusMessage *set_property_lockdown(struct
ofono_modem *modem,
if (m
Hi Lucas,
On 01/25/2011 05:46 PM, Lucas De Marchi wrote:
> Use the enum values defined for CLIP, CNAP, CLIR, COLP and COLR.
> ---
> src/call-settings.c | 16
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
Hi All,
Thanks for reply. Maybe I have a step abnormal not reported. Command
"AT+CGDATA=\"PPP\",%u" is not responded correctly. That is, the first
parameter of at_cgdata_cb is not ture. but I just ignored it, and go
to setup_ppp(gc) forcibly. Can you please give me any advice. Your
reply is app
Use the enum values defined for CLIP, CNAP, CLIR, COLP and COLR.
---
src/call-settings.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/call-settings.c b/src/call-settings.c
index 109f130..8dd2564 100644
--- a/src/call-settings.c
+++ b/src/call-settings
> Yep, Hangup or HangupMultiparty then SwapCalls. If you feel that a
> single operation to accomplish hangup + swap is required we can
> certainly consider it. For now it didn't pass our API is Minimal +
> Complete test. Perhaps ReleaseAndSwap()...?
>
>
> I would go with easy s
Hi Denis
2011/1/25 Denis Kenzior
> Hi Tomasz,
>
> On 01/25/2011 03:43 PM, Tomasz Gregorek wrote:
> > Hi Denis
> >
> > 2011/1/25 Denis Kenzior mailto:denk...@gmail.com>>
> >
> > Hi Tomasz,
> >
> > > Shouldn’t ReleaseAndAnswere() release the active call and bring
> > back the
> > >
Hi Tomasz,
On 01/25/2011 03:43 PM, Tomasz Gregorek wrote:
> Hi Denis
>
> 2011/1/25 Denis Kenzior mailto:denk...@gmail.com>>
>
> Hi Tomasz,
>
> > Shouldn’t ReleaseAndAnswere() release the active call and bring
> back the
> > held one in such situation?
> >
>
> You should
Hi Denis
2011/1/25 Denis Kenzior
> Hi Tomasz,
>
> > Shouldn’t ReleaseAndAnswere() release the active call and bring back the
> > held one in such situation?
> >
>
> You shouldn't be using ReleaseAndAnswer in this case, instead you should
> use SwapCalls. SwapCalls has the added benefit of allow
Hi Jukka,
On 01/25/2011 06:15 AM, Jukka Saunamaki wrote:
> ---
> src/gprs.c | 172
>
> 1 files changed, 162 insertions(+), 10 deletions(-)
>
> diff --git a/src/gprs.c b/src/gprs.c
> index 92d0b1a..3e281e5 100644
> --- a/src/gprs.c
>
Hi Jukka,
> +/* For gprs */
> +void __ofono_gprs_provision_get_settings(const char *mcc, const char *mnc,
> + const char *spn,
> + struct ofono_gprs_provision_data **settings,
> + int *count);
The __ofono prefix implies that this is priv
Hi Tomasz,
> Shouldn’t ReleaseAndAnswere() release the active call and bring back the
> held one in such situation?
>
You shouldn't be using ReleaseAndAnswer in this case, instead you should
use SwapCalls. SwapCalls has the added benefit of allowing swapping of
held and active calls even if ther
Hi Rafael,
On 01/25/2011 08:02 AM, Rafael Ignacio Zurita wrote:
> This set of patches extends OFONO_MAX_PHONE_NUMBER_LENGTH, splits
> common:valid_phone_number_format(), and adapts voicecall to valid
> the 80 character limit for outgoing calls.
>
> Rafael Ignacio Zurita (2):
> types: change OFO
Hi Jussi,
On 01/25/2011 09:34 AM, Jussi Kangas wrote:
>
> Hi, Denis.
>
>> So I'm mostly happy with this approach except that ofono_modem_reset is
>> too big of a hammer to use here. We need something that drops us back
>> to pre-sim state without having to re-power on the device (which is what
Hi all,
* Frédéric Dalleau [2011-01-12 18:15:43 +0100]:
> This is rebased as of head of today
>
> Zhenhua Zhang (21):
> bluetooth: Add reference count for bluetooth utils
> bluetooth: Add Btio library for DUN
> bluetooth: Add bluetooth server support for DUN
> emulator: Add emulator ato
Telepathy-Ring 2.1.2 ("I do love maps! I have quite a collection of
them") is now
available for download from:
http://telepathy.freedesktop.org/releases/telepathy-ring/telepathy-ring-2.1.2.tar.gz
md5sum: 519011d5666930b1636edfc0a717f664 telepathy-ring-2.1.2.tar.gz
sha1sum: 0a46c19c3d6937181dc5e6
Hi, Denis.
> So I'm mostly happy with this approach except that ofono_modem_reset is
> too big of a hammer to use here. We need something that drops us back
> to pre-sim state without having to re-power on the device (which is what
> reset does).
>
> Can you try using sim_inserted / sim_removed
On Tue, Jan 25, 2011 at 12:58 PM, Marcel Holtmann wrote:
> Hi Lucas,
>
>> >> - const char *old, const char *new,
>> >> + const char *p_old, const char *p_new,
>> >> ofono_sim_lock_unlock_cb_t cb, void *data);
>> >> void (*lock)(st
Hi Lucas,
> >> - const char *old, const char *new,
> >> + const char *p_old, const char *p_new,
> >> ofono_sim_lock_unlock_cb_t cb, void *data);
> >> void (*lock)(struct ofono_sim *sim, enum ofono_sim_password_type
> >> type,
> >
Hi Marcel
On Tue, Jan 25, 2011 at 9:54 AM, Marcel Holtmann wrote:
>> - const char *old, const char *new,
>> + const char *p_old, const char *p_new,
>> ofono_sim_lock_unlock_cb_t cb, void *data);
>> void (*lock)(struct ofono_sim *
---
include/types.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/types.h b/include/types.h
index 7963e0f..71d0988 100644
--- a/include/types.h
+++ b/include/types.h
@@ -76,7 +76,7 @@ struct ofono_error {
int error;
};
-#define OFONO_MAX_PHONE_NUMBER_
Also, adapt voicecall to use the new function for outgoing calls.
---
src/common.c| 20 ++--
src/common.h|2 ++
src/voicecall.c |2 +-
3 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/src/common.c b/src/common.c
index 4d93488..8bf9dbb 100644
--- a/
This set of patches extends OFONO_MAX_PHONE_NUMBER_LENGTH, splits
common:valid_phone_number_format(), and adapts voicecall to valid
the 80 character limit for outgoing calls.
Rafael Ignacio Zurita (2):
types: change OFONO_MAX_PHONE_NUMBER_LENGTH value to 80
common: split valid_phone_number_for
Hi Jessica,
> Also, adding some general fileids for building paths
>
> ---
>
> Needed for isimodem2.5 patches planned to follow shortly.
>
>
> Best Regards,
> Jessica
>
>
> src/simutil.h | 12
> 1 files changed, 12 insertions(+), 0 deletions(-)
patch has been applied. Thanks
Hi,
On 01/25/2011 01:39 PM, Aki Niemi wrote:
I don't think there is a need for this, as ISI itself already provides
both ISI version (which we have available always via the
g_isi_client_verify() call), and in many cases also the resource ID as
means to find the correct quirk to use.
Of course,
Also, adding some general fileids for building paths
---
Needed for isimodem2.5 patches planned to follow shortly.
Best Regards,
Jessica
src/simutil.h | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/src/simutil.h b/src/simutil.h
index 95bc18f..463540b 100
Hi Aki,
> > So this clearly then is not suppose to be in isimodem.h and while at it,
> > someone might wanna cleanup isi_modem_by_interface and move it to a
> > better location.
>
> Done. Moved it to /dev/null. ;-)
no kidding. Good one :)
Regards
Marcel
__
Hi Marcel,
2011/1/25 Marcel Holtmann :
> So this clearly then is not suppose to be in isimodem.h and while at it,
> someone might wanna cleanup isi_modem_by_interface and move it to a
> better location.
Done. Moved it to /dev/null. ;-)
Cheers,
Aki
___
Based on patch from: Kristen Carlson Accardi
---
src/ofono.h |1 +
src/sms.c | 83 +++
src/smsutil.c | 151 +
src/smsutil.h |8 +++
4 files changed, 243 insertions(+), 0 deletions(-)
diff --git a
Based on patch from Kristen Carlson Accardi
---
src/sms.c |8
src/smsutil.c | 47 +++
src/smsutil.h |5 +
3 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/src/sms.c b/src/sms.c
index 5718bba..403e387 100644
---
Hi
On Tue, 2011-01-25 at 13:28 +0100, ext Marcel Holtmann wrote:
> I think that our only leftover is how we handle the SPN detail.
>
> Denis, what is your preference here? My take would be that we store it
> inside network registration and provide it to external modules. I don't
> see a point in
This patch series is a re-sending of a previous series sent by Kristen Carlson
Accardi. What I did was some cleanups, style changes, ported it to the new sms
API and fixed some leaks (hopefully I didn't introduce more).
Marcel/Denis, I don't know if letting "Based on patch from" is the right
appro
Based on patch from Kristen Carlson Accardi
---
src/sms.c | 16
src/smsutil.c | 25 +
src/smsutil.h |3 +++
3 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/src/sms.c b/src/sms.c
index 7224bdf..5718bba 100644
--- a/src/sms.c
+++
Hi Aki,
> >> +enum isi_version {
> >> + ISI_20 = 0,
> >> + ISI_25 = 1
> >> +};
> >> +
> >
> > If we follow the same layout as with all other modem drivers, then the
> > *modem.h should only contain the prototypes for the init callbacks.
> >
> >> extern struct ofono_modem *isi_modem_by_int
Hi,
2011/1/25 Marcel Holtmann :
>> +enum isi_version {
>> + ISI_20 = 0,
>> + ISI_25 = 1
>> +};
>> +
>
> If we follow the same layout as with all other modem drivers, then the
> *modem.h should only contain the prototypes for the init callbacks.
>
>> extern struct ofono_modem *isi_modem_by
Hi Jukka,
> Another patchset about automatic provisioning of GPRS context settings.
>
> This time, provisioning driver API is synchronous, and
> __ofono_gprs_provision_get_settings includes MCC,MNC and SPN as in
> parameters.
> Per modem probing and all related complexity was removed, since th
Hi Jessica,
> Adding a version enum to differentiate between isimodem2.0 and isimodem2.5.
>
> Needed for isimodem2.5 patches planned to follow shortly.
>
> Best Regards,
> Jessica
same comments about commit body apply here as well.
> ---
> drivers/isimodem/isimodem.h |5 +
> 1 files c
Hi Jessica,
> Adding EF Fileids for USIM and SIM Phonebook.
> Also, adding some general fileids for building paths.
>
> Needed for isimodem2.5 patches planned to follow shortly.
>
>
> Best Regards,
> Jessica
as an exercise, please save this email and then run "git am" and "git
log" afterwards
---
Makefile.am |3 ++
examples/provision.c | 97 ++
2 files changed, 100 insertions(+), 0 deletions(-)
create mode 100644 examples/provision.c
diff --git a/Makefile.am b/Makefile.am
index 9c4f383..c70dcbf 100644
--- a/Makefile.am
++
---
Makefile.am |2 +-
src/gprs-provision.c | 104 ++
2 files changed, 105 insertions(+), 1 deletions(-)
create mode 100644 src/gprs-provision.c
diff --git a/Makefile.am b/Makefile.am
index f543135..9c4f383 100644
--- a/Makefile.am
++
---
src/gprs.c | 172
1 files changed, 162 insertions(+), 10 deletions(-)
diff --git a/src/gprs.c b/src/gprs.c
index 92d0b1a..3e281e5 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -44,6 +44,11 @@
#include "storage.h"
#include "idmap.h"
---
Makefile.am |3 +-
include/gprs-provision.h | 69 ++
2 files changed, 71 insertions(+), 1 deletions(-)
create mode 100644 include/gprs-provision.h
diff --git a/Makefile.am b/Makefile.am
index f941a19..f543135 100644
--- a/Makefil
Hello
Another patchset about automatic provisioning of GPRS context settings.
This time, provisioning driver API is synchronous, and
__ofono_gprs_provision_get_settings includes MCC,MNC and SPN as in parameters.
Per modem probing and all related complexity was removed, since there was
really n
Adding a version enum to differentiate between isimodem2.0 and isimodem2.5.
Needed for isimodem2.5 patches planned to follow shortly.
Best Regards,
Jessica
---
drivers/isimodem/isimodem.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/isimodem/isimodem.h b
Adding EF Fileids for USIM and SIM Phonebook.
Also, adding some general fileids for building paths.
Needed for isimodem2.5 patches planned to follow shortly.
Best Regards,
Jessica
---
src/simutil.h | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/src/simut
Hi
I have a question about behavior of ReleaseAndAnswere().
If I am right, this function implements +CHLD=1 at command. Spec 22.030 says
Entering 1 followed by SEND - Releases all active calls (if
any exist)
and accepts the other (held or waiting)
Hi Marcel,
so I remember that the agreement was to just quirk the isimodem support
to also support the new code. Is that still the case or what is the
exact plan here?
Yes, that is basically the plan.
We just wanted you to get a heads-up on what we are planning and what
patches are to come.
Hi Lucas,
> include/sim.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/sim.h b/include/sim.h
> index 81df60e..6e93769 100644
> --- a/include/sim.h
> +++ b/include/sim.h
> @@ -154,7 +154,7 @@ struct ofono_sim_driver {
> ofono_sim_loc
Hi Jessica,
> as you probably remember I sent in some patches containing isimodem2.5
> some time ago.
> After your comments we are now getting ready to send in some updates
> where we have merged the isimodem with our isimodem2.5 code.
>
> This is a preliminary plan on how we propose to sent in
---
include/sim.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/sim.h b/include/sim.h
index 81df60e..6e93769 100644
--- a/include/sim.h
+++ b/include/sim.h
@@ -154,7 +154,7 @@ struct ofono_sim_driver {
ofono_sim_lock_unlock_cb_t cb, void
Hi,
as you probably remember I sent in some patches containing isimodem2.5
some time ago.
After your comments we are now getting ready to send in some updates
where we have merged the isimodem with our isimodem2.5 code.
This is a preliminary plan on how we propose to sent in the patches.
Some
50 matches
Mail list logo
