RE: [PATCH 03/12] gprs: core support for IPv6

Hi Denis, +struct pri_context; + struct ofono_gprs_context { struct ofono_gprs *gprs; + struct pri_context *pri; enum ofono_gprs_context_type type; - ofono_bool_t inuse; I don't see how getting rid of this is not a good idea. As soon as the context driver is

[RFC] voicecall API changes (proposal v3)

--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 11 +++ doc/voicecallmanager-api.txt | 26 ++ 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index

[PATCH] voicecall: fix transfer

From: Andre Carvalho de Matos andre.carvalho.ma...@stericsson.com transfer method should fail if you have a multiparty call, according to 22.091 section 8.11 --- src/voicecall.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index

[PATCH 1/7] gprs: remove RoamingAllowed property

No roaming policies need to be enforced per GPRS context rather than for the whole GPRS service. Otherwise, you would not be able to receive an MMS or even register to the IMS SIP while roaming. --- src/gprs.c | 51 +++ 1 files changed, 3

[PATCH 3/7] gprs: let the modems automatically attach when activating a context

If some really stupid modem does not support attach on demand, this really should be worked around in the specific driver (at least AT and ISI modems support this). --- src/dbus.c | 13 - src/gprs.c |6 -- src/ofono.h |2 -- 3 files changed, 0 insertions(+), 21

[PATCH 5/7] include: replace set_attached with set_attach_policy

--- include/gprs.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/gprs.h b/include/gprs.h index 157a6f9..15c1080 100644 --- a/include/gprs.h +++ b/include/gprs.h @@ -41,7 +41,8 @@ struct ofono_gprs_driver { int (*probe)(struct ofono_gprs *gprs, unsigned

[PATCH 2/7] doc: remove RoamingAllowed

--- doc/connman-api.txt |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt index 22c59dc..4c24701 100644 --- a/doc/connman-api.txt +++ b/doc/connman-api.txt @@ -106,14 +106,6 @@ Properties boolean Attached [readonly]

[PATCH 7/7] isi: implement set_attach_policy

--- drivers/isimodem/gprs.c | 131 -- 1 files changed, 23 insertions(+), 108 deletions(-) diff --git a/drivers/isimodem/gprs.c b/drivers/isimodem/gprs.c index ea90704..ad5a768 100644 --- a/drivers/isimodem/gprs.c +++ b/drivers/isimodem/gprs.c @@ -62,6

[PATCH 0/7] Move GPRS attach logic to the modem

Hello, This series moves responsibility for GPRS attach to the modem. In most cases, the modem will attach on-demand when a first context is activated. This simplifies the oFono interface and implementation. Some operators require the device be always attached. This is managed by a new

[PATCH 0/2] Add handling of XCOLP and refactor call status handling

Hi, Incase of ifxmodem, COLP is not an intermediate status for ATD. Vendor specific AT command XCOLP is used for the connected line presentation. Since XCALLSTAT reports the voice call status information, there is no need to listen for CRING notification. Following patch refactors the handling

[PATCH 1/2] ifxmodem: add handling of XCOLP notification

--- drivers/ifxmodem/voicecall.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index f66815a..d31fa70 100644 --- a/drivers/ifxmodem/voicecall.c +++

Re: [RFC] voicecall API changes (proposal v3)

Hi Andras, + CallForwarded(string type) + + Signal emitted when an outgoing voice call is made and + the call has been redirected to another number due to + the remote party's Call Forwarding Supplementary +

Re: [RFC] voicecall API changes (proposal v3)

Hi Denis, On 02/07/2011 06:38 PM, ext Denis Kenzior wrote: Hi Andras, + CallForwarded(string type) + + Signal emitted when an outgoing voice call is made and + the call has been redirected to another number due to +

[RFC] voicecall API changes (proposal v3)

--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 11 +++ doc/voicecallmanager-api.txt | 25 + 3 files changed, 36 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index

Re: [PATCH 2/4] sim: Implement file watching and basic refresh.

Hi Andrew, +void __ofono_sim_refresh(struct ofono_sim *sim, GSList *file_list, + ofono_bool_t full_file_change, ofono_bool_t naa_init) +{ + GSList *l, *fl; + enum sim_reset { + RESET_REMOVE_ATOMS = OFONO_SIM_STATE_INSERTED, +

Re: [RFC] voicecall API changes (proposal v3)

Hi Andras, On 02/07/2011 11:09 AM, Andras Domokos wrote: --- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 11 +++ doc/voicecallmanager-api.txt | 25 + 3 files changed, 36 insertions(+), 10 deletions(-) Your patch still

Re: [PATCH] voicecall: fix transfer

Hi Andre, @@ -1350,11 +1351,12 @@ static DBusMessage *manager_transfer(DBusConnection *conn, * implementing the call transfer operation for a call that is * still dialing/alerting. */ - numactive += voicecalls_num_connecting(vc); + numconn =

Re: [PATCH 1/4] Add SIM filesystem watch api.

Hi Andrew, On 02/03/2011 07:20 PM, Andrzej Zaborowski wrote: This allows code that reads files from the SIM card to also watch for changes in these files signalled in a Refresh command by the SIM. --- include/sim.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) So I

Re: [PATCH] sim: enable usage of SIM pass codes longer than 8 digits

Hi Jussi, On 02/07/2011 08:49 AM, Jussi Kangas wrote: --- Hi, Here is my second proposal for how to enable usage of SIM lock codes longer than eight digits. I removed the namespace problem and fixed a problem with puk reset. Br, Jussi include/sim.h |1 +