Re: [PATCH] stk: Add null pointer check

Hi, On Fri, 2011-02-25 at 19:58 +0200, Denis Kenzior wrote: > Hi Andrew / Lasse, > > > diff --git a/src/stk.c b/src/stk.c > > index bc46b2f..c4e988b 100644 > > --- a/src/stk.c > > +++ b/src/stk.c > > @@ -2514,6 +2514,7 @@ static void stk_proactive_command_cancel(struct > > ofono_stk *stk) > >

[PATCH] stk: Make sure to reset respond_on_exit.

This fixes a crash spotted by Lasse Kunnasluoto documented at http://lists.ofono.org/pipermail/ofono/2011-February/009211.html --- src/stk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index bc46b2f..c4e988b 100644 --- a/src/stk.c +++ b/src/stk.c

[PATCH 1/3] mbmmodem: close chat before sending fd

--- drivers/mbmmodem/location-reporting.c | 44 ++--- 1 files changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c index 941fac4..b671d71 100644 --- a/drivers/mbmmodem/location-reportin

[PATCH 2/3] location-reporting: don't add client-exit watch too early

Wait until driver gives us a file descriptor to start watching for client exit. This fixes a race when client exits before the driver calls location_reporting_enable_cb(). --- src/location-reporting.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/location-re

[PATCH 3/3] mbmmodem: ensure we close fd when ofono exits

--- drivers/mbmmodem/location-reporting.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c index b671d71..24ff4b8 100644 --- a/drivers/mbmmodem/location-reporting.c +++ b/drivers/mbmmodem/lo

[PATCH 0/3] Voice call SS notifications (2nd version)

Implementation proposal for handling some of the voice call related Supplementary Services (SS) notifications. Implementation details: - removed SSN atom - expanded the SS notify functions with call number info, useful for modems capable of delivering it in the SS notifications - expanded the SS

[RFC PATCH 1/3] ssn: remove SSN atom

--- drivers/atmodem/ssn.c |6 +--- include/ssn.h |9 +++ plugins/calypso.c |1 - plugins/g1.c |1 - plugins/huawei.c |1 - plugins/ifx.c |1 - plugins/isiusb.c |1 - plugins/linktop.c |1 - plugins/n900.c|1

[RFC PATCH 2/3] ssn: add code and call id to notifications

--- drivers/atmodem/ssn.c |4 ++-- include/ssn.h |7 --- src/ofono.h |5 +++-- src/ssn.c | 11 ++- 4 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/atmodem/ssn.c b/drivers/atmodem/ssn.c index c927bf1..ba8f89a 100644 --

[RFC PATCH 3/3] voicecall: add SSN notifications handling

--- include/types.h |2 + src/voicecall.c | 240 ++- 2 files changed, 239 insertions(+), 3 deletions(-) diff --git a/include/types.h b/include/types.h index d25f409..b639c8a 100644 --- a/include/types.h +++ b/include/types.h @@ -96,6 +96,8

Re: [PATCH] stk: Make sure to reset respond_on_exit.

Hi Andrew, On 02/27/2011 06:58 PM, Andrzej Zaborowski wrote: > This fixes a crash spotted by Lasse Kunnasluoto documented at > http://lists.ofono.org/pipermail/ofono/2011-February/009211.html > --- > src/stk.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

Hi Andras, On 02/28/2011 10:28 AM, Andras Domokos wrote: > --- > drivers/atmodem/ssn.c |4 ++-- > include/ssn.h |7 --- > src/ofono.h |5 +++-- > src/ssn.c | 11 ++- > 4 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/driv