[PATCH 1/6] callmanager: Add signal on call status change

2011-04-28 Thread Nicolas Bertrand
--- src/callmanager.cpp | 34 ++ src/callmanager.h |3 +++ 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/src/callmanager.cpp b/src/callmanager.cpp index 585a3ac..9823f05 100644 --- a/src/callmanager.cpp +++ b/src/callmanager.cpp @@ -149,6

[PATCH 0/6] phonesim: Add call status UI

2011-04-28 Thread Nicolas Bertrand
This patch introduce a new tab call in phonesim UI in order to display calls informations (id, number, status, name and direction). The interface to send CSSU and CSSI notification is now dynamic based on the type of current calls. Nicolas Bertrand (6): callmanager: Add signal on call status

[PATCH 3/6] hardwaremanipulator: add callmanagement method

2011-04-28 Thread Nicolas Bertrand
--- src/hardwaremanipulator.cpp |4 src/hardwaremanipulator.h |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/hardwaremanipulator.cpp b/src/hardwaremanipulator.cpp index c7bbe6a..909ce2a 100644 --- a/src/hardwaremanipulator.cpp +++

[PATCH 2/6] control: Update UI using call status

2011-04-28 Thread Nicolas Bertrand
--- src/control.cpp | 40 +++- src/control.h |5 + 2 files changed, 40 insertions(+), 5 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 645219c..2f12d91 100644 --- a/src/control.cpp +++ b/src/control.cpp @@ -134,6 +134,32 @@

[PATCH 4/6] phonesim: Connect call status signal

2011-04-28 Thread Nicolas Bertrand
--- src/phonesim.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/phonesim.cpp b/src/phonesim.cpp index a822cd9..cda32dd 100644 --- a/src/phonesim.cpp +++ b/src/phonesim.cpp @@ -528,6 +528,8 @@ SimRules::SimRules( int fd, QObject *p, const QString filename,

[PATCH 5/6] controlbase.ui: Add call mangement tab

2011-04-28 Thread Nicolas Bertrand
--- src/controlbase.ui | 61 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/src/controlbase.ui b/src/controlbase.ui index cfadfe8..41c6d12 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -1458,6 +1458,67 @@ p, li

[PATCH 6/6] control: Update call view

2011-04-28 Thread Nicolas Bertrand
--- src/control.cpp | 100 +-- src/control.h |3 +- 2 files changed, 91 insertions(+), 12 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 2f12d91..dec3aea 100644 --- a/src/control.cpp +++ b/src/control.cpp @@ -136,14

[PATCH] Modify send sms test to be able to set the modem to use

2011-04-28 Thread Bertrand Aygon
--- test/send-sms | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/test/send-sms b/test/send-sms index bd1fae5..968824b 100755 --- a/test/send-sms +++ b/test/send-sms @@ -3,22 +3,32 @@ import sys import dbus +if len(sys.argv) 4: +

[PATCH] Modify send vcard test to be able to set the modem to use

2011-04-28 Thread Bertrand Aygon
--- test/send-vcard | 26 +++--- 1 files changed, 19 insertions(+), 7 deletions(-) diff --git a/test/send-vcard b/test/send-vcard index d11d5ac..3955990 100755 --- a/test/send-vcard +++ b/test/send-vcard @@ -3,18 +3,30 @@ import sys import dbus +if len(sys.argv) 3: +

[PATCH] Add send vcal test

2011-04-28 Thread Bertrand Aygon
--- test/send-vcal | 32 1 files changed, 32 insertions(+), 0 deletions(-) create mode 100755 test/send-vcal diff --git a/test/send-vcal b/test/send-vcal new file mode 100755 index 000..7ccd2f6 --- /dev/null +++ b/test/send-vcal @@ -0,0 +1,32 @@

Re: [PATCH_v2 1/4] gatppp: Add new contructor to use external fd

2011-04-28 Thread Guillaume Zajac
Hi Denis, On 27/04/2011 05:20, Denis Kenzior wrote: Hi Guillaume, On 04/22/2011 07:06 AM, Guillaume Zajac wrote: --- gatchat/gatppp.c | 43 --- gatchat/gatppp.h |2 ++ gatchat/ppp.h |2 +- gatchat/ppp_net.c | 46

Re: [PATCH_v2 2/4] emulator: add routine to request/release private network from ConnMan

2011-04-28 Thread Guillaume Zajac
Hi Denis, On 27/04/2011 05:25, Denis Kenzior wrote: Hi Guillaume, On 04/22/2011 07:06 AM, Guillaume Zajac wrote: --- include/emulator.h | 10 +++ src/emulator.c | 75 +++- 2 files changed, 78 insertions(+), 7 deletions(-) diff

Re: [PATCH] Modify send sms test to be able to set the modem to use

2011-04-28 Thread Denis Kenzior
Hi Bertrand, On 04/28/2011 04:54 AM, Bertrand Aygon wrote: --- test/send-sms | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH] Modify send vcard test to be able to set the modem to use

2011-04-28 Thread Denis Kenzior
Hi Bertrand, On 04/28/2011 07:02 AM, Bertrand Aygon wrote: --- test/send-vcard | 26 +++--- 1 files changed, 19 insertions(+), 7 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH] Add send vcal test

2011-04-28 Thread Denis Kenzior
Hi Bertrand, On 04/28/2011 07:05 AM, Bertrand Aygon wrote: --- test/send-vcal | 32 1 files changed, 32 insertions(+), 0 deletions(-) create mode 100755 test/send-vcal Patch has been applied, however you forgot to add this to the build. I fixed this in

RE: [PATCH] Add send vcal test

2011-04-28 Thread Aygon, Bertrand
Patch has been applied, however you forgot to add this to the build. I fixed this in a follow-on patch for you ;) Damn, sorry, second times... Thanks for the fix. Bertrand - Intel Corporation SAS (French simplified joint

Re: [PATCH] isimodem: use a specific call id when answering

2011-04-28 Thread Denis Kenzior
Hi Pekka, On 04/27/2011 07:45 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c

Re: [PATCH_v2 1/4] gatppp: Add new contructor to use external fd

2011-04-28 Thread Denis Kenzior
Hi Guillaume, -if (ppp_net_set_mtu(ppp-net, ppp-mtu) == FALSE) -DBG(ppp, Unable to set MTU); +/* + * If we have opened the tun interface locally, + * we have to set a MTU value. + */ So I don't agree with this. The MTU is negotiated during LCP phase, so unless

Re: [PATCH_v2 1/4] gatppp: Add new contructor to use external fd

2011-04-28 Thread Guillaume Zajac
Hi Denis, On 28/04/2011 16:44, Denis Kenzior wrote: Hi Guillaume, -if (ppp_net_set_mtu(ppp-net, ppp-mtu) == FALSE) -DBG(ppp, Unable to set MTU); +/* + * If we have opened the tun interface locally, + * we have to set a MTU value. + */ So I don't agree with this.

Re: Qualcomm Gobi 2000 Modem Issues

2011-04-28 Thread Kai Scharwies
2011/4/8 Marcel Holtmann mar...@holtmann.org: Hi Kai, I ran into two issues trying to setup a data connection with a Gobi 2000 card. The first one seems to be an error regarding simcard onlocking. After enabling the modem test/list-modems shows the following, despite the simcard is

Re: Qualcomm Gobi 2000 Modem Issues

2011-04-28 Thread Marcel Holtmann
Hi Kai, I ran into two issues trying to setup a data connection with a Gobi 2000 card. The first one seems to be an error regarding simcard onlocking. After enabling the modem test/list-modems shows the following, despite the simcard is inserted correctly: [ /gobi0 ]

Re: [PATCH_v2 2/4] emulator: add routine to request/release private network from ConnMan

2011-04-28 Thread Denis Kenzior
Hi Guillaume, On 04/28/2011 08:29 AM, Guillaume Zajac wrote: Hi Denis, On 27/04/2011 05:25, Denis Kenzior wrote: Hi Guillaume, On 04/22/2011 07:06 AM, Guillaume Zajac wrote: --- include/emulator.h | 10 +++ src/emulator.c | 75

Re: [PATCH_v2 1/4] gatppp: Add new contructor to use external fd

2011-04-28 Thread Denis Kenzior
Hi Guillaume, +/* create a channel for reading and writing to this interface */ +channel = g_io_channel_unix_new(fd); +} There's a small problem of symmetry here. If IPCP is established correctly, then the fd will eventually be closed by ppp_net. However, if we never

Re: [PATCH 1/6] callmanager: Add signal on call status change

2011-04-28 Thread Denis Kenzior
Hi Nicolas, On 04/28/2011 04:49 AM, Nicolas Bertrand wrote: --- src/callmanager.cpp | 34 ++ src/callmanager.h |3 +++ 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/src/callmanager.cpp b/src/callmanager.cpp index 585a3ac..9823f05

Re: [PATCH 2/6] control: Update UI using call status

2011-04-28 Thread Denis Kenzior
Hi Nicolas, On 04/28/2011 04:49 AM, Nicolas Bertrand wrote: --- src/control.cpp | 40 +++- src/control.h |5 + 2 files changed, 40 insertions(+), 5 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 645219c..2f12d91 100644

Re: [PATCH] gisi: log normal responses in a less confusing way

2011-04-28 Thread Denis Kenzior
Hi Pekka, On 04/27/2011 07:45 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- gisi/modem.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono