Re: [Gta04-owner] HSO modem, apparent confusion between App and Control ports

Hi Neil, > I'm using an HSO modem in a GTA04 device, and have a UI that, on session > startup, powers the modem on, and sets it online. > > Sometimes - after roughly 50% of reboots - the setting online times out, > and I've established that this is because there's still a preceding > command in c

Re: [PATCH] hso: Don't access freed data, in hso_set_online

Hi Neil, > --- > plugins/hso.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

HSO modem, apparent confusion between App and Control ports

I'm using an HSO modem in a GTA04 device, and have a UI that, on session startup, powers the modem on, and sets it online. Sometimes - after roughly 50% of reboots - the setting online times out, and I've established that this is because there's still a preceding command in chat->command_queue, wh

[PATCH] hso: Don't access freed data, in hso_set_online

--- plugins/hso.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/hso.c b/plugins/hso.c index 497c64e..249bb2c 100644 --- a/plugins/hso.c +++ b/plugins/hso.c @@ -421,9 +421,9 @@ static void hso_set_online(struct ofono_modem *modem, ofono_bool_t online,

Re: [PATCH] hso: Don't access freed data, in hso_set_online

Marcel Holtmann writes: > Hi Neil, > >> plugins/hso.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/plugins/hso.c b/plugins/hso.c >> index 4834c56..697beaa 100644 >> --- a/plugins/hso.c >> +++ b/plugins/hso.c >> @@ -422,7 +422,7 @@ static void hso_set_online(

Re: trying to understand context creation

Hi Jussi, > >> From a UI point of view, connman crashing and connman being stopped > >> are 100% same -- the only thing the UI can do is inform the user that > >> there is a critical problem, so they won't just wait there expecting > >> that Wifi AP to show up any moment now... I hope the users w

Re: [PATCH] configure/make basics

Hi Jens, > while hacking on a plugin for mmsd to deal with supl push > messages, I ran into a few "not so nice" solved things > in configure.ac / Makefile.am > > 1) libtool handling >libtool configuration is meanwhile done using LT_INIT(options) >instead of AC_PROC_LIBTOOL and alike >

Re: [PATCH] add some length verification to avoid reading not owned memory

Hi Jens, > while reading mmsd sources I stumbled over missing length > checks in src/push.c:mms_push_notify(). I didn't re-read > the entire source to prove overall ;) please use git format-patch and git send-email to send us inline patches. In case your email client doesn't support inline patche

[PATCH] configure/make basics

Hi, while hacking on a plugin for mmsd to deal with supl push messages, I ran into a few "not so nice" solved things in configure.ac / Makefile.am 1) libtool handling libtool configuration is meanwhile done using LT_INIT(options) instead of AC_PROC_LIBTOOL and alike ==> because of libtoo

Re: trying to understand context creation

On Mon, Feb 27, 2012 at 12:54 PM, Marcel Holtmann wrote: >> From a UI point of view, connman crashing and connman being stopped >> are 100% same -- the only thing the UI can do is inform the user that >> there is a critical  problem, so they won't just wait there expecting >> that Wifi AP to show

Re: trying to understand context creation

Hi Jussi, > >> HW problems any more than I'm "fixing" connman crashes in my UI -- > >> both are still events I'd rather handle (witihin limits) if that makes > >> the UX better. > > > > Sure, the UI should handle the basics, e.g. connman service being > > stopped by the administrator. However, go

Re: trying to understand context creation

On Fri, Feb 24, 2012 at 9:20 AM, Denis Kenzior wrote: >> HW problems any more than I'm "fixing" connman crashes in my UI -- >> both are still events I'd rather handle (witihin limits) if that makes >> the UX better. > > Sure, the UI should handle the basics, e.g. connman service being > stopped by

[PATCH] add some length verification to avoid reading not owned memory

Hi, while reading mmsd sources I stumbled over missing length checks in src/push.c:mms_push_notify(). I didn't re-read the entire source to prove overall ;) Best regards, Jens >From 7fe33082555f43d6eb52d2bebb0a9c36f0bc4adc Mon Sep 17 00:00:00 2001 From: Jens Rehsack Date: Mon, 27 Feb 2012 10:15: