Re: [PATCH v0 2/2] hfp_hf_bluez5: Only register modems for Paired devices

2013-01-31 Thread Claudio Takahasi
Hi Denis: On Thu, Jan 31, 2013 at 12:44 AM, Denis Kenzior wrote: > Hi Vinicius, > > > On 01/30/2013 10:24 AM, Claudio Takahasi wrote: >> >> From: Vinicius Costa Gomes >> >> When there are many devices around that support the HFP AG profile, >> we may have a lot of modems that the user will never

Re: [PATCH] Simcom support

2013-01-31 Thread Renat Zaripov
Hi Anthony, 2013/1/29 Viallard Anthony > On 28. 01. 13 14:43, Renat Zaripov wrote: > >> Hi! >> > > Hi Renat, > > >> I'll get started to test patch that sended by Anthony in previous email. >> Patch have some errors, but I'm fix it. >> >> renat@zaripov:~/work/ofono$ patch -p 1 < ../simcom.patch >

[PATCH] hfp_hf_bluez5: Remove error handling for g_io_channel_unix_new()

2013-01-31 Thread Vinicius Costa Gomes
Apart from g_io_channel_unix_new() not setting errno, it never returns an NULL pointer on error, because in practice it only calls g_new(). --- plugins/hfp_hf_bluez5.c | 5 - 1 file changed, 5 deletions(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 8cac945..ff4dbad 1

[PATCH v0 1/2] hfp_hf_bluez5: Fix registering modem on NewConnection

2013-01-31 Thread Claudio Takahasi
HFP modem will be registered when Proxy Added callback gets called or when Pair is True. This patch removes the support for dynamic modem registration when a new connection is notified and there isn't a modem associated with the Bluetooth remote device. BlueZ behaviour has been changed and a NewCo

[PATCH v0 2/2] hfp_hf_bluez5: Remove BlueZ devices proxies hash

2013-01-31 Thread Claudio Takahasi
The hash table to track the devices is not necessary anymore since dynamic modem registration on NewConnection was removed. --- plugins/hfp_hf_bluez5.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index d2f3a

Re: [PATCH] hfp_hf_bluez5: Remove error handling for g_io_channel_unix_new()

2013-01-31 Thread Denis Kenzior
Hi Vinicius, On 01/31/2013 12:30 PM, Vinicius Costa Gomes wrote: Apart from g_io_channel_unix_new() not setting errno, it never returns an NULL pointer on error, because in practice it only calls g_new(). --- plugins/hfp_hf_bluez5.c | 5 - 1 file changed, 5 deletions(-) Patch has been

Re: [PATCH 1/2] bluetooth: Rename HFP AG plugin

2013-01-31 Thread Denis Kenzior
Hi Frédéric, On 01/29/2013 04:42 AM, Frédéric Danis wrote: As BlueZ 5 introduced backwards incompatible API changes, and we want to keep support for BlueZ 4 based HFP AG plugin for some time, we need to separate HFP AG plugin which is based on BlueZ 4 from the one based on BlueZ 5. The hfp_ag.c

Re: [PATCH v0 1/2] hfp_hf_bluez5: Fix registering modem on NewConnection

2013-01-31 Thread Denis Kenzior
Hi Claudio, On 01/31/2013 01:01 PM, Claudio Takahasi wrote: HFP modem will be registered when Proxy Added callback gets called or when Pair is True. This patch removes the support for dynamic modem registration when a new connection is notified and there isn't a modem associated with the Bluetoo

Re: [PATCH v0 2/2] hfp_hf_bluez5: Remove BlueZ devices proxies hash

2013-01-31 Thread Denis Kenzior
Hi Claudio, On 01/31/2013 01:01 PM, Claudio Takahasi wrote: The hash table to track the devices is not necessary anymore since dynamic modem registration on NewConnection was removed. --- plugins/hfp_hf_bluez5.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) Patch h

Re: [PATCH 2/2] hfp_ag: Add BlueZ 5 version

2013-01-31 Thread Denis Kenzior
Hi Frédéric, On 01/29/2013 04:42 AM, Frédéric Danis wrote: This patch adds initial implementation of the D-Bus Profile1 interface and methods responsible for handling Bluetooth connections. The HFP AG profile interface is registered as soon as a voice capable modem is registered in oFono. ---