Re: [PATCH 3/4] plugins: add a new driver for Quectel UC15 modules

Hi Philip, > > I don't think there's any reason this needs to be there specifically. I > probably put it there when I was debugging a USB-related reset problem. > It can probably either go away (I've not done more than cursory testing > with the modem connected to a UART - many things may be brok

Re: [PATCH 3/4] plugins: add a new driver for Quectel UC15 modules

On 2014-06-24 12:41:45 (-0500), Denis Kenzior wrote: > Philip Paeps wrote: Thanks for the review, Denis! > > +static void verify_enable(gboolean ok, GAtResult *result, gpointer > > user_data) > > +{ > > + struct ofono_modem *modem = user_data; > > + struct quectel_data *data = ofono_modem_

Re: [PATCH 0/3] Provision the PPP authentication method from mbpi

Hi Philip, On 06/24/2014 04:57 AM, Philip Paeps wrote: > My patch to the mobile-broadband-provider-info database DTD to add an > attribute indicating the authentication method to use was accepted by > the maintainers[1] and merged in their tree[2]. > > This set of patches adds support for the new

Re: [PATCH 3/4] plugins: add a new driver for Quectel UC15 modules

Hi Philip, > + > +static void verify_enable(gboolean ok, GAtResult *result, gpointer user_data) > +{ > + struct ofono_modem *modem = user_data; > + struct quectel_data *data = ofono_modem_get_data(modem); > + > + if (ok) { > + ofono_modem_set_powered(modem, TRUE); > +

[PATCH 6/6] atmodem: set the auth method for u-blox modems

--- drivers/atmodem/gprs-context.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c index be3..ebb4960 100644 --- a/drivers/atmodem/gprs-context.c +++ b/drivers/atmodem/gprs-cont

[PATCH 5/6] gprs: add support for u-blox +UREG URCs

--- drivers/atmodem/gprs.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index 3005867..5551316 100644 --- a/drivers/atmodem/gprs.c +++ b/drivers/atmodem/gprs.c @@ -282,6 +282,44 @@ static void te

[PATCH 3/6] plugins: new driver for u-blox SARA-U270 modems

This driver may also work (perhaps with more or less trivial changes) with other u-blox modems (SARA, LISA, LEON) but this hasn't been tested. --- Makefile.am |3 + plugins/ublox.c | 289 +++ 2 files changed, 292 insertions(+) diff --gi

[PATCH 1/6] atmodem: add vendor u-blox

--- drivers/atmodem/vendor.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/atmodem/vendor.h b/drivers/atmodem/vendor.h index bf2b38a..de3c455 100644 --- a/drivers/atmodem/vendor.h +++ b/drivers/atmodem/vendor.h @@ -42,5 +42,6 @@ enum ofono_vendor { OFONO_

[PATCH 2/6] udevng: add detection logic for u-blox modems

--- plugins/udevng.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/plugins/udevng.c b/plugins/udevng.c index d41c6a8..42ee989 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -791,6 +791,46 @@ static gboolean setup_samsung(struct modem_inf

[PATCH 4/6] sim: query u-blox PIN retries with AT+UPINCNT

--- drivers/atmodem/sim.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index f8e0472..9b8d176 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -67,6 +67,7 @@ static const char *ep

[PATCH 0/6] Add a driver for u-blox modems

This set of patches adds basic support for u-blox modems. It has only been tested with a u-blox SARA U270 modem but judging from the datasheet it should be fairly trivial to adapt to other variants of the SARA, LISA and LEON chips. Philip Paeps (6): atmodem: add vendor u-blox udevng: add det

Re: [PATCH 3/4] plugins: add a new driver for Quectel UC15 modules

On 2014-06-24 12:08:41 (+0200), Philip Paeps wrote: > + * Copyright (C) 2008-2011 Intel Corporation. All rights reserved. So focused on trying to make sure I didn't violate any local coding style rules, I forgot I copy/pasted the copyright header! This should read "2014 Philip Paeps". Would

[PATCH 1/4] atmodem: add vendor Quectel

--- drivers/atmodem/vendor.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/atmodem/vendor.h b/drivers/atmodem/vendor.h index bf2b38a..05ec872 100644 --- a/drivers/atmodem/vendor.h +++ b/drivers/atmodem/vendor.h @@ -42,5 +42,6 @@ enum ofono_vendor { OFONO_

[PATCH 4/4] sim: query Quectel UC15 PIN retries with AT+QPINQ

--- drivers/atmodem/sim.c | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index f8e0472..4a91798 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -67,6 +67,7 @@ static const char

[PATCH 3/4] plugins: add a new driver for Quectel UC15 modules

--- Makefile.am |3 + plugins/quectel.c | 335 + 2 files changed, 338 insertions(+) diff --git a/Makefile.am b/Makefile.am index cd83ef4..aee28de 100644 --- a/Makefile.am +++ b/Makefile.am @@ -420,6 +420,9 @@ builtin_sources += plugin

[PATCH 2/4] udevng: add setup logic for Quectel UC15 modules

--- plugins/udevng.c | 37 + 1 file changed, 37 insertions(+) diff --git a/plugins/udevng.c b/plugins/udevng.c index d41c6a8..de37a40 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -791,6 +791,41 @@ static gboolean setup_samsung(struct modem_info *mo

[PATCH 0/4] Add a driver for Quectel UC15 modules

Not very exciting as drivers go. :) Philip Paeps (4): atmodem: add vendor Quectel udevng: add setup logic for Quectel UC15 modules plugins: add a new driver for Quectel UC15 modules sim: query Quectel UC15 PIN retries with AT+QPINQ Makefile.am |3 + drivers/atmodem/sim.c

[PATCH 0/3] Provision the PPP authentication method from mbpi

My patch to the mobile-broadband-provider-info database DTD to add an attribute indicating the authentication method to use was accepted by the maintainers[1] and merged in their tree[2]. This set of patches adds support for the new attribute in the mbpi plugin so new GPRS contexts can be correctl

[PATCH 3/3] gprs: provision the authentication method

--- src/gprs.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gprs.c b/src/gprs.c index 1efcc0c..05ab499 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -3030,6 +3030,8 @@ static void provision_context(const struct ofono_gprs_provision_data *ap, if (ap->password != NULL)

[PATCH 2/3] mbpi: add support for provisioning the auth method

Use the authentication method from the mobile-broadband-provider-info database if it is specified and supported (we support CHAP and PAP). Default to CHAP if the database does not specify a method (i.e.: the previous behaviour). --- plugins/mbpi.c | 35 +++ 1 file

[PATCH 1/3] include: add auth method to the provisioning API

--- include/gprs-provision.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/gprs-provision.h b/include/gprs-provision.h index e9eec61..2dd792b 100644 --- a/include/gprs-provision.h +++ b/include/gprs-provision.h @@ -35,6 +35,7 @@ struct ofono_gprs_provision_data { char *apn