Re: [PATCHv2] sim: added ImsPrivateIdentity to SimManager

2017-11-06 Thread Denis Kenzior
Hi James, On 11/06/2017 04:37 PM, James Prestwood wrote: If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44

[PATCHv2] sim: added ImsPrivateIdentity to SimManager

2017-11-06 Thread James Prestwood
If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44 2 files changed, 46 insertions(+) diff --git a/src/ofono.h

[PATCH] sim: added ImsPrivateIdentity to SimManager

2017-11-06 Thread James Prestwood
If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44 2 files changed, 46 insertions(+) diff --git a/src/ofono.h

Re: [PATCH 4/5] sim: added ImsPrivateIdentity to SimManager

2017-11-06 Thread Denis Kenzior
Hi James, On 11/06/2017 11:49 AM, James Prestwood wrote: If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44

Re: [PATCH 3/5] sim: implement create ISIM context

2017-11-06 Thread Denis Kenzior
Hi James, On 11/06/2017 11:49 AM, James Prestwood wrote: API to create a sim context for the ISIM application, if found. During AID discovery, if an ISIM AID is found, a new fs object is initialized for the ISIM which will be used for any future ISIM context creation. --- src/sim.c | 41 ++

Re: [PATCHv4] simfs: read files from specific AID's

2017-11-06 Thread Denis Kenzior
Hi James, On 11/06/2017 03:07 PM, James Prestwood wrote: The simfs atom could not read EF's that did not exist on the 'default' ADF directory. This implements a new way to read EF's that exist on a given AID. A new fs object/context can be initialized for a given AID. Using this fs context with

[PATCHv4] simfs: read files from specific AID's

2017-11-06 Thread James Prestwood
The simfs atom could not read EF's that did not exist on the 'default' ADF directory. This implements a new way to read EF's that exist on a given AID. A new fs object/context can be initialized for a given AID. Using this fs context with the existing read file API will read from that AID rather th

[PATCHv3] simfs: read files from specific AID's

2017-11-06 Thread James Prestwood
The simfs atom could not read EF's that did not exist on the 'default' ADF directory. This implements a new way to read EF's that exist on a given AID. A new fs object/context can be initialized for a given AID. Using this fs context with the existing read file API will read from that AID rather th

[PATCHv2] simfs: read files from specific AID's

2017-11-06 Thread James Prestwood
The simfs atom could not read EF's that did not exist on the 'default' ADF directory. This implements a new way to read EF's that exist on a given AID. A new fs object/context can be initialized for a given AID. Using this fs context with the existing read file API will read from that AID rather th

[PATCH 4/5] sim: added ImsPrivateIdentity to SimManager

2017-11-06 Thread James Prestwood
If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44 2 files changed, 46 insertions(+) diff --git a/src/ofono.h

[PATCH 5/5] docs: ImsPrivateIdentity property documentation

2017-11-06 Thread James Prestwood
--- doc/sim-api.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 01ddc75..bce47c1 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -200,3 +200,8 @@ Properties boolean Present [readonly] might have changed the retry c

[PATCH 3/5] sim: implement create ISIM context

2017-11-06 Thread James Prestwood
API to create a sim context for the ISIM application, if found. During AID discovery, if an ISIM AID is found, a new fs object is initialized for the ISIM which will be used for any future ISIM context creation. --- src/sim.c | 41 + 1 file changed, 41 inser

[PATCH 1/5] simfs: read files from specific AID's

2017-11-06 Thread James Prestwood
The simfs atom could not read EF's that did not exist on the 'default' ADF directory. This implements a new way to read EF's that exist on a given AID. A new fs object/context can be initialized for a given AID. Using this fs context with the existing read file API will read from that AID rather th

[PATCH 2/5] sim: header definitions for ISIM context API

2017-11-06 Thread James Prestwood
This will allow an atom to create a SIM context to an ISIM AID (if available). It is then possible to access EF's on the ISIM using this SIM context. --- include/sim.h | 4 1 file changed, 4 insertions(+) diff --git a/include/sim.h b/include/sim.h index e10941f..23a9bc2 100644 --- a/include/

Re: [PATCH v2 1/2] gemalto: add PIN retries support in driver

2017-11-06 Thread Denis Kenzior
Hi Gabriel, On 11/06/2017 07:57 AM, Gabriel Lucas wrote: In SimManager, the Retries property isn't used for gemalto modems. The at command AT^SPIC is used to get the remaining retries left for the current required password type. This commit adds the implementation in the SIM driver of the retri

Re: [PATCH] gemalto: add PIN retries support

2017-11-06 Thread Gabriel LUCAS
Hi Denis, This patch doesn't apply. It looks like whitespace is corrupted, tabs switched to spaces, etc. Are you using Microsoft products by any chance? My bad, I wasn't able to configure git send-email correctly so I've tried with another email client. Bad idea apparently. This part shou

[PATCH v2 2/2] gemalto: add PIN retries support in plugin

2017-11-06 Thread Gabriel Lucas
In SimManager, the Retries property isn't used for gemalto modems. The at command AT^SPIC is used to get the remaining retries left for the current required password type. This commit enable the use of the driver in the gemalto plugin --- plugins/gemalto.c | 3 ++- 1 file changed, 2 insertions(+)

[PATCH v2 1/2] gemalto: add PIN retries support in driver

2017-11-06 Thread Gabriel Lucas
In SimManager, the Retries property isn't used for gemalto modems. The at command AT^SPIC is used to get the remaining retries left for the current required password type. This commit adds the implementation in the SIM driver of the retries queries. --- drivers/atmodem/sim.c | 45