Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]

2019-06-21 Thread Marcel Holtmann
Hi Denis, >>> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote: CC drivers/mbimmodem/mbim-message.o drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’: drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required alignment of target type [-Wer

Re: [PATCH] ubloxmodem: fix maybe-unitialized error

2019-06-21 Thread Denis Kenzior
Hi Martin, On 06/21/2019 03:21 PM, Martin Hundebøll wrote: Hi Denis, On 21/06/2019 19.54, Denis Kenzior wrote: What compiler are you using?  gcc really needs to make up its mind whether it warns about enums or doesn't.  The behavior between versions is nuts. % arm-oe-linux-gnueabi-gcc --ver

Re: [PATCH] ubloxmodem: fix maybe-unitialized error

2019-06-21 Thread Martin Hundebøll
Hi Denis, On 21/06/2019 19.54, Denis Kenzior wrote: What compiler are you using?  gcc really needs to make up its mind whether it warns about enums or doesn't.  The behavior between versions is nuts. % arm-oe-linux-gnueabi-gcc --version arm-oe-linux-gnueabi-gcc (GCC) 8.2.0 So I need this fix

Re: [PATCH] ubloxmodem: fix maybe-unitialized error

2019-06-21 Thread Denis Kenzior
Hi Martin, On 06/21/2019 04:56 AM, Martin Hundebøll wrote: Fixes: ../git/drivers/ubloxmodem/gprs-context.c: In function ‘ublox_gprs_activate_primary’: ../git/drivers/ubloxmodem/gprs-context.c:339:2: error: ‘auth’ may be used uninitialized in this function [-Werror=maybe-uninitialized] snpr

Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]

2019-06-21 Thread Denis Kenzior
Hi Martin, On 06/21/2019 04:52 AM, Martin Hundebøll wrote: Hi Denis, On 08/02/2019 21.15, Denis Kenzior wrote: Hi, On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:    CC       drivers/mbimmodem/mbim-message.o drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’: drivers/mbimmode

[PATCH] ubloxmodem: fix maybe-unitialized error

2019-06-21 Thread Martin Hundebøll
Fixes: ../git/drivers/ubloxmodem/gprs-context.c: In function ‘ublox_gprs_activate_primary’: ../git/drivers/ubloxmodem/gprs-context.c:339:2: error: ‘auth’ may be used uninitialized in this function [-Werror=maybe-uninitialized] snprintf(buf, sizeof(buf), "AT+UAUTHREQ=%u,%u,\"%s\",\"%s\"", ^~~

Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]

2019-06-21 Thread Martin Hundebøll
Hi Denis, On 08/02/2019 21.15, Denis Kenzior wrote: Hi, On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:    CC       drivers/mbimmodem/mbim-message.o drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’: drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required alig

RE: [PATCH 1/1] ublox: detect and support LARA R2 series

2019-06-21 Thread Krishna
Hi Jonas, Thanks for the patch. With your patch, ofono is able to recognize LARA modems. root@imx:/usr/lib/ofono/test# ./list-modems [ /ublox_0 ] Online = 0 Emergency = 0 Features = gprs sim Revision = XX.XX Serial = XXX Interfaces = org.ofono.ConnectionManager org