Re: [PATCH phonesim v2 1/8] Port to qt5

2019-10-29 Thread Jonah BrĂ¼chert
Hi, first of all, thanks for the review! The current structure of the commits is purely for historical reasons, since this is a collection of patches by different people that are all required for the Qt5 port. The Signed-off-by exist for the same reason, because the people who originally did

Re: [PATCH phonesim v2 1/8] Port to qt5

2019-10-29 Thread Denis Kenzior
Hi Jonah, On 10/27/19 11:30 AM, Jonah BrĂ¼chert wrote: From: Simon Busch Signed-off-by: Simon Busch Signed-off-by: Martin Jansa We don't use Signed-off-by, so please drop this in the future. --- Makefile.am | 2 +- configure.ac| 6 +++--- src/control.cpp | 4 ++--