[PATCH phonesim 03/13] Port old-style connects

2019-11-12 Thread Jonah Brüchert
* Update CXX Standard to 14 to be able to use qOverload() --- configure.ac| 4 +-- src/callmanager.cpp | 22 ++--- src/control.cpp | 77 + src/phonesim.cpp| 56 + src/phonesim.h | 3 +- 5

[PATCH phonesim 10/13] Port from c-style casts to static_cast<>()

2019-11-12 Thread Jonah Brüchert
Done using the google-readability-casting check of clang-tidy --- src/callmanager.cpp | 6 +- src/hardwaremanipulator.cpp | 12 +- src/phonesim.cpp | 62 +++--- src/qatresult.cpp| 10 +- src/qatresultparser.cpp | 6 +- src/qatutils.cpp |

[PATCH phonesim 09/13] Require Qt5Widgets >= 5.10

2019-11-12 Thread Jonah Brüchert
I don't think it's possible to use preprocessor directives with Qt's ui files, so this is neccessary. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 0587f9f..da87afe 100644 --- a/configure.ac +++ b/configure.ac @@ -22,7

[PATCH phonesim 06/13] qwsppdu: Port to QLocale

2019-11-12 Thread Jonah Brüchert
--- src/qwsppdu.cpp | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qwsppdu.cpp b/src/qwsppdu.cpp index 26f450d..f3a1661 100644 --- a/src/qwsppdu.cpp +++ b/src/qwsppdu.cpp @@ -18,13 +18,15 @@

[PATCH phonesim 12/13] Annotate overriding functions with override

2019-11-12 Thread Jonah Brüchert
* Allows us to notice when a function becomes source incompatible in a Qt major release, and our implementation stops overriding. --- src/aidapplication.cpp | 3 ++- src/aidapplication.h| 4 ++-- src/callmanager.h | 2 +- src/control.h | 18

[PATCH phonesim 13/13] Use bool literals

2019-11-12 Thread Jonah Brüchert
Done using the modernize-use-bool-literals of clang-tidy --- src/qsmsmessage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qsmsmessage.cpp b/src/qsmsmessage.cpp index 1d0f733..06845bf 100644 --- a/src/qsmsmessage.cpp +++ b/src/qsmsmessage.cpp @@ -1565,7 +1565,7 @@

[PATCH phonesim 07/13] Port away from Q_FOREACH

2019-11-12 Thread Jonah Brüchert
--- src/aidapplication.cpp | 4 ++-- src/callmanager.cpp | 6 +++--- src/control.cpp | 19 +-- src/hardwaremanipulator.cpp | 4 ++-- src/phonesim.cpp| 4 ++-- src/qsimcommand.cpp | 10 +- src/simfilesystem.cpp | 8

[PATCH phonesim 08/13] Port deprecations in controlbase.ui

2019-11-12 Thread Jonah Brüchert
--- src/controlbase.ui | 158 - 1 file changed, 142 insertions(+), 16 deletions(-) diff --git a/src/controlbase.ui b/src/controlbase.ui index 4eb1355..c2acbf6 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -17,7 +17,16 @@ 6

[PATCH phonesim 11/13] Use dynamic_cast where appropriate

2019-11-12 Thread Jonah Brüchert
Done using the cppcoreguidelines-pro-type-cstyle-cast check of clang-tidy --- src/aidapplication.cpp | 2 +- src/phonesim.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/aidapplication.cpp b/src/aidapplication.cpp index 16fef0c..807d7f9 100644 ---

[PATCH phonesim 04/13] Replace QtScript with QtQml

2019-11-12 Thread Jonah Brüchert
--- configure.ac| 2 +- src/control.cpp | 18 +- src/control.h | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 5cc4545..0587f9f 100644 --- a/configure.ac +++ b/configure.ac @@ -22,7 +22,7 @@

[PATCH phonesim 05/13] Port away from some deprecated Qt apis

2019-11-12 Thread Jonah Brüchert
--- src/qsimcommand.cpp| 4 src/qsmsmessage.cpp| 4 src/qwsppdu.cpp| 4 ++-- src/simapplication.cpp | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/qsimcommand.cpp b/src/qsimcommand.cpp index 672ffb9..6642035 100644 --- a/src/qsimcommand.cpp

[PATCH phonesim 01/13] Use nullptrs

2019-11-12 Thread Jonah Brüchert
Done using the modernize-use-nullptr check of clang-tidy --- src/aidapplication.h | 2 +- src/callmanager.h | 2 +- src/conformancesimapplication.cpp | 2 +- src/control.cpp | 2 +- src/control.h | 2 +- src/gsmspec.cpp

Modernize phonesim codebase

2019-11-12 Thread Jonah Brüchert
Dear maintainers, as mentioned earlier I'm now sending the remaining patches to ofono phonesim. I tried to split them up logically and to explain them in their descriptions. If anything is still unclear, please ask. Overall the patchset fixes all compiler warnings that appear with the

[PATCH phonesim 02/13] Replace deprecated headers

2019-11-12 Thread Jonah Brüchert
Done using the modernize-deprecated-headers check of clang-tidy --- src/main.cpp| 2 +- src/phonesim.h | 6 +++--- src/qsmsmessage.cpp | 2 +- src/qwsppdu.cpp | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index b320140..712e767

[PATCH] xmm7xxx: Introduce eUICC related changes for Gemalto's LPA

2019-11-12 Thread Antara Borwankar
xmm7xxx modem plugin will support Gemalto's eUICC LPA functionality, which includes opening a logical channel to ISDR applet in eUICC and transmitting APDU command for Profile Download, Profile Activate etc. from LPA to the eUICC and deliver the response from eUICC to LPA. --- plugins/xmm7xxx.c |