[PATCH] huawei: fix AT^SYSCFGEX acqorder "0201"

2020-06-25 Thread Jimmy Gysens
Commit 6c574ee24a57d0397e4e3c617016bf026405960a ("huawei: the AT^SYSCFGEX command supports additional modes") has a mistake for acqorder "0201". It should be UMTS and GSM preferred. --- drivers/huaweimodem/radio-settings.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

Re: [PATCH] gprs: clean context properly

2020-06-25 Thread Denis Kenzior
Hi Jimmy, On 6/25/20 4:30 AM, Jimmy Gysens wrote: After a context is detached, the context is not properly cleared. In addition to releasing the context: - Reset the context settings (IP, DNS, interface, ...). - Signal the Active flag as false. --- src/gprs.c | 24 1

Re: [PATCH 1/2] modem: add a driver reset function

2020-06-25 Thread Denis Kenzior
Hi Jimmy, On 6/25/20 4:28 AM, Jimmy Gysens wrote: Add a reset function to the modem driver. This function can be used to hard reset the device. This is an alternative in case the (*enable) and (*disable) functions are not supported. I'm confused, how are you even powering the modem up if enabl

Re: [PATCH 1/2] huawei: add RejectInfo signal to org.ofono.ConnectionManager

2020-06-25 Thread Denis Kenzior
Hi Jimmy, On 6/25/20 4:28 AM, Jimmy Gysens wrote: Huawei devices can have support for ^REJINFO unsolicited event. This event provides useful info, regarding to the network attached state, for higher level applications. This commit adds an additional property RejectInfo to the PropertyChanged si

Re: [PATCH] huawei: send restore settings command on startup

2020-06-25 Thread Denis Kenzior
Hi Jimmy, On 6/25/20 4:29 AM, Jimmy Gysens wrote: When initializing a Huawei device, send the AT&F0 command to restore the default AT settings on device restart. Huawei stores all APN settings, which can cause issues when changing the APN. The AT&F0 command makes sure the device starts from a c

Re: [PATCH] huawei: the AT^SYSCFGEX command supports additional modes

2020-06-25 Thread Denis Kenzior
Hi Jimmy, On 6/25/20 4:29 AM, Jimmy Gysens wrote: - LTE and UMTS preferred (acqorder = 0302); AT^SYSCFGEX="0302",4000,2,4,4000 - UMTS and GSM preferred (acqorder = 0201); AT^SYSCFGEX="0201",4000,2,4,4000 For AT^SYSCFG, the modes are not available. --- drivers/huaweimodem/radi

Re: [PATCH] atmodem: set PDP/EPS minimum context ID to 1.

2020-06-25 Thread Denis Kenzior
Hi Jimmy, On 6/25/20 4:29 AM, Jimmy Gysens wrote: There are manufacturers, like Huawei, returning profile 0 as the minimum PDP/EPS context ID. Profile 0, however, is the default profile used to register to the LTE network. It contains manufacturer specific settings and should not be created by +

[PATCH] huawei: the AT^SYSCFGEX command supports additional modes

2020-06-25 Thread Jimmy Gysens
- LTE and UMTS preferred (acqorder = 0302); AT^SYSCFGEX="0302",4000,2,4,4000 - UMTS and GSM preferred (acqorder = 0201); AT^SYSCFGEX="0201",4000,2,4,4000 For AT^SYSCFG, the modes are not available. --- drivers/huaweimodem/radio-settings.c | 13 + 1 file changed, 13 in

[PATCH] gprs: clean context properly

2020-06-25 Thread Jimmy Gysens
After a context is detached, the context is not properly cleared. In addition to releasing the context: - Reset the context settings (IP, DNS, interface, ...). - Signal the Active flag as false. --- src/gprs.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff -

[PATCH] atmodem: set PDP/EPS minimum context ID to 1.

2020-06-25 Thread Jimmy Gysens
There are manufacturers, like Huawei, returning profile 0 as the minimum PDP/EPS context ID. Profile 0, however, is the default profile used to register to the LTE network. It contains manufacturer specific settings and should not be created by +CGDCONT. Reference: ETSI TS 127 007: AT command set

[PATCH] huawei: send restore settings command on startup

2020-06-25 Thread Jimmy Gysens
When initializing a Huawei device, send the AT&F0 command to restore the default AT settings on device restart. Huawei stores all APN settings, which can cause issues when changing the APN. The AT&F0 command makes sure the device starts from a clean state. --- plugins/huawei.c | 4 1 file ch

[PATCH 2/2] huawei: reset function

2020-06-25 Thread Jimmy Gysens
Implement the modem reset function for Huawei. Huawei devices can be reset (reboot) by sending the AT^RESET command. --- plugins/huawei.c | 25 + 1 file changed, 25 insertions(+) diff --git a/plugins/huawei.c b/plugins/huawei.c index bb876701..35195e2d 100644 --- a/plugin

[PATCH 1/2] huawei: add RejectInfo signal to org.ofono.ConnectionManager

2020-06-25 Thread Jimmy Gysens
Huawei devices can have support for ^REJINFO unsolicited event. This event provides useful info, regarding to the network attached state, for higher level applications. This commit adds an additional property RejectInfo to the PropertyChanged signal for org.ofono.ConnectionManager. --- include/gp

[PATCH 1/2] modem: add a driver reset function

2020-06-25 Thread Jimmy Gysens
Add a reset function to the modem driver. This function can be used to hard reset the device. This is an alternative in case the (*enable) and (*disable) functions are not supported. A reset will not work when emergency mode is active. For dbus: dbus-send \ --system \

[PATCH 2/2] huawei: add ^REJINFO unsolicited listener

2020-06-25 Thread Jimmy Gysens
Add an event listener for Huawei's ^REJINFO unsolicited event. This event provides information regarding the network's attach state. Format: ^REJINFO: Note: not all Huawei devices support this. Reference: Huawei ME909s Series LTE Module V100R001 AT command specification. --- drivers/atmode