Re: [PATCH v2 2/3] udev: u8500 support and style fix

Hi Marcel, Jessica is out of office. On 2011-02-01 16:39, Marcel Holtmann wrote: Hi Jessica, plugins/udev.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) so you wanna combine the udev rule change and the udev change together actually. They both belong together. The actua

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

Hi Marcel, On 2011-02-01 16:43, Marcel Holtmann wrote: Hi Jessica, drivers/isimodem/debug.c | 132 drivers/isimodem/debug.h |9 +++ drivers/isimodem/mtc.h | 38 + drivers/isimodem/version.h | 26 + 4 files

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

Hi Aki, On 2011-02-01 20:32, Aki Niemi wrote: Like I replied earlier, I don't see the need for this. Also, it will not work well with the isiusb plugin, which has the potential to work with any ISI modem. I'm not willing to break that potential until we just absolutely have to. U8500 uses shrm

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

Hi Aki, On 2011-02-02 14:03, Aki Niemi wrote: I don't see what that has to do with the device supporting the "PC suite" USB profile, which allows modem access using cdc_phonet. Currently our platform does not support this. That is exactly what I meant. This version allows building quirks ins

[PATCH 00/18] wgmodem2.5 support

Hi, This series of patches adds wgmodem2.5 support to isimodem and provides a plugin for the ST-Ericsson u8500 platform. I'm sending these on Jessica's behalf. After discussions with Aki about how to handle the 2 versions of ISI we have implemented 2 methods to handle this, first in case the reso

[PATCH 01/18] gisi: pipe and pep for wgmodem2.5

From: Jessica Nilsson --- gisi/message.c |8 ++ gisi/message.h |1 + gisi/modem.c | 20 gisi/modem.h |1 + gisi/pep.c | 330 gisi/pep.h |6 + gisi/pipe.c| 180 -- gisi/pi

[PATCH 02/18] gisi: modem version detection

From: Jessica Nilsson --- gisi/modem.c | 27 +++ gisi/modem.h |6 ++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index 7657bd1..734c4f1 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -62,6 +62,7 @@ struct _GIsiMod

[PATCH 03/18] isimodem: general build updates for wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/debug.c | 48 ++ drivers/isimodem/debug.h |8 +++ drivers/isimodem/mtc.h | 38 3 files changed, 94 insertions(+), 0 deletions(-) diff --git a/drivers/isimode

[PATCH 04/18] gisi: fix subscription for wgmodem2.5

From: Jessica Nilsson --- gisi/modem.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index 734c4f1..143e761 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -370,13 +370,15 @@ static gboolean modem_subs_update(gpointer data)

[PATCH 05/18] plugins: add plugin for u8500

From: Jessica Nilsson --- Makefile.am |3 + plugins/u8500.c | 506 +++ 2 files changed, 509 insertions(+), 0 deletions(-) create mode 100644 plugins/u8500.c diff --git a/Makefile.am b/Makefile.am index 1d7f32b..1b9afe8 100644 --- a/M

[PATCH 07/18] isimodem: add wgmodem2.5 to devinfo

From: Jessica Nilsson --- drivers/isimodem/debug.c |1 + drivers/isimodem/devinfo.c | 161 drivers/isimodem/info.h|3 + 3 files changed, 136 insertions(+), 29 deletions(-) diff --git a/drivers/isimodem/debug.c b/drivers/isimodem/debug.

[PATCH 06/18] plugins: add u8500 to udev

From: Jessica Nilsson --- plugins/ofono.rules |3 +++ plugins/udev.c |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index f01b739..1090cf7 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules @@ -356,6 +356,9 @@

[PATCH 09/18] isimodem: clip colp clir colr wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/call-settings.c | 697 +- drivers/isimodem/call.h |9 + drivers/isimodem/debug.c |4 + drivers/isimodem/ss.h| 22 ++ 4 files changed, 714 insertions(+), 18 deletions(-) diff --

[PATCH 11/18] isimodem: gprs-context updates wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/gprs-context.c | 95 +- 1 files changed, 62 insertions(+), 33 deletions(-) diff --git a/drivers/isimodem/gprs-context.c b/drivers/isimodem/gprs-context.c index 6d579d8..f458fcc 100644 --- a/drivers/isimodem/gprs-co

[PATCH 10/18] isimodem: wgmodem2.5 added to voicecall

From: Jessica Nilsson --- drivers/isimodem/call.h | 82 - drivers/isimodem/voicecall.c | 218 +- 2 files changed, 253 insertions(+), 47 deletions(-) diff --git a/drivers/isimodem/call.h b/drivers/isimodem/call.h index 84f4e04..9c85

[PATCH 12/18] isimodem: wgmodem2.5 support in USSD

From: Jessica Nilsson --- drivers/isimodem/ussd.c | 36 ++-- 1 files changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c index d649484..abc6e09 100644 --- a/drivers/isimodem/ussd.c +++ b/drivers/isimodem/ussd

[PATCH 15/18] isimodem: wgmodem2.5 added to ssn

From: Jessica Nilsson --- drivers/isimodem/call-forwarding.c |1 - drivers/isimodem/ssn.c | 382 +++- 2 files changed, 377 insertions(+), 6 deletions(-) diff --git a/drivers/isimodem/call-forwarding.c b/drivers/isimodem/call-forwarding.c index 7

[PATCH 13/18] isimodem: SS_GSM_BARRING_INFO added

From: Jessica Nilsson SS_GSM_BSC_INFO added. --- drivers/isimodem/call-barring.c | 99 ++ 1 files changed, 88 insertions(+), 11 deletions(-) diff --git a/drivers/isimodem/call-barring.c b/drivers/isimodem/call-barring.c index a78b762..a1d9a13 100644 --- a/d

[PATCH 16/18] isimodem: sms updated with wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/debug.c | 56 +++ drivers/isimodem/debug.h |1 + drivers/isimodem/sms.c | 972 +++--- drivers/isimodem/sms.h | 34 ++ 4 files changed, 927 insertions(+), 136 deletions(-) diff --git a/drivers/isimode

[PATCH 17/18] isimodem: CBS for wgmodem2.5

From: Jessica Nilsson set and clear topics support added --- drivers/isimodem/cbs.c | 425 +- drivers/isimodem/debug.c |4 + drivers/isimodem/sms.h |7 +- 3 files changed, 394 insertions(+), 42 deletions(-) diff --git a/drivers/isimodem/c

[PATCH 18/18] isimodem: initial support for UICC phonebook

From: Jessica Nilsson --- drivers/isimodem/phonebook.c | 1241 - 1 files changed, 1210 insertions(+), 31 deletions(-) diff --git a/drivers/isimodem/phonebook.c b/drivers/isimodem/phonebook.c index 1f92d37..dfb76ed 100644 --- a/drivers/isimodem/phonebook.c

[PATCH 14/18] isimodem: wgmodem2.5 added to call-forwarding

From: Jessica Nilsson --- drivers/isimodem/call-forwarding.c | 31 +++ 1 files changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/isimodem/call-forwarding.c b/drivers/isimodem/call-forwarding.c index 89a03dc..74645c3 100644 --- a/drivers/isimodem/call-

Re: [PATCH 01/18] gisi: pipe and pep for wgmodem2.5

On 2011-02-15 14:23, Rémi Denis-Courmont wrote: On Tuesday 15 February 2011 14:30:55 ext Andreas Westin, you wrote: From: Jessica Nilsson I don't understand why you put a pipe controller in user-space. Why do we need a pipe controller at all? As far as I can tell, implementing connect

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

Hi Aki, On 2011-02-16 12:16, Aki Niemi wrote: Curly brackets are either in both if and else, or in neither. I actually prefer not to have them here, since the first line is just a comment in the else statement. ;) Yes you're right :) This is not necessary, as a modem plugin is supposed to ca

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

Hi, On 2011-02-16 15:22, Aki Niemi wrote: Hi, 2011/2/15 Andreas Westin: From: Jessica Nilsson --- drivers/isimodem/debug.c | 56 +++ drivers/isimodem/debug.h |1 + drivers/isimodem/sms.c | 972 +++--- drivers/isimodem/sms.h | 34

Re: [PATCH 05/18] plugins: add plugin for u8500

On 2011-02-16 15:26, Aki Niemi wrote: Hi, 2011/2/15 Andreas Westin: +static int u8500_probe(struct ofono_modem *modem) +{ + const char *ifname = ofono_modem_get_string(modem, "Interface"); + unsigned address = ofono_modem_get_integer(modem, "Address"); +

Re: [PATCH 1/1] src: out of bounds problem in smsutil

On 2011-02-16 16:25, Denis Kenzior wrote: Hi Jessica, On 02/16/2011 06:04 AM, Jessica Nilsson wrote: --- This one was exposed when wgmodem2.5 CBS was run with valgrind. Best Regards, Jessica Nilsson Can you post the actual error and the data this happened on? src/smsutil.c |2 +-

Re: [PATCH 1/1] src: out of bounds problem in smsutil

Hi, Valgrind complains that we step outside the allocated memory by 1 byte since we loop the string with: while (*topics != '\0') the allocated memory is the size of the string and any \0 ends up outside. At least that's my interpretation. It might be your loop is actually going past the en

Re: [PATCH 17/18] isimodem: CBS for wgmodem2.5

Hi Denis, On 2011-02-16 17:10, Denis Kenzior wrote: Hi Andreas, Have you thought of adapting cbs_extract_topic_ranges function for all of this somehow? Yes we are looking at it now. Cheers Andreas ___ ofono mailing list ofono@ofono.org http://lis

[PATCH v2 00/18] wgmodem2.5 support

Hi, Second go on the patches for wgmodem2.5, please review. Note that we are still working on the changes for pipe/pep and CBS, having some problems with testing them so those patches are not updated in this set just included to ensure no conflicts. Cheers Andreas Jessica Nilsson (18): gisi:

[PATCH v2 01/18] gisi: pipe and pep for wgmodem2.5

From: Jessica Nilsson --- gisi/message.c |8 ++ gisi/message.h |1 + gisi/modem.c | 20 gisi/modem.h |1 + gisi/pep.c | 330 gisi/pep.h |6 + gisi/pipe.c| 180 -- gisi/pi

[PATCH v2 03/18] plugins: add plugin for u8500

From: Jessica Nilsson --- Makefile.am |3 + plugins/u8500.c | 708 +++ 2 files changed, 711 insertions(+), 0 deletions(-) create mode 100644 plugins/u8500.c diff --git a/Makefile.am b/Makefile.am index 7bd7f4f..aa4f3f9 100644 --- a/M

[PATCH v2 02/18] isimodem: added codepoints for u8500

From: Jessica Nilsson --- drivers/isimodem/debug.c |1 + drivers/isimodem/info.h |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/debug.c b/drivers/isimodem/debug.c index c14acc2..10d0201 100644 --- a/drivers/isimodem/debug.c +++ b/drivers/isimodem

[PATCH v2 05/18] gisi: add getter and setter for sim

From: Jessica Nilsson --- gisi/modem.c | 22 ++ gisi/modem.h |3 +++ 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index 7657bd1..2f5e2ae 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -70,6 +70,7 @@ struct _GIsiModem {

[PATCH v2 04/18] plugins: add u8500 to udev

From: Jessica Nilsson --- plugins/ofono.rules |3 +++ plugins/udev.c |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 121825e..2e315a3 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules @@ -357,6 +357,9 @@

[PATCH v2 06/18] src: add missing SIM enum to simutil.h

From: Jessica Nilsson --- src/simutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index a5a683b..16b210b 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -34,6 +34,7 @@ enum sim_fileid { SIM_DFPHONEBOOK_FILEID =0x5F3A,

[PATCH v2 07/18] isimodem: code points uicc sim wgmodem2.5

From: Jessica Nilsson --- Makefile.am |4 +- drivers/isimodem/debug.c | 84 +++ drivers/isimodem/debug.h |1 + drivers/isimodem/uicc.h | 265 ++ 4 files changed, 353 insertions(+), 1 deletions(-) create mode 100644

[PATCH v2 09/18] isimodem: clip colp clir colr wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/call-settings.c | 711 +- drivers/isimodem/call.h |9 + drivers/isimodem/debug.c |4 + drivers/isimodem/ss.h| 22 ++ 4 files changed, 728 insertions(+), 18 deletions(-) diff --

[PATCH v2 11/18] isimodem: wgmodem2.5 support in USSD

From: Jessica Nilsson --- drivers/isimodem/ussd.c | 36 ++-- 1 files changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c index d649484..ce402f1 100644 --- a/drivers/isimodem/ussd.c +++ b/drivers/isimodem/ussd

[PATCH v2 10/18] isimodem: wgmodem2.5 added to voicecall

From: Jessica Nilsson --- drivers/isimodem/call.h | 82 - drivers/isimodem/voicecall.c | 218 +- 2 files changed, 253 insertions(+), 47 deletions(-) diff --git a/drivers/isimodem/call.h b/drivers/isimodem/call.h index 84f4e04..9c85

[PATCH v2 12/18] isimodem: SS_GSM_BARRING_INFO added

From: Jessica Nilsson SS_GSM_BSC_INFO added. --- drivers/isimodem/call-barring.c | 99 ++ 1 files changed, 88 insertions(+), 11 deletions(-) diff --git a/drivers/isimodem/call-barring.c b/drivers/isimodem/call-barring.c index a78b762..a1d9a13 100644 --- a/d

[PATCH v2 14/18] isimodem: wgmodem2.5 added to ssn

From: Jessica Nilsson --- drivers/isimodem/call-forwarding.c |1 - drivers/isimodem/ssn.c | 406 +++- 2 files changed, 401 insertions(+), 6 deletions(-) diff --git a/drivers/isimodem/call-forwarding.c b/drivers/isimodem/call-forwarding.c index 6

[PATCH v2 13/18] isimodem: wgmodem2.5 added to call-forwarding

From: Jessica Nilsson --- drivers/isimodem/call-forwarding.c | 29 + 1 files changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/isimodem/call-forwarding.c b/drivers/isimodem/call-forwarding.c index 89a03dc..687f975 100644 --- a/drivers/isimodem/call-fo

[PATCH v2 16/18] isimodem: sms updated with wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/sms.c | 958 +--- 1 files changed, 822 insertions(+), 136 deletions(-) diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c index 957b342..f721684 100644 --- a/drivers/isimodem/sms.c +++ b/drivers/is

[PATCH v2 15/18] isimodem: code points for sms wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/debug.c | 56 ++ drivers/isimodem/debug.h |1 + drivers/isimodem/sms.h | 34 3 files changed, 91 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/debug.c b/dr

[PATCH v2 17/18] isimodem: CBS for wgmodem2.5

From: Jessica Nilsson --- drivers/isimodem/cbs.c | 414 +- drivers/isimodem/debug.c |4 + drivers/isimodem/sms.h |7 +- 3 files changed, 383 insertions(+), 42 deletions(-) diff --git a/drivers/isimodem/cbs.c b/drivers/isimodem/cbs.c index

[PATCH v2 18/18] isimodem: initial support for UICC phonebook

From: Jessica Nilsson --- drivers/isimodem/phonebook.c | 1273 +- 1 files changed, 1243 insertions(+), 30 deletions(-) diff --git a/drivers/isimodem/phonebook.c b/drivers/isimodem/phonebook.c index 1f92d37..6b136b0 100644 --- a/drivers/isimodem/phonebook.