[PATCH v2 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to disable this feature in the audio gateway. The HFP spec defines the procedure to turn off echo canceling and noise reduction only. There are some modems that also allow to turn on

[PATCH v2 2/7] core: Add echo-canceling-and-noise-reduction

This patch adds echo-canceling-and-noise-reduction to Features property of the Handsfree interface. --- src/handsfree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 8a0374d..6d7f263 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -62,6 +62,9

[PATCH v2 4/7] core: Set EchoCancelingNoiseReduction to TRUE by default

According to Bluetooth HFP spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction functions, it shall have them activated until the AT+NREC command is received. The configuration set by the HF shall by used by the AG while the Service Level Connection is

[PATCH v2 6/7] hfpmodem: Add EchoCancelingNoiseReduction

This patch adds echo canceling and noise reduction implementation to hfpmodem. --- drivers/hfpmodem/handsfree.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/hfpmodem/handsfree.c b/drivers/hfpmodem/handsfree.c index ce28de3..d7561e7 100644 ---

[PATCH v2 7/7] core: Add SetProperty for EchoCancelingNoiseReduction

This patch extends SetProperty method of the Handsfree interface allowing to disable echo canceling and noise reduction feature in the audio gateway through a D-Bus method call. Once disabled, it is not allowed to enable it using this procedure. --- src/handsfree.c | 56

[PATCH v3 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to disable this feature in the audio gateway. The HFP spec defines the procedure to turn off echo canceling and noise reduction only, it is not allowed to enable this feature from the HF

[PATCH v3 2/7] core: Add echo-canceling-and-noise-reduction

This patch adds echo-canceling-and-noise-reduction to Features property of the Handsfree interface. --- src/handsfree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 8a0374d..6d7f263 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -62,6 +62,9

[PATCH v3 4/7] core: Set EchoCancelingNoiseReduction to TRUE by default

According to Bluetooth HFP spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction functions, it shall have them activated until the AT+NREC command is received. The configuration set by the HF shall by used by the AG while the Service Level Connection is

[PATCH v3 7/7] core: Add SetProperty for EchoCancelingNoiseReduction

This patch extends SetProperty method of the Handsfree interface allowing to disable echo canceling and noise reduction feature in the audio gateway through a D-Bus method call. Once disabled, it is not allowed to enable it using this procedure. --- src/handsfree.c | 54

[PATCH v3 3/7] core: Add EchoCancelingNoiseReduction to GetProperties

This patch adds EchoCancelingNoiseReduction property to GetProperties method of Handsfree interface. --- src/handsfree.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 6d7f263..9e4fc6b 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -45,6

[PATCH v3 5/7] include: Add EchoCancelingNoiseReduction to handsfree driver

This patch extends the handsfree driver adding echo canceling and noise reduction callback to allow disabling this feature in the audio gateway. --- include/handsfree.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/handsfree.h b/include/handsfree.h index b5e0d5f..dde7000 100644

[PATCH v1 4/7] core: Set EchoCancelingNoiseReduction to TRUE by default

According to Bluetooth HFP spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction functions, it shall have them activated until the AT+NREC command is received. The configuration set by the HF shall by used by the AG while the Service Level Connection is

[PATCH v1 5/7] include: Add EchoCancelingNoiseReduction to handsfree driver

This patch extends the handsfree driver adding echo canceling and noise reduction callback to allow enabling or disabling this feature in the audio gateway. --- include/handsfree.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/handsfree.h b/include/handsfree.h index

[PATCH v1 6/7] hfpmodem: Add EchoCancelingNoiseReduction

This patch adds echo canceling and noise reduction implementation to hfpmodem. --- drivers/hfpmodem/handsfree.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/hfpmodem/handsfree.c b/drivers/hfpmodem/handsfree.c index ce28de3..2b96566 100644 ---

[PATCH v1 2/7] core: Add echo-canceling-and-noise-reduction

This patch adds echo-canceling-and-noise-reduction to Features property of the Handsfree interface. --- src/handsfree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 8a0374d..6d7f263 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -62,6 +62,9

[PATCH v1 3/7] core: Add EchoCancelingNoiseReduction to GetProperties

This patch adds EchoCancelingNoiseReduction property to GetProperties method of Handsfree interface. --- src/handsfree.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 6d7f263..d60841b 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -45,6

[PATCH v1 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to enable or disable this feature in the audio gateway. According to Bluetooth HFP 1.6 spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction

Re: [PATCH v1 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

Hi Denis: On Mon, Apr 22, 2013 at 6:04 AM, Denis Kenzior denk...@gmail.com wrote: Hi Claudio, On 04/22/2013 07:58 AM, Claudio Takahasi wrote: This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to enable or disable this feature

[PATCH v0 5/7] include: Add ECNR to handsfree driver

This patch extends the handsfree driver adding echo canceling and noise reduction callback to allow enabling or disabling this feature in the audio gateway. --- include/handsfree.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/handsfree.h b/include/handsfree.h index

[PATCH v0 7/7] core: Add SetProperty for ECNR

This patch extends SetProperty method to allow enabling or disabling the echo canceling and noise reduction feature in the audio gateway through a D-Bus method call. --- src/handsfree.c | 56 +++- 1 file changed, 47 insertions(+), 9 deletions(-)

[PATCH v0 1/7] doc: Add ECNR to Handsfree

This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to enable or disable this feature in the audio gateway. According to Bluetooth HFP 1.6 spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction

[PATCH v0 3/7] core: Add ECNR in Handsfree GetProperty

--- src/handsfree.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 6d7f263..041d3f2 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -45,6 +45,7 @@ static GSList *g_drivers = NULL; struct ofono_handsfree { + ofono_bool_t ecnr;

[PATCH v0 4/7] core: Set ECNR to TRUE by default

According to Bluetooth HFP spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction functions, it shall have them activated until the AT+NREC command is received. The configuration set by the HF shall by used by the AG while the Service Level Connection is

[PATCH v0 2/7] core: Add ECNR to Handsfree Features

This patch adds echo-canceling-and-noise-reduction to Features property of the Handsfree interface. --- src/handsfree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 8a0374d..6d7f263 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -62,6 +62,9

Re: [PATCH v0 1/7] doc: Add ECNR to Handsfree

Hi Johan: On Fri, Apr 19, 2013 at 5:11 PM, Johan Hedberg johan.hedb...@gmail.com wrote: Hi Claudio, On Fri, Apr 19, 2013, Claudio Takahasi wrote: This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to enable or disable this feature

Re: [PATCH v0 1/7] doc: Add ECNR to Handsfree

Hi Denis/Johan: On Fri, Apr 19, 2013 at 12:24 PM, Denis Kenzior denk...@gmail.com wrote: Hi Claudio, On 04/19/2013 12:34 PM, Claudio Takahasi wrote: This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to enable or disable

[PATCH v0 01/15] handsfree-audio: Add card driver

This patch adds a new handsfree audio driver abstration to allow implementing the connect callbacks and other potential functions specific of each HFP profile version. This approach also avoids including dependency of hfpmodem in handsfree-audio, keeping the service level handling inside the

[PATCH v0 00/15] Add handsfree audio card driver

external-hfp16 Changes between RFC v0 and PATCH v0: * Fixed register/unregister of the Card driver * Changed handsfree-audio doc: added possible errors Claudio Takahasi (15): handsfree-audio: Add card driver hfp_hf_bluez5: Register handsfree audio driver hfp_hf_bluez5: Add extracting

[PATCH v0 02/15] hfp_hf_bluez5: Register handsfree audio driver

This patch registers the Handsfree Audio Card driver for devices compliant with HFP 1.5. --- plugins/hfp_hf_bluez5.c | 29 + 1 file changed, 29 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 381a541..2020e63 100644 ---

[PATCH v0 04/15] handsfree-audio: Add version to card driver

This patch extends the Handsfree Audio Card driver adding the Handsfree Profile version to allow switching different drivers to manage SCO connections or any other specific action related to a given profile version. --- include/handsfree-audio.h | 4 +++- src/handsfree-audio.c | 5 - 2

[PATCH v0 05/15] hfp_hf_bluez5: Pass version to card registration

Informs the HFP version of the remote device when the Audio Card is created. --- plugins/hfp_hf_bluez5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index a8d8277..f201b05 100644 --- a/plugins/hfp_hf_bluez5.c +++

[PATCH v0 06/15] hfp_hf_bluez5: Add version to HFP 1.5 card driver

--- plugins/hfp_hf_bluez5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index f201b05..1b3b7bc 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -326,6 +326,7 @@ static int card_audio_connect15(const char *remote, const

[PATCH v0 07/15] core: Add bt_str2ba() to bluetooth.h

This patch adds a utility Bluetooth function to convert Bluetooth address from string to bdaddr_t. --- src/bluetooth.h | 8 src/handsfree-audio.c | 1 + 2 files changed, 9 insertions(+) diff --git a/src/bluetooth.h b/src/bluetooth.h index 1584109..af6f02c 100644 ---

[PATCH v0 08/15] hfp_hf_bluez5: Add HFP 1.5 connect implementation

This patch adds the Audio Card driver connect callback implementation to handle SCO connection requested by the driver. This approach addresses devices compliant with HFP 1.5 --- plugins/hfp_hf_bluez5.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff

[PATCH v0 09/15] handsfree-audio: Add calling connect callback

This patch adds the call of the connect callback implemented in the driver when Connect method of the Audio Card gets called. --- src/handsfree-audio.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index

[PATCH v0 10/15] handsfree-audio: Add connect GIOChannel watch

This patch adds the GIOChannel watch of the SCO socket. For HF initiated connections, when the audio connection is established the reply for the Card Connect method should be sent. --- src/handsfree-audio.c | 43 +++ 1 file changed, 43 insertions(+) diff

[PATCH v0 11/15] handsfree-audio: Add sending SCO fd

This patch adds the call of NewConnection method when the SCO connection is established for HF initiated scenarios. --- src/handsfree-audio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index f5d0a7b..6fa8b67 100644 ---

[PATCH v0 12/15] handsfree-audio: Return NotAvailable on Connect

Returns Operation currently not available if Connect method of the Handsfree Audio Card gets called and there isn't an agent registered. --- src/handsfree-audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index 6fa8b67..8950347 100644 ---

[PATCH v0 13/15] handsfree-audio: Return InProgress on Connect

This patch returns Operation already in progress if there is a pending Handsfree Audio Card Connect method call pending. --- src/handsfree-audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index 8950347..805f3b6 100644 ---

[PATCH v0 15/15] doc: Add Handsfree Audio Card Connect errors

--- doc/handsfree-audio-api.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/handsfree-audio-api.txt b/doc/handsfree-audio-api.txt index 6c3c8b5..7d20925 100644 --- a/doc/handsfree-audio-api.txt +++ b/doc/handsfree-audio-api.txt @@ -70,6 +70,11 @@ Methods dict

[PATCH v0 14/15] handsfree-audio: Check agent before sending fd

This patch avoids sending the SCO fd when the connection is established and the agent left the bus. This check covers the scenario when the agent leaves the bus between Connect method call until the SCO GIOChannel watch gets called. --- src/handsfree-audio.c | 3 ++- 1 file changed, 2

[RFC v0 00/20] HFP1.6: Codec negotiation and HF Connect

: * Unregister the codec watcher * Some errors handling Development branch: git://git.infradead.org/users/cktakahasi/ofono.git external-hfp16 Claudio Takahasi (18): handsfree-audio: Add card driver for HFP 1.6 handsfree-audio: Add user data to card driver hfp_hf_bluez5: Pass modem as user data

[RFC v0 01/20] handsfree-audio: Add card driver for HFP 1.6

This patch registers the Handsfree Audio Card driver for devices compliant with HFP 1.6. --- plugins/hfp_hf_bluez5.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index dd0a782..810107f 100644 ---

[RFC v0 03/20] hfp_hf_bluez5: Pass modem as user data

This patch adds the modem reference as user data when the Handsfree Audio Card is created, allowing to access the service level connection in the connect callback. --- plugins/hfp_hf_bluez5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/hfp_hf_bluez5.c

[RFC v0 04/20] handsfree-audio: Add user data to connect declaration

This patch adds the user data in the Handsfree Audio driver connect callback declaration. --- include/handsfree-audio.h | 3 ++- src/handsfree-audio.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/handsfree-audio.h b/include/handsfree-audio.h index

[RFC v0 05/20] hfp_hf_bluez5: Add user data to connect implementation

This patch adds the user data in the Handsfree Audio driver connect implementation to allow accessing modem reference. --- plugins/hfp_hf_bluez5.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 1d26a28..0d5d5c7

[RFC v0 06/20] hfp_hf_bluez5: Add HFP 1.6 connect implementation

This patch implements the HF initiate SCO connection for devices compliant with HFP 1.6. HF sends AT+BCC to inform the AG that audio connection is required. --- plugins/hfp_hf_bluez5.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/plugins/hfp_hf_bluez5.c

[RFC v0 07/20] handsfree-audio: Add HFP 1.6 connect hook

This patch treats -EINPROGRESS as success return value for HFP 1.6 Audio Connection setup. For HFP 1.6, HF sends AT+BCC and waits the AG to establish the SCO connection. --- src/handsfree-audio.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/handsfree-audio.c

[RFC v0 08/20] handsfree-audio: Add Connect reply for HFP 1.6

For HFP 1.6, the HF sends AT+BCC to inform the AG that a SCO connection needs to be established, and the AG initiates the connection. For this case, the Connect method reply needs to be sent when the link is established. --- src/handsfree-audio.c | 7 +++ 1 file changed, 7 insertions(+) diff

[RFC v0 09/20] handsfree-audio: Add function to get the codecs

This patch adds a new handsfree-audio public function to read the available codecs registered by the agent. --- include/handsfree-audio.h | 1 + src/handsfree-audio.c | 13 + 2 files changed, 14 insertions(+) diff --git a/include/handsfree-audio.h b/include/handsfree-audio.h

[RFC v0 12/20] hfp_hf_bluez5: Register codec watcher

This patch registers the codec watcher when the Handsfree Audio Card driver probe callback gets called. --- plugins/hfp_hf_bluez5.c | 16 1 file changed, 16 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 6c55657..f20aff7 100644 ---

[RFC v0 11/20] hfpmodem: Add codec watcher register

From: Vinicius Costa Gomes vinicius.go...@openbossa.org This patch adds a function to monitor when the AG sends a new codec before establishing the SCO connection. --- drivers/hfpmodem/slc.c | 68 ++ drivers/hfpmodem/slc.h | 4 +++ 2 files

[RFC v0 13/20] handsfree-audio: Add function to select the codec

This patch adds a public function to select the active codec in the Audio Card. The AG informs the HF which codec ID is to be used before establishing the Synchronous Connection. The selected codec is input to set properly the SCO parameters. --- include/handsfree-audio.h | 2 ++

[RFC v0 14/20] hfp_hf_bluez5: Set the audio codec in the card

This patch updates the handsfree audio card codec when the AG notifies the codec for the succeeding incoming SCO connection. --- plugins/hfp_hf_bluez5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index f20aff7..49cc378 100644 ---

[RFC v0 15/20] handsfree-audio: Send the selected codec

This patch removes the hard-coded CVSD codec, and adds the selected codec in the NewConnection method call, notifying the agent the codec previously selected for the audio connection. --- src/handsfree-audio.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[RFC v0 16/20] handsfree-audio: Set CVSD as default in the card

If the device doesn't support codec negotiation, the selected codec is not being initialized. For this case set CVSD as default. --- src/handsfree-audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index 0d31712..0eb5c70 100644 ---

[RFC v0 17/20] handsfree-audio: Use bitmask for supported codecs

This patch changes the internal representation of the supported codecs. Codecs are being declared in a sequentialily, represent the supported codecs as bit-field helps to check for supported codecs and in some cases it avoids dupplicated codec entries. --- src/handsfree-audio.c | 42

[RFC v0 19/20] bluetooth: Add define for SCO voice settings

Add defines for SCO voice setting (Air Coding). Air mode Transparent Data shall be supported if wide band speech is supported. --- src/bluetooth.h | 12 1 file changed, 12 insertions(+) diff --git a/src/bluetooth.h b/src/bluetooth.h index af6f02c..f2fd7d5 100644 ---

[RFC v0 20/20] handsfree-audio: Add setting SCO air mode

--- src/handsfree-audio.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index b644b0b..725b81c 100644 --- a/src/handsfree-audio.c +++ b/src/handsfree-audio.c @@ -91,6 +91,16 @@ static inline void clear_bit(int nr, void

Re: [PATCH v0 13/15] handsfree-audio: Return InProgress on Connect

Hi Frederic: On Tue, Mar 12, 2013 at 12:26 PM, Frederic Danis frederic.da...@linux.intel.com wrote: Hello Claudio, On 12/03/2013 13:42, Claudio Takahasi wrote: This patch returns Operation already in progress if there is a pending Handsfree Audio Card Connect method call pending

Re: [RFC v0 02/13] hfp_hf_bluez5: Register handsfree audio driver

Hi Denis: snip if (err 0) { + ofono_handsfree_card_driver_register(card_driver15); I will fix it in the next series. Copy paste error: It is unregister instead of register. g_dbus_unregister_interface(conn, HFP_EXT_PROFILE_PATH,

Re: [RFC v0 11/13] handsfree-audio: Add sending SCO fd

Hi Johan: On Mon, Mar 11, 2013 at 11:55 AM, Johan Hedberg johan.hedb...@gmail.com wrote: Hi Claudio, On Fri, Mar 08, 2013, Claudio Takahasi wrote: This patch adds the call of NewConnection method when the SCO connection is established for HF initiated scenarios. --- src/handsfree-audio.c

[PATCH] hfp_hf_bluez5: Remove duplicated include

--- plugins/hfp_hf_bluez5.c | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 381a541..332dbab 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -46,7 +46,6 @@ #include ofono/netreg.h #include ofono/voicecall.h

[RFC v0 00/13] Add handsfree audio card driver

external-hfp16 Claudio Takahasi (13): handsfree-audio: Add card driver hfp_hf_bluez5: Register handsfree audio driver hfp_hf_bluez5: Add extracting version handsfree-audio: Add version to card driver hfp_hf_bluez5: Pass version to card registration hfp_hf_bluez5: Add version to HFP 1.5

[RFC v0 01/13] handsfree-audio: Add card driver

This patch adds a new handsfree audio driver abstration to allow implementing the connect callbacks and other potential functions specific of each HFP profile version. This approach also avoids including dependency of hfpmodem in handsfree-audio, keeping the service level handling inside the

[RFC v0 02/13] hfp_hf_bluez5: Register handsfree audio driver

This patch registers the Handsfree Audio Card driver for devices compliant with HFP 1.5. --- plugins/hfp_hf_bluez5.c | 29 + 1 file changed, 29 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 381a541..0b9061d 100644 ---

[RFC v0 03/13] hfp_hf_bluez5: Add extracting version

This patch parses and reads the profile Version that comes in the fd dictionary of the NewConnection method. Version is input for Audio Card registration. --- plugins/hfp_hf_bluez5.c | 37 + 1 file changed, 37 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c

[RFC v0 04/13] handsfree-audio: Add version to card driver

--- include/handsfree-audio.h | 4 +++- src/handsfree-audio.c | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/handsfree-audio.h b/include/handsfree-audio.h index 69f5a8e..e99a2dd 100644 --- a/include/handsfree-audio.h +++ b/include/handsfree-audio.h @@ -26,11

[RFC v0 05/13] hfp_hf_bluez5: Pass version to card registration

Informs the HFP version of the remote device when the Audio Card is registered. --- plugins/hfp_hf_bluez5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 56aa7ef..4524e13 100644 --- a/plugins/hfp_hf_bluez5.c +++

[RFC v0 06/13] hfp_hf_bluez5: Add version to HFP 1.5 card driver

--- plugins/hfp_hf_bluez5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 4524e13..00159fa 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -326,6 +326,7 @@ static int card_audio_connect(const char *remote, const

[RFC v0 07/13] core: Add bt_str2ba() to bluetooth.h

This patch adds a utility Bluetooth function to convert Bluetooth address from string to bdaddr_t. --- src/bluetooth.h | 8 src/handsfree-audio.c | 1 + 2 files changed, 9 insertions(+) diff --git a/src/bluetooth.h b/src/bluetooth.h index 1584109..af6f02c 100644 ---

[RFC v0 09/13] handsfree-audio: Add calling connect callback

This patch adds the call of the connect callback implemented in the driver when Connect method of the Audio Card gets called. --- src/handsfree-audio.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index

[RFC v0 08/13] hfp_hf_bluez5: Add HFP 1.5 card connect callback

This patch adds the Audio Card driver connect callback implementation to handle SCO connection requested by the driver. This approach addresses devices compliant with HFP 1.5 --- plugins/hfp_hf_bluez5.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff

[RFC v0 10/13] handsfree-audio: Add connect GIOChannel watch

This patch adds the GIOChannel watch of the SCO socket. For HF initiated connections, when the audio connection is established the reply for the Card Connect method should be sent. --- src/handsfree-audio.c | 43 +++ 1 file changed, 43 insertions(+) diff

[RFC v0 12/13] handsfree-audio: Return an error on Card Connect

Returns NotAvailable error if Connect method of the Handsfree Audio Card gets called and there isn't an agent registered. --- src/handsfree-audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index 6fa8b67..8950347 100644 ---

[RFC v0 11/13] handsfree-audio: Add sending SCO fd

This patch adds the call of NewConnection method when the SCO connection is established for HF initiated scenarios. --- src/handsfree-audio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index f5d0a7b..6fa8b67 100644 ---

[RFC v0 13/13] handsfree-audio: Check agent before sending fd

This patch avoids sending the SCO fd when the connection is established and the agent left the bus. This check covers the scenario when the agent leaves the bus between Connect method call until the callback get called. --- src/handsfree-audio.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v1 0/6] handsfree-audio: Add Agent NewConnection()

Hi Denis: On Mon, Mar 4, 2013 at 7:44 PM, Denis Kenzior denk...@gmail.com wrote: Hi Claudio, On 03/04/2013 02:48 PM, Claudio Takahasi wrote: This patch series moves the SCO connection handling from hfp_hf_bluez5.c to src/handsfree-audio.c, and adds the Agent NewConnection() method call

Re: [PATCH v0 02/10] handsfree-audio: Move SCO to handsfree-audio.c

Hi Denis On Fri, Mar 1, 2013 at 4:20 PM, Denis Kenzior denk...@gmail.com wrote: Hi Claudio, On 02/28/2013 12:52 PM, Claudio Takahasi wrote: This patch moves the SCO socket handling from hfp_hf_bluez5 plugin to handsfree-audio.c file. This is the initial step to be able to support

Re: [PATCH v0 03/10] handsfree-audio: Remove modem dependency

Hi Denis: On Fri, Mar 1, 2013 at 4:29 PM, Denis Kenzior denk...@gmail.com wrote: Hi Claudio, On 02/28/2013 12:52 PM, Claudio Takahasi wrote: This patch replaces the handsfree modem verification by the Audio Card. Audio Cards are created when the RFCOMM fd descriptor is received

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

Hi Denis: On Fri, Mar 1, 2013 at 4:40 PM, Denis Kenzior denk...@gmail.com wrote: Hi Claudio, On 02/28/2013 12:52 PM, Claudio Takahasi wrote: This patch adds a new function to read the local supported Handsfree Profile version. --- include/handsfree-audio.h | 1 + src/handsfree

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

Hi Denis: On Mon, Mar 4, 2013 at 4:30 PM, Denis Kenzior denk...@gmail.com wrote: Hi Marcel, I don't see why not. Both Codec Negotiation and Wide-band speech are labeled optional for HF/AG in Table 3.1. The only note there says: If Wide Band Speech is supported, Codec Negotiation shall

[PATCH v1 0/6] handsfree-audio: Add Agent NewConnection()

and Remove modem dependency * Removed tracking of supported local HFP version in handsfree-audio * Removed ofono_handsfree_get_version() Claudio Takahasi (6): bluetooth: Add new Bluetooth header handsfree-audio: Move SCO to handsfree-audio.c handsfree-audio: Add NewConnection handsfree-audio: Check

[PATCH v1 1/6] bluetooth: Add new Bluetooth header

This patch moves the Bluetooth utility funtions and socket type declarations to a new header src/bluetooth.h, allowing to share it between core, and plugins. --- Makefile.am | 2 +- plugins/bluez5.c| 17 plugins/bluez5.h| 41

[PATCH v1 2/6] handsfree-audio: Move SCO to handsfree-audio.c

This patch moves the SCO socket handling from hfp_hf_bluez5 plugin to handsfree-audio.c file. This is the initial step to be able to support sending the file descriptor through the Agent NewConnection method. This patch replaces the handsfree modem verification by the Audio Card. Audio Cards are

[PATCH v1 3/6] handsfree-audio: Add NewConnection

This patch adds Agent NewConnection call. The card object path, the SCO file descriptor, and the codec are being passed to the agent. This initial version supports CVSD codec only. --- src/handsfree-audio.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff

[PATCH v1 4/6] handsfree-audio: Check local SCO address

This patch verifies if the local Bluetooth address of the incoming connection also matches with one of available audio cards. --- src/handsfree-audio.c | 44 +++- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/src/handsfree-audio.c

[PATCH v1 5/6] handsfree-audio: Reject SCO if Card is not ready

The Audio Card is being created when the NewConnection from BlueZ Profile is received, and registered when the service level connection negotiation finishes. This patch rejects SCO connection if the SCO incoming connection arrives when the service level negotiation is ongoing. ---

[PATCH v1 6/6] handsfree-audio: Reject SCO if agent is unavailable

This patch rejects the incoming SCO connection if there isn't a Handsfree Audio Agent registered. --- src/handsfree-audio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index 857c258..73c6183 100644 --- a/src/handsfree-audio.c +++

[PATCH v3 0/6] hfp_hf_bluez5: Register Audio Cards in handsfree manager

commit message 50/72 formatting * Fixed M1: Blank line before and after an if/while/do/for statement Claudio Takahasi (6): hfp_hf_bluez5: Add registering Audio Card hfp_hf_bluez5: Add local address to Audio Card hfp_hf_bluez5: Remove Card when SLC fails hfp_hf_bluez5: Remove Card if SLC

[PATCH v3 1/6] hfp_hf_bluez5: Add registering Audio Card

This patch registers the Handsfree Audio Card when the service level connection is established. --- plugins/hfp_hf_bluez5.c | 21 + 1 file changed, 21 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 7057d71..87d7e91 100644 ---

[PATCH v3 2/6] hfp_hf_bluez5: Add local address to Audio Card

--- plugins/hfp_hf_bluez5.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 87d7e91..3960d7a 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -323,7 +323,7 @@ static DBusMessage

[PATCH v3 3/6] hfp_hf_bluez5: Remove Card when SLC fails

This patch removes the previously created Audio Card if the service level negotiation fails. --- plugins/hfp_hf_bluez5.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 3960d7a..98cef7c 100644 --- a/plugins/hfp_hf_bluez5.c +++

[PATCH v3 4/6] hfp_hf_bluez5: Remove Card if SLC is disconnected

This patch removes previous registered Audio Card when the remote Bluetooth device triggers the service level disconnection. --- plugins/hfp_hf_bluez5.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 98cef7c..5db7bb8 100644 ---

[PATCH v3 5/6] hfp_hf_bluez5: Remove Card when modem is disabled

--- plugins/hfp_hf_bluez5.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 5db7bb8..d35a20f 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -272,6 +272,9 @@ static int hfp_disable(struct ofono_modem *modem)

[PATCH v3 6/6] hfp_hf_bluez5: Remove Card on RequestDisconnection

For local initiated disconnection the GAtChat disconnect callback is not called. For this case, Audio Card remove function needs to be called. --- plugins/hfp_hf_bluez5.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index

[PATCH v0 00/10] handsfree-audio: Add Agent NewConnection()

This patch series moves the SCO connection handling from hfp_hf_bluez5.c to src/handsfree-audio.c, and adds the Agent NewConnection() method call to pass the SCO file descriptor from oFono to the Agent implementation. Claudio Takahasi (10): bluetooth: Add new Bluetooth header handsfree-audio

[PATCH v0 01/10] bluetooth: Add new Bluetooth header

This patch moves the Bluetooth utility funtions and socket type declarations to a new header src/bluetooth.h, allowing to share it between core, and plugins. --- Makefile.am | 2 +- plugins/bluez5.c| 17 plugins/bluez5.h| 41

[PATCH v0 02/10] handsfree-audio: Move SCO to handsfree-audio.c

This patch moves the SCO socket handling from hfp_hf_bluez5 plugin to handsfree-audio.c file. This is the initial step to be able to support sending the file descriptor through the Agent NewConnection method. --- plugins/hfp_hf_bluez5.c | 102 +--

[PATCH v0 03/10] handsfree-audio: Remove modem dependency

This patch replaces the handsfree modem verification by the Audio Card. Audio Cards are created when the RFCOMM fd descriptor is received, and registered when the service level connetion is established. --- src/handsfree-audio.c | 19 ++- 1 file changed, 6 insertions(+), 13

  1   2   3   4   >