[PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

--- This is needed in order for isimodem2.5 to work. Best Regards, Jessica gisi/common.h |3 + gisi/message.c |8 + gisi/message.h |1 + gisi/modem.c | 105 -- gisi/modem.h |4 + gisi/pipe.c| 433 ++-- 6 f

[PATCH 1/1] src: out of bounds problem in smsutil

--- This one was exposed when wgmodem2.5 CBS was run with valgrind. Best Regards, Jessica Nilsson src/smsutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 5524932..b3a1ba1 100644 --- a/src/smsutil.c +++ b/src/smsutil.c

[PATCH v2 3/3] isimodem: header updates for ISI2.5

--- drivers/isimodem/debug.c | 132 drivers/isimodem/debug.h |9 +++ drivers/isimodem/mtc.h | 38 + drivers/isimodem/version.h | 26 + 4 files changed, 205 insertions(+), 0 deletions(-) create mode 100644 drivers/is

[PATCH v2 2/3] udev: u8500 support and style fix

--- plugins/udev.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index ce1efe6..49b5eb8 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -185,7 +185,8 @@ static void add_hso(struct ofono_modem *modem, devnode = udev_

[PATCH v2 1/3] u8500: add plugin for u8500

--- Makefile.am |4 + plugins/ofono.rules |3 + plugins/u8500.c | 507 +++ 3 files changed, 514 insertions(+), 0 deletions(-) create mode 100644 plugins/u8500.c diff --git a/Makefile.am b/Makefile.am index a38fcb9..4762cc8 1006

[PATCH v2 0/3] ISI modem version detection with plugin

r comments on that one and will send in an update as soon as we can. Best Regards, Jessica Nilsson u8500: add plugin for u8500 udev: u8500 support and style fix isimodem: header updates for ISI2.5 Makefile.am|4 + drivers/isimodem/debug.c | 132 driver

Re: [PATCH 1/1] ISI modem version detection with plugin

view. Do you want them as a 1-3 series patch or should I send each separately? Best Regards, Jessica Nilsson ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 1/1] ISI modem version detection with plugin

e and will send in an update as soon as we can. But we want your comment on this one as well :-) Best Regards, Jessica Nilsson Makefile.am|4 + drivers/isimodem/debug.c | 39 drivers/isimodem/debug.h |4 + drivers/isimodem/mtc.h | 38 drivers/isimodem

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

n. > isimodem2.5 needs this code, the kernel struct won't be applicable for us in the modem case. We will move the pep functions to the pep.c Best Regards, Jessica Nilsson ST-Ericsson ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

think the mail server has been creative, because it was there when I sent it. I'll see if I can change the settings somehow, I'll wait for more comments on the actual code before sending an new patch though, is that ok? Best Regards, Jessica

[PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

--- This is needed in order for isimodem2.5 to work. Best Regards, Jessica Nilsson ST-Ericsson gisi/common.h |3 + gisi/message.c |8 + gisi/message.h |1 + gisi/modem.c | 105 -- gisi/modem.h |4 + gisi/pipe.c| 433

Re: [PATCH 1/1] isimodem: Adding version isimodem and isimodem2.5

Hi, On 01/25/2011 01:39 PM, Aki Niemi wrote: I don't think there is a need for this, as ISI itself already provides both ISI version (which we have available always via the g_isi_client_verify() call), and in many cases also the resource ID as means to find the correct quirk to use. Of course,

[PATCH 1/1 v2] simutil: EF Fileid additions USIM and SIM Phonebook

Also, adding some general fileids for building paths --- Needed for isimodem2.5 patches planned to follow shortly. Best Regards, Jessica src/simutil.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 95bc18f..463540b 100

[PATCH 1/1] isimodem: Adding version isimodem and isimodem2.5

Adding a version enum to differentiate between isimodem2.0 and isimodem2.5. Needed for isimodem2.5 patches planned to follow shortly. Best Regards, Jessica --- drivers/isimodem/isimodem.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/isimodem.h b

[PATCH 1/1] simutil: EF Fileid additions USIM and SIM Phonebook isimodem2.5

Adding EF Fileids for USIM and SIM Phonebook. Also, adding some general fileids for building paths. Needed for isimodem2.5 patches planned to follow shortly. Best Regards, Jessica --- src/simutil.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/simut

Re: isimodem2.5 submit plan

Hi Marcel, so I remember that the agreement was to just quirk the isimodem support to also support the new code. Is that still the case or what is the exact plan here? Yes, that is basically the plan. We just wanted you to get a heads-up on what we are planning and what patches are to come.

isimodem2.5 submit plan

Hi, as you probably remember I sent in some patches containing isimodem2.5 some time ago. After your comments we are now getting ready to send in some updates where we have merged the isimodem with our isimodem2.5 code. This is a preliminary plan on how we propose to sent in the patches. Some

[PATCH 2/2] simutil: sim_fileid sorted in numerical order

--- src/simutil.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index cda9d55..fb87c3a 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -33,14 +33,18 @@ enum sim_fileid { SIM_EF_CPHS_MBDN_FILEID = 0x6f17,

[PATCH 1/2] simutil: M9, M11, Minor style fixes and indentation

--- src/simutil.h | 68 1 files changed, 34 insertions(+), 34 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index ad84907..cda9d55 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -19,36 +19,39 @@ * */ +#define SIM_EFSPN_

Update interface with variable port numbers?

the oma-ilp 7276/tcpOMA Internal Location Protocol specified on http://www.iana.org/assignments/port-numbers This could also be used for other WAP based services. Is this something that you would agree would be useful and we could add to the TODO list? Best Regards, Jessica Nilsson

[PATCH 2/2] simutil: sim_fileid sorted in numerical order

--- src/simutil.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index fd703d1..ad317f3 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -33,14 +33,18 @@ enum sim_fileid { SIM_EF_CPHS_MBDN_FILEID = 0x6f17,

[PATCH 1/2] simutil: Minor style fixes and indentation

--- src/simutil.h | 110 1 files changed, 55 insertions(+), 55 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index ad84907..fd703d1 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -19,36 +19,39 @@ * */ +#define SIM_EFSPN_

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Aki, The CBS topics set is simply not implemented in the current cbs driver. I suggest you create a patch for adding that into the current driver. And same for the clear_topics callback. Yes, I might be able to do that. I can not test it though, I haven't got any isimodem HW. I assu

Re: [PATCH 2/4]simutil: Changes to prepare for isimodem2.5

Hi Marcel, please write a proper commit message here. The subject is not acceptable since it misleads what this patch is doing. +#include "types.h" + What is this include for? Please remove it. So please be consistent with lower-case hex encoding. So 0x6f07 etc. Ok, fix commit me

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

implementing this, we have got a couple of really good review comments from him already. (Thanks also to Mika Liljeberg for suggesting something similar) I guess the question is what will be most efficient and easiest to maintain. Best Regards, Jessica Nilsson

Re: [PATCH 4/4] scripts: Added init.rc script

Hi Marcel, this is not an upstream oFono problem. This is package and distro specific. So I am not taking this patch. Fair enough, my mistake. Best Regards, Jessica ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

split up. Do you have any other suggestions? In addition, I don't a point in a filename. So isimodem25 or isimodem2 or something like that please. I am open for proposals. Let's go for isimodem25 Best Regards, Jessica Nilsson ___ ofo

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

Regards, Jessica Nilsson ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 4/4] scripts: Added init.rc script

Updates in Makefile.am and the adding of an init file. Regards, Jessica Nilsson --- Makefile.am| 10 +++ scripts/ofonod | 79 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 scripts/ofonod diff --git a

[PATCH 2/4]simutil: Changes to prepare for isimodem2.5

updates in src/simutil.h Adding some sim file id and sim dir id mostly related to phonebook usim/sim. Regards, Jessica Nilsson --- src/simutil.h | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 92b2e0f..bc53255

[PATCH 1/4] gisi: Changes to prepare for isimodem2.5

c patch contains updates in Makefile.am, configure.ac and gisi to prepare the addition of isimodem2.5 Added 2 new files to gisi pipe_wg25.c and pipe_wg25.h, isimodem2.5 pipe implementation due to pipe handler not on modem side. Regards, Jessica Nilsson --- Makefile.am |6 + configu