Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

2013-04-25 Thread Johan Hedberg
Hi Mikel, On Thu, Apr 25, 2013, Mikel Astiz wrote: On Tue, Apr 23, 2013 at 7:28 PM, Johan Hedberg johan.hedb...@gmail.com wrote: Hi Marcel, On Tue, Apr 23, 2013, Marcel Holtmann wrote: I don't completely understand the rationale of wanting to make BlueZ's clients so fragile. You

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

2013-04-23 Thread Johan Hedberg
Hi Denis, On Tue, Apr 23, 2013, Denis Kenzior wrote: On 04/22/2013 05:53 PM, Vinicius Costa Gomes wrote: Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

2013-04-23 Thread Johan Hedberg
Hi Marcel, On Tue, Apr 23, 2013, Marcel Holtmann wrote: Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

2013-04-23 Thread Johan Hedberg
Hi Marcel, On Tue, Apr 23, 2013, Marcel Holtmann wrote: I don't completely understand the rationale of wanting to make BlueZ's clients so fragile. You could in theory get new services way after pairing if this is configurable on the remote side. You could also get the result of calling

Re: [PATCH v0 1/7] doc: Add ECNR to Handsfree

2013-04-19 Thread Johan Hedberg
Hi Claudio, On Fri, Apr 19, 2013, Claudio Takahasi wrote: This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to enable or disable this feature in the audio gateway. According to Bluetooth HFP 1.6 spec: By default, if the AG

Re: [RFC v0 11/13] handsfree-audio: Add sending SCO fd

2013-03-11 Thread Johan Hedberg
Hi Claudio, On Fri, Mar 08, 2013, Claudio Takahasi wrote: This patch adds the call of NewConnection method when the SCO connection is established for HF initiated scenarios. --- src/handsfree-audio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/handsfree-audio.c

Re: [RFC v0 01/11] hfp_hf: Add HFP external Profile registration

2012-11-26 Thread Johan Hedberg
Hi Claudio, On Thu, Nov 22, 2012, Claudio Takahasi wrote: +int bluetooth_register_profile(const char *uuid, const char *name, + const char *object) +{ + DBusMessageIter iter, dict; + DBusPendingCall *c; + DBusMessage *msg; +

Re: [RFC v0 01/11] hfp_hf: Add HFP external Profile registration

2012-11-26 Thread Johan Hedberg
Hi Claudio, On Thu, Nov 22, 2012, Claudio Takahasi wrote: +int bluetooth_register_profile(const char *uuid, const char *name, + const char *object) +{ + DBusMessageIter iter, dict; + DBusPendingCall *c; + DBusMessage *msg; +

Re: [RFC v0 00/11] External HFP Profile

2012-11-23 Thread Johan Hedberg
Hi Claudio, On Thu, Nov 22, 2012, Claudio Takahasi wrote: BlueZ supports now external profile registration, see: bluez/doc/profile-api.txt This patch series has the initial implementation of the HFP external profile in oFono. HandsfreeAgent and HandsfreeGateway interfaces were removed from

Re: [RFC v0 00/11] External HFP Profile

2012-11-23 Thread Johan Hedberg
Hi Claudio, On Fri, Nov 23, 2012, Johan Hedberg wrote: On Thu, Nov 22, 2012, Claudio Takahasi wrote: BlueZ supports now external profile registration, see: bluez/doc/profile-api.txt This patch series has the initial implementation of the HFP external profile in oFono. HandsfreeAgent

Re: [RFC v0 00/11] External HFP Profile

2012-11-23 Thread Johan Hedberg
Hi Claudio, On Thu, Nov 22, 2012, Claudio Takahasi wrote: BlueZ supports now external profile registration, see: bluez/doc/profile-api.txt This patch series has the initial implementation of the HFP external profile in oFono. HandsfreeAgent and HandsfreeGateway interfaces were removed from

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-26 Thread Johan Hedberg
Hi Denis, On Thu, Nov 25, 2010, Denis Kenzior wrote: Right. At least for HFP the call direction needs to be in the AT+CLCC reply. I.e. if the bluetoothd ofono telephony driver is used and bluetoothd starts after one or more calls are already in progress bluetoothd wouldn't have seen the

[PATCH] Fix string array memory leaks during plugin loading

2010-10-27 Thread johan . hedberg
From: Johan Hedberg johan.hedb...@nokia.com --- src/plugin.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/plugin.c b/src/plugin.c index 68fe318..7c0652b 100644 --- a/src/plugin.c +++ b/src/plugin.c @@ -176,6 +176,9 @@ int __ofono_plugin_init(const char *pattern

Re: [PATCH] Add send_method_call to g_dbus

2010-04-27 Thread Johan Hedberg
Hi, On Tue, Apr 27, 2010, Marcel Holtmann wrote: +gboolean g_dbus_send_method_call(DBusConnection *connection, const char *dest, + const char *path, const char *interface, + const char *method, int type, ...); +gboolean

Re: [RFC] HFP support into oFono and BlueZ

2010-01-21 Thread Johan Hedberg
0002-Implement-HandsfreeGateway-Interface.patch Description: Binary data ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [RFC] HFP support into oFono and BlueZ

2010-01-21 Thread Johan Hedberg
Hi Gustavo, Sorry, not only did I manage not to quote the original patch properly but the mime-type in my mail was scrwed up. Here's a second try: = Sorry about the delay in getting more comments from me. Here's the result of an initial (and rather quick) review: +static const

Re: [RFC] HFP support into oFono and BlueZ

2010-01-19 Thread Johan Hedberg
Hi Denis, On Sun, Jan 17, 2010, Denis Kenzior wrote: having it as a MediaEndpoint I guess it is probably a good idea to have a similar design as we will have in endpoints, so the registration actually happen in adapter path rather than device path, which probably should avoid the having

Re: [RFC] HFP support into oFono and BlueZ

2010-01-19 Thread Johan Hedberg
Hi Luiz, On Tue, Jan 19, 2010, Luiz Augusto von Dentz wrote: Also the problem with this being in the device path is that ofono may not be registered as an agent on connect (both ways) which will cause the connection to drop and the round trips to resolve device path only makes it worse, if