[PATCH phonesim 7/7] Replace uneccessary uses of QTextCodec to convert to unicode

--- src/conformancesimapplication.cpp | 17 ++--- src/simapplication.cpp| 3 +-- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/src/conformancesimapplication.cpp b/src/conformancesimapplication.cpp index ae2f1a9..8b3c466 100644 ---

[PATCH phonesim 6/7] Port to Qt 6

--- CMakeLists.txt | 10 +++--- src/CMakeLists.txt | 6 +- src/control.cpp | 8 +++- src/hardwaremanipulator.cpp | 1 - src/phonesim.cpp| 2 +- src/qsimcommand.cpp | 2 +- src/qwsppdu.cpp | 12 ++-- 7 files

[PATCH phonesim 5/7] qwsppdu: Port QDateTime deprecations

--- src/qwsppdu.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/qwsppdu.cpp b/src/qwsppdu.cpp index 897bac8..d636b5c 100644 --- a/src/qwsppdu.cpp +++ b/src/qwsppdu.cpp @@ -448,7 +448,11 @@ QDateTime QWspDateTime::fromGmtTime_t(quint32 t) */ quint32

[PATCH phonesim 4/7] Update README

--- README| 20 README.md | 24 2 files changed, 24 insertions(+), 20 deletions(-) delete mode 100644 README create mode 100644 README.md diff --git a/README b/README deleted file mode 100644 index 07dd800..000 --- a/README +++ /dev/null @@

[PATCH phonesim 2/7] Use quotes to include local header files

Co-authored-by: Alexander Akulich --- src/aidapplication.cpp| 4 ++-- src/callmanager.cpp | 4 ++-- src/conformancesimapplication.cpp | 2 +- src/control.h | 2 +- src/hardwaremanipulator.cpp | 14 +++--- src/main.cpp

[PATCH phonesim 3/7] Remove autotools build system

--- INSTALL | 236 Makefile.am | 79 --- bootstrap | 3 - bootstrap-configure | 9 -- configure.ac| 49 - 5 files changed, 376 deletions(-) delete mode 100644 INSTALL delete mode 100644

[PATCH phonesim 1/7] Add CMake build system

--- CMakeLists.txt | 20 src/CMakeLists.txt | 40 2 files changed, 60 insertions(+) create mode 100644 CMakeLists.txt create mode 100644 src/CMakeLists.txt diff --git a/CMakeLists.txt b/CMakeLists.txt new file mode 100644 index

Adding support for building phonesim with Qt 6

the installer installs Qt 6 to a custom prefix, it is necessary to pass it to cmake, like this: cmake -DCMAKE_PREFIX_PATH=~/.local/Qt/6.0.1/gcc_64 (Assuming ~/.local/Qt was choosen as install destination) Yours sincerely, Jonah Brüchert ___ ofono

[PATCH phonesim 03/13] Port old-style connects

* Update CXX Standard to 14 to be able to use qOverload() --- configure.ac| 4 +-- src/callmanager.cpp | 22 ++--- src/control.cpp | 77 + src/phonesim.cpp| 56 + src/phonesim.h | 3 +- 5

[PATCH phonesim 10/13] Port from c-style casts to static_cast<>()

Done using the google-readability-casting check of clang-tidy --- src/callmanager.cpp | 6 +- src/hardwaremanipulator.cpp | 12 +- src/phonesim.cpp | 62 +++--- src/qatresult.cpp| 10 +- src/qatresultparser.cpp | 6 +- src/qatutils.cpp |

[PATCH phonesim 09/13] Require Qt5Widgets >= 5.10

I don't think it's possible to use preprocessor directives with Qt's ui files, so this is neccessary. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 0587f9f..da87afe 100644 --- a/configure.ac +++ b/configure.ac @@ -22,7

[PATCH phonesim 06/13] qwsppdu: Port to QLocale

--- src/qwsppdu.cpp | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qwsppdu.cpp b/src/qwsppdu.cpp index 26f450d..f3a1661 100644 --- a/src/qwsppdu.cpp +++ b/src/qwsppdu.cpp @@ -18,13 +18,15 @@

[PATCH phonesim 12/13] Annotate overriding functions with override

* Allows us to notice when a function becomes source incompatible in a Qt major release, and our implementation stops overriding. --- src/aidapplication.cpp | 3 ++- src/aidapplication.h| 4 ++-- src/callmanager.h | 2 +- src/control.h | 18

[PATCH phonesim 13/13] Use bool literals

Done using the modernize-use-bool-literals of clang-tidy --- src/qsmsmessage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qsmsmessage.cpp b/src/qsmsmessage.cpp index 1d0f733..06845bf 100644 --- a/src/qsmsmessage.cpp +++ b/src/qsmsmessage.cpp @@ -1565,7 +1565,7 @@

[PATCH phonesim 07/13] Port away from Q_FOREACH

--- src/aidapplication.cpp | 4 ++-- src/callmanager.cpp | 6 +++--- src/control.cpp | 19 +-- src/hardwaremanipulator.cpp | 4 ++-- src/phonesim.cpp| 4 ++-- src/qsimcommand.cpp | 10 +- src/simfilesystem.cpp | 8

[PATCH phonesim 08/13] Port deprecations in controlbase.ui

--- src/controlbase.ui | 158 - 1 file changed, 142 insertions(+), 16 deletions(-) diff --git a/src/controlbase.ui b/src/controlbase.ui index 4eb1355..c2acbf6 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -17,7 +17,16 @@ 6

[PATCH phonesim 11/13] Use dynamic_cast where appropriate

Done using the cppcoreguidelines-pro-type-cstyle-cast check of clang-tidy --- src/aidapplication.cpp | 2 +- src/phonesim.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/aidapplication.cpp b/src/aidapplication.cpp index 16fef0c..807d7f9 100644 ---

[PATCH phonesim 04/13] Replace QtScript with QtQml

--- configure.ac| 2 +- src/control.cpp | 18 +- src/control.h | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 5cc4545..0587f9f 100644 --- a/configure.ac +++ b/configure.ac @@ -22,7 +22,7 @@

[PATCH phonesim 05/13] Port away from some deprecated Qt apis

--- src/qsimcommand.cpp| 4 src/qsmsmessage.cpp| 4 src/qwsppdu.cpp| 4 ++-- src/simapplication.cpp | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/qsimcommand.cpp b/src/qsimcommand.cpp index 672ffb9..6642035 100644 --- a/src/qsimcommand.cpp

[PATCH phonesim 01/13] Use nullptrs

Done using the modernize-use-nullptr check of clang-tidy --- src/aidapplication.h | 2 +- src/callmanager.h | 2 +- src/conformancesimapplication.cpp | 2 +- src/control.cpp | 2 +- src/control.h | 2 +- src/gsmspec.cpp

Modernize phonesim codebase

Dear maintainers, as mentioned earlier I'm now sending the remaining patches to ofono phonesim. I tried to split them up logically and to explain them in their descriptions. If anything is still unclear, please ask. Overall the patchset fixes all compiler warnings that appear with the

[PATCH phonesim 02/13] Replace deprecated headers

Done using the modernize-deprecated-headers check of clang-tidy --- src/main.cpp| 2 +- src/phonesim.h | 6 +++--- src/qsmsmessage.cpp | 2 +- src/qwsppdu.cpp | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index b320140..712e767

Re: [PATCH phonesim v3 1/2] Port to qt5

, Jonah Brüchert wrote: From: Simon Busch Co-authored-by: Martin Jansa Co-authored-by: Jonah Brüchert Co-authored-by: Alexander Akulich ---   Makefile.am |  4 +++-   configure.ac    | 15 ---   src/control.cpp |  4 ++--   src/phonesim.cpp    |  2 +-   src/phonesim.h

[PATCH phonesim v3 1/2] Port to qt5

From: Simon Busch Co-authored-by: Martin Jansa Co-authored-by: Jonah Brüchert Co-authored-by: Alexander Akulich --- Makefile.am | 4 +++- configure.ac| 15 --- src/control.cpp | 4 ++-- src/phonesim.cpp| 2 +- src/phonesim.h | 2 +- src

[PATCH phonesim v3 2/2] Use override at least in server header

From: Alexander Akulich --- src/server.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/server.h b/src/server.h index 3342a90..9175359 100644 --- a/src/server.h +++ b/src/server.h @@ -32,15 +32,15 @@ class HardwareManipulatorFactory; class PhoneSimServer : public

Re: [PATCH phonesim v2 1/8] Port to qt5

the affected patches used them. If you want I can squash them together and group the changes into a commit by content, not by author. Am 29.10.19 um 17:06 schrieb Denis Kenzior: Hi Jonah, On 10/27/19 11:30 AM, Jonah Brüchert wrote: From: Simon Busch Signed-off-by: Simon Busch Signed-off

[PATCH phonesim v2 7/8] Fix Qt5 port on 64-bit platforms

From: Alexander Akulich --- src/phonesim.cpp | 2 +- src/phonesim.h | 2 +- src/server.cpp | 2 +- src/server.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/phonesim.cpp b/src/phonesim.cpp index 0e446f6..f14281b 100644 --- a/src/phonesim.cpp +++

[PATCH phonesim v2 2/8] Fix random build failure

From: Martin Jansa uic and moc doesn't create output directory automatically and it could be missing when uic is executed before gcc creates any object files as src/*.o OE @ ~/build/wpb/webos-ports/tmp-glibc/work/i586-webos-linux/phonesim/1.20-r0/build $ rm -rf src/ OE @

[PATCH phonesim v2 8/8] Use override at least in server header

From: Alexander Akulich --- src/server.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/server.h b/src/server.h index 3342a90..9175359 100644 --- a/src/server.h +++ b/src/server.h @@ -32,15 +32,15 @@ class HardwareManipulatorFactory; class PhoneSimServer : public

[PATCH phonesim v2 3/8] configure.ac: use gnu++11 to fix build with Qt 5.7

From: Martin Jansa Signed-off-by: Martin Jansa --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 253aa27..4eb969a 100644 --- a/configure.ac +++ b/configure.ac @@ -24,6 +24,10 @@ AC_ARG_ENABLE(optimization,

[PATCH phonesim v2 6/8] Make Qt detect fPIC flag correctly

--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 59fb421..74cf657 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,7 +46,7 @@ nodist_src_phonesim_SOURCES = src/ui_controlbase.h \ src_phonesim_LDADD = $(QT_LIBS) -AM_CXXFLAGS =

[PATCH phonesim v2 4/8] Fix build with Qt 5.8

From: Martin Jansa ../phonesim-1.20/src/qsmsmessage.cpp: In member function 'QCBSMessage QCBSDeliverMessage::unpack(QTextCodec*)': ../phonesim-1.20/src/qsmsmessage.cpp:2598:40: error: ambiguous overload for 'operator==' (operand types are 'QCharRef' and 'char')

[PATCH phonesim v2 1/8] Port to qt5

From: Simon Busch Signed-off-by: Simon Busch Signed-off-by: Martin Jansa --- Makefile.am | 2 +- configure.ac| 6 +++--- src/control.cpp | 4 ++-- src/qsimcommand.cpp | 2 +- src/qsmsmessage.cpp | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git

Port ofono-phonesim to Qt5

This is a revised set of patches including Alexander's patches, which replace one of my own patches. ___ ofono mailing list -- ofono@ofono.org To unsubscribe send an email to ofono-le...@ofono.org

[PATCH phonesim v2 5/8] configure.ac: fix checking for host_bins variable

From: Martin Jansa $PKG_CONFIG --variable=host_bins Qt5Core returns absolute path without the prefix to sysroot when cross compiling Before https://github.com/meta-qt5/meta-qt5/commit/b716195f609de6547cfdfadfd4fd25292a6bbf09 this will return: pkg-config --variable=host_bins Qt5Core

Re: Port ofono-phonesim to Qt5

platforms. [1] https://github.com/Kaffeine/phonesim/commits/upstreaming [2] https://github.com/Kaffeine/phonesim/commit/33ce5700c6352db731ec6859fdd1fdefc6671e16 On Sun, Oct 27, 2019 at 3:11 AM Jonah Brüchert wrote: The proper url is of course https://layers.openembedded.org/layerindex/recipe

Re: Port ofono-phonesim to Qt5

The proper url is of course https://layers.openembedded.org/layerindex/recipe/32381/. Sorry for the truncated one in the first mail. ___ ofono mailing list -- ofono@ofono.org To unsubscribe send an email to ofono-le...@ofono.org

[PATCH phonesim 3/7] configure.ac: use gnu++11 to fix build with Qt 5.7

From: Martin Jansa Signed-off-by: Martin Jansa --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 253aa27..4eb969a 100644 --- a/configure.ac +++ b/configure.ac @@ -24,6 +24,10 @@ AC_ARG_ENABLE(optimization,

[PATCH phonesim 7/7] Fix handling of incoming connections

The function has changed from: void incomingConnection(int s) to: void incomingConnection(qintptr s) in Qt5 See https://doc.qt.io/qt-5/sourcebreaks.html#changes-to-qt-network This caused our implementation of incomingConnection() of QTcpServer not to be called anymore. --- src/server.cpp | 2 +-

Port ofono-phonesim to Qt5

Dear ofono maintainers, This is the minimal set of patches required to port ofono phonesim to Qt5, based on previous work from openembedded (https://layers.openembedded.org/layerindex/recipe The original patches from openembedded have been preserved in order to keep authorship information. In

[PATCH phonesim 5/7] configure.ac: fix checking for host_bins variable

From: Martin Jansa $PKG_CONFIG --variable=host_bins Qt5Core returns absolute path without the prefix to sysroot when cross compiling Before https://github.com/meta-qt5/meta-qt5/commit/b716195f609de6547cfdfadfd4fd25292a6bbf09 this will return: pkg-config --variable=host_bins Qt5Core

[PATCH phonesim 2/7] Fix random build failure

From: Martin Jansa uic and moc doesn't create output directory automatically and it could be missing when uic is executed before gcc creates any object files as src/*.o OE @ ~/build/wpb/webos-ports/tmp-glibc/work/i586-webos-linux/phonesim/1.20-r0/build $ rm -rf src/ OE @

[PATCH phonesim 4/7] Fix build with Qt 5.8

From: Martin Jansa ../phonesim-1.20/src/qsmsmessage.cpp: In member function 'QCBSMessage QCBSDeliverMessage::unpack(QTextCodec*)': ../phonesim-1.20/src/qsmsmessage.cpp:2598:40: error: ambiguous overload for 'operator==' (operand types are 'QCharRef' and 'char')

[PATCH phonesim 1/7] Port to qt5

From: Simon Busch Signed-off-by: Simon Busch Signed-off-by: Martin Jansa --- Makefile.am | 2 +- configure.ac| 6 +++--- src/control.cpp | 4 ++-- src/qsimcommand.cpp | 2 +- src/qsmsmessage.cpp | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH phonesim 6/7] Make Qt detect fPIC flag correctly

--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 59fb421..74cf657 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,7 +46,7 @@ nodist_src_phonesim_SOURCES = src/ui_controlbase.h \ src_phonesim_LDADD = $(QT_LIBS) -AM_CXXFLAGS =