RE: [PATCH 1/3] ifx: integration of kernel mux (n_gsm) and its line discipline

Hi Marcel, > Hi Guillaume, > > > > > diff --git a/plugins/ifx.c b/plugins/ifx.c > > > > index 527a8c4..9c2a5c1 100644 > > > > --- a/plugins/ifx.c > > > > +++ b/plugins/ifx.c > > > > @@ -26,8 +26,12 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > #include >

RE: [PATCH 1/3] ifx: integration of kernel mux (n_gsm) and its line discipline

Hi Marcel, > Hi Lucas, > > > diff --git a/plugins/ifx.c b/plugins/ifx.c > > index 527a8c4..9c2a5c1 100644 > > --- a/plugins/ifx.c > > +++ b/plugins/ifx.c > > @@ -26,8 +26,12 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > +#include > > +#include

RE: [PATCH 3/3] ifx: fix issue with closing of DLC_AUX tty channel

Hi Marcel, > Hi Guillaume, > > > Using kernel mux, a recursive locking is detected. This issue is > > due to the fact that the DLC_AUX is not closed by ofono. This is > > not done because the shutdown_device() function in charge of it > > is called in the context of an AT callback function and fo

[PATCH 2/3] ifxmodem: integration of kernel mux (n_gsm)

From: Guillaume Lucas --- drivers/ifxmodem/gprs-context.c | 95 +-- 1 files changed, 91 insertions(+), 4 deletions(-) diff --git a/drivers/ifxmodem/gprs-context.c b/drivers/ifxmodem/gprs-context.c index 2c68b44..0d133f9 100644 --- a/drivers/ifxmodem/gprs-co

[PATCH 1/3] ifx: integration of kernel mux (n_gsm) and its line discipline

From: Guillaume Lucas --- plugins/ifx.c | 83 1 files changed, 65 insertions(+), 18 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 527a8c4..9c2a5c1 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -26,8 +26,12 @@ #inclu

[PATCH 3/3] ifx: fix issue with closing of DLC_AUX tty channel

From: Guillaume Lucas Using kernel mux, a recursive locking is detected. This issue is due to the fact that the DLC_AUX is not closed by ofono. This is not done because the shutdown_device() function in charge of it is called in the context of an AT callback function and for an AT sent in this sa

[PATCH 0/3] integration of kernel mux (n_gsm) and its line discipline

Hi, Following set of patch adds support of the kernel mux (n_gsm) for the ifx modem. They were tested with the latest version of the kernel mux who is currently under submission. Following tests were performed (and pass): - PDP context activation/deactivation back-to-back (x15)

[PATCH] simfs: fix GLib-CRITICAL issue occuring when there is no SIM card.

From: Guillaume Lucas During modem release, when there is no SIM card, a GLib-CRITICAL issue occurs during the free of the sim fs context. --- src/simfs.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/src/simfs.c b/src/simfs.c index 3a97a10..

[PATCH] test-stk: update STK test script for conformance

From: Guillaume Lucas Update the STK test script to be able to use it for conformance test. Using 'agent' as parameter the script will now register a STK agent to be able to handle unsolicited proactive command. Without any parameter or with 'menu' the script will try to display the STK main menu

RE: [PATCH] test: add a script for STK conformance tests

Hi Denis, > -Original Message- > From: Denis Kenzior [mailto:denk...@gmail.com] > Sent: Friday, December 17, 2010 4:32 PM > To: ofono@ofono.org > Cc: Lucas, GuillaumeX > Subject: Re: [PATCH] test: add a script for STK conformance tests > > Hi Guillaume, > >

[PATCH] test: add a script for STK conformance tests

From: Guillaume Lucas To be able to run STK conformance tests at ofono level, we need to have a STK agent registered. The test-stk-conformance script provided here do that. This script is for conformance so all the data input of the agent are displayed to be able to check them. The existing test-

RE: [RFC PATCH] stk: add support of next action for menu

Hi Denis, > -Original Message- > From: Denis Kenzior [mailto:denk...@gmail.com] > Sent: Friday, December 10, 2010 6:00 PM > To: ofono@ofono.org > Cc: Lucas, GuillaumeX > Subject: Re: [RFC PATCH] stk: add support of next action for menu > > Hi Guillaume, > >

[RFC PATCH] stk: add support of next action for menu

From: Guillaume Lucas According to the 3GPP 31.124 the support of next action in SIM toolkit menus is mandatory. --- doc/stk-api.txt|5 +++-- src/stk.c |6 ++ src/stkagent.c |6 -- src/stkagent.h |1 + test/test-stk-menu |6 +++--- 5 files changed

[PATCH] stk: fix issue to avoid null pointer for alpha_id

From: Guillaume Lucas If a SET UP CALL proactive command with no alpha identifier occurs, the alpha_id pointer will be set to NULL. This will generate a crash in the stkagent with dbus function. To avoid this we use an empty string if the alpha identifier is not present in the command. --- src/s

RE: [PATCH] stkutil: fix crash issue cause by null length of text string

Hi > > On 7 December 2010 22:55, wrote: > > Hi Guillaume, > > > >> > >> According to 3GPP TS 31.124 a null length for the text string > >> should be allowed. An empty string must be returned to the > >> user in this case. > >> --- > >>  src/stkutil.c |    6 -- > >>  1 files changed, 4 inser

[PATCH] stkutil: fix crash issue cause by null length of text string

From: Guillaume Lucas According to 3GPP TS 31.124 a null length for the text string should be allowed. An empty string must be returned to the user in this case. --- src/stkutil.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index a2

[PATCH] stk: Add busy error for the display text command

From: Guillaume Lucas According to the sequence 1.2 of the ETSI TS 102 384 a busy screen error should be returns for the display text proactive command when the ME is not able to display the text. --- doc/stk-api.txt |1 + src/stk.c | 15 +++ src/stkagent.c | 12 ++

RE: [PATCH] stk: Add busy error for the display text command

Hi Denis, > -Original Message- > From: Denis Kenzior [mailto:denk...@gmail.com] > Sent: Tuesday, November 30, 2010 1:25 PM > To: ofono@ofono.org > Cc: Lucas, GuillaumeX > Subject: Re: [PATCH] stk: Add busy error for the display text command > > Hi Guillaume,

RE: [PATCH] stk: Add busy error for the display text command

Hi Andrzej > > Hi Guillaume, > > On 25 November 2010 09:44, Lucas, GuillaumeX > wrote: > > From: Guillaume Lucas > > > > According to the sequence 1.2 of the ETSI TS 102 384 a busy > > screen error type must be returned for the display text > > pro

[PATCH] stkutil: Use sms_dcs_decode to retrieve the STK character set.

From: Guillaume Lucas --- src/stkutil.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 377ceff..78efbf0 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -77,9 +77,13 @@ struct gsm_sms_tpdu { static char *decode_text(unsig

[PATCH] stk: Add busy error for the display text command

From: Guillaume Lucas According to the sequence 1.2 of the ETSI TS 102 384 a busy screen error type must be returned for the display text proactive command when the message is not urgent and if the ME is not able to display the text. --- doc/stk-api.txt |1 + src/stk.c |7 +++

RE: STK DisplayText changes proposal

Hi Andrew, > > On 23 November 2010 18:08, Denis Kenzior wrote: > > On 11/23/2010 10:55 AM, Andrzej Zaborowski wrote: > >> As for the clear after delay flag, there's a check for it in > >> display_text_cb (line 1248).  As far as I can make out the only > >> difference is the response sent to the

RE: [PATCH] stkutil: mask the DCS value to keep only the intersting bits

Hi Denis, > > Hi Guillaume, > > >>> - switch (dcs) { > >>> + switch (dcs & 0x06) { > >> > >> Do you mean to bitwise and with 0xc here? Otherwise you break the > UCS2 > >> case. Also do any SIMs use the '' Coding Bits Entry entry from > >> 23.038 Section 4? If so, then we need to use sms_d

STK DisplayText changes proposal

Hi, According to the 3GPP specifications there is some missing points in the SATK DisplayText implementation and I want to propose some API changes here. 1. clear message after delay / wait for user to clear flag This flag corresponds to the bit 8 of the command qualifier (see ETSI TS 102 223)

RE: [PATCH] stkutil: mask the DCS value to keep only the intersting bits

Hi Denis, > > Hi Guillaume, > > On 11/15/2010 08:17 AM, Lucas, GuillaumeX wrote: > > From: Guillaume Lucas > > > > For SIM tool kit only the bits 2 and 3 are interesting > > for the DCS value. The others ones sould be masked. The > > masking is necess

[PATCH] stkutil: mask the DCS value to keep only the intersting bits

From: Guillaume Lucas For SIM tool kit only the bits 2 and 3 are interesting for the DCS value. The others ones sould be masked. The masking is necessary because some SIM car set the upper bits to 1. --- src/stkutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/

RE: [PATCH] sim: use mask for check of sim file status

Hi Denis, I've tested your changes and all is ok :) Regards, Guillaume -Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, November 05, 2010 3:17 PM To: ofono@ofono.org Cc: Lucas, GuillaumeX Subject: Re: [PATCH] sim: use mask for check of sim file statu

[PATCH] sim: use mask for check of sim file status

From: Guillaume Lucas Is' the first bit of the sim file status who indicates if a file is valid or not. So a mask must be used to check this. --- src/sim.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sim.c b/src/sim.c index 02ab329..2ee2b29 100644 --- a/src/si