Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-12-01 Thread Pekka Pessi
Hi Marcel, 2010/11/29 Marcel Holtmann : > Only because someone wants to shoehorn this into something nasty, > doesn't mean we should do it. I'd say it fits with oFono's overall strategy of following 27.007 whenever possible. >And I am not going to scarifies the > simplicity of the oFono D-Bus AP

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Remi.Denis-Courmont
- Message d'origine - > do me a favor and try not to break the threading next time. When I am away from my laptop, I use whatever MUA I can. This is obviously not deliberate a choice. > I am getting a bit sick of this secrecy. oFono is for all intense and > purposes open source. And I a

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Marcel Holtmann
Hi Aki, > > I am getting a bit sick of this secrecy. oFono is for all intense and > > purposes open source. So if you want a proper discussion here then > > please list the AT command in question. > > So this patch seems to be to enable reporting call direction as part > of reporting call status

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Aki Niemi
Hi Marcel, 2010/11/30 Marcel Holtmann : > I am getting a bit sick of this secrecy. oFono is for all intense and > purposes open source. So if you want a proper discussion here then > please list the AT command in question. So this patch seems to be to enable reporting call direction as part of re

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Marcel Holtmann
Hi Remi, do me a favor and try not to break the threading next time. > > > * At Nokia, we also have some non-standard commands for internal use. > > > * Some operators require some funky AT commands of their own. It might > > not be > > > possible to open-source them, even if we want to. > > > >

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Remi.Denis-Courmont
- Message d'origine - > > * AT+CPBR and friends is hooked to the phonebook, which is Qt-based, > and > > therefore inadequate inside oFono. > > I am not buying into the AT+CPBR for the local and user specific > phonebook. That one is inside Tracker anyway and also inside the user > session.

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-29 Thread Marcel Holtmann
Hi Remi, > > > This becomes a problem if we have more than one application "managing" > > > voice calls. And I expect that will _be_ the most common case. You have > > > the main call UI, but you also have the Bluetooth headset/carkit, the > > > USB AT commands port, and possibly some third party

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-26 Thread Rémi Denis-Courmont
On Thursday 25 November 2010 10:23:10 ext Johan Hedberg, you wrote: > > This becomes a problem if we have more than one application "managing" > > voice calls. And I expect that will _be_ the most common case. You have > > the main call UI, but you also have the Bluetooth headset/carkit, the > > US

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-26 Thread Johan Hedberg
Hi Denis, On Thu, Nov 25, 2010, Denis Kenzior wrote: > > Right. At least for HFP the call direction needs to be in the AT+CLCC > > reply. I.e. if the bluetoothd ofono telephony driver is used and > > bluetoothd starts after one or more calls are already in progress > > bluetoothd wouldn't have see

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-25 Thread Johan Hedberg
Hi, On Thu, Nov 25, 2010, Rémi Denis-Courmont wrote: > > > + boolean Originated [readonly] > > > + > > > + Indicates whether the call was mobile-originated > > > + (true) or mobile-terminated (false). > > > + > > > > What use case are you trying to enable w

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-24 Thread Rémi Denis-Courmont
On Wednesday 24 November 2010 23:31:43 ext Denis Kenzior, you wrote: > Hi Rémi, > > > + boolean Originated [readonly] > > + > > + Indicates whether the call was mobile-originated > > + (true) or mobile-terminated (false). > > + > > What use case are y

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-24 Thread Denis Kenzior
Hi Rémi, > + boolean Originated [readonly] > + > + Indicates whether the call was mobile-originated > + (true) or mobile-terminated (false). > + What use case are you trying to enable with this API? I don't see how this could be useful for the

[PATCH] Add voice call boolean property for MO/MT distinction

2010-11-24 Thread Rémi Denis-Courmont
--- doc/voicecall-api.txt |5 + src/voicecall.c |6 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt index f0ba316..f3cad7c 100644 --- a/doc/voicecall-api.txt +++ b/doc/voicecall-api.txt @@ -87,6 +87,11 @@ Proper