RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
Hi Marcel: > it is a false positive. > > The only caller that uses the cond value is sim_set_cf_indicator. And it > only uses conf if the return value is TRUE. So where can this go wrong? You are right. I will ask MeeGo tool chain guy to resolve it. > Marcel > > > ___

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Marcel Holtmann
Hi Martin, > > > src/call-forwarding.c |2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/src/call-forwarding.c b/src/call-forwarding.c > > > index 512f223..36ba4f1 100644 > > > --- a/src/call-forwarding.c > > > +++ b/src/call-forwarding.c > > > @@ -246,7 +

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
> -Original Message- > From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf > Of Marcel Holtmann > Sent: Friday, January 07, 2011 1:45 AM > To: ofono@ofono.org > Subject: Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo >

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Marcel Holtmann
Hi Martin, > src/call-forwarding.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/call-forwarding.c b/src/call-forwarding.c > index 512f223..36ba4f1 100644 > --- a/src/call-forwarding.c > +++ b/src/call-forwarding.c > @@ -246,7 +246,7 @@ static gboolean is_cfu

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Lucas De Marchi
On Thu, Jan 6, 2011 at 7:54 AM, Xu, Martin wrote: > Using the old version of gcc 4.4.2 I did not meet the issue, but using 4.5.1, > we have warning. Humn, gcc 4.5.2 here and I don't get the warning. IMHO, this warning doesn't make sense. Lucas De Marchi

[PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread martin . xu
From: Martin Xu --- src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static gboolean is_cfu_enabl

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
> -Original Message- > From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf > Of Sjur Br?ndeland > Sent: Thursday, January 06, 2011 5:49 PM > To: ofono@ofono.org > Cc: blutolan (none) > Subject: Re: [PATCH] Fix compile warning at MeeGo The gcc ver

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
Using the old version of gcc 4.4.2 I did not meet the issue, but using 4.5.1, we have warning. > -Original Message- > From: Xu, Martin > Sent: Thursday, January 06, 2011 5:46 PM > To: ofono@ofono.org > Cc: Xu, Martin; blutolan > Subject: [PATCH] Fix compile warnin

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Sjur Brændeland
Hi Martin. On Thu, Jan 6, 2011 at 10:46 AM, wrote: > From: blutolan Your git-config is wrong, you need to set name and email right in your git-config before committing. Regards, Sjur ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/list

[PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread martin . xu
From: blutolan --- src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static gboolean is_cfu_enable