Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, But it seems to me the gprs context will be pass to modem plugins, so we need to set the vendor code for Huawei modems, because it sends unquoted strings. No, you don't. You are confusing gprs atom and the gprs-context atom. Grep for VENDOR in drivers/atmodem/gprs-context.c if you

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Denis, No, you don't. You are confusing gprs atom and the gprs-context atom. Grep for VENDOR in drivers/atmodem/gprs-context.c if you do not believe me. There is no vendor specific code in the atmodem gprs-context driver. Yes, my bad, I misunderstood the program flow... So, is

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, On 12/11/2010 10:37 AM, Tonny Tzeng wrote: Hi Denis, No, you don't. You are confusing gprs atom and the gprs-context atom. Grep for VENDOR in drivers/atmodem/gprs-context.c if you do not believe me. There is no vendor specific code in the atmodem gprs-context

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, Tonny Tzeng tonny.tz...@gmail.com writes: --- plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Your commit log is empty. The most important part of the commit log is to answer the question Why? and this patch really would need that answer. What's

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..32cf70d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -454,7 +454,7 @@ static void huawei_disconnect(gpointer user_data)

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, On 12/03/2010 09:22 AM, Tonny Tzeng wrote: --- plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..32cf70d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -454,7 +454,7 @@

[PATCH] Specify vendor ID for Huawei modem while creating GPRS context

--- plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..32cf70d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -454,7 +454,7 @@ static void huawei_disconnect(gpointer user_data)