RE: [PATCH] ifx: adding Infineon modem self test

2010-12-12 Thread Bastian, Waldo
The conclusion was that these two test commands should be issued from the AP to ensure that the modem is functioning properly. I am not aware of the conclusion. My understanding is still that the modem firmware is suppose to do its selftests all by itself. It does not. So what is the

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-12 Thread Marcel Holtmann
Hi Waldo, The conclusion was that these two test commands should be issued from the AP to ensure that the modem is functioning properly. I am not aware of the conclusion. My understanding is still that the modem firmware is suppose to do its selftests all by itself. It does not.

Re: [PATCH] ifx: adding Infineon modem self test

2010-12-12 Thread Marcel Holtmann
Hi Robertino, static const char *none_prefix[] = { NULL }; static const char *xdrv_prefix[] = { +XDRV:, NULL }; +static const char *empty_prefix[] = { , NULL }; this is essentially to just passing NULL as argument. What are you trying to achieve here? +static const char

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-11 Thread Bastian, Waldo
Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the modem executes these.

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-11 Thread Marcel Holtmann
Hi Waldo, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the

[PATCH] ifx: adding Infineon modem self test

2010-12-10 Thread Robertino Benis
Hi, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. Thanks, -- r. --- plugins/ifx.c | 98 +--- 1 files changed, 92

Re: [PATCH] ifx: adding Infineon modem self test

2010-12-10 Thread Marcel Holtmann
Hi Robertino, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the modem