Re: [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

2011-01-12 Thread Tomasz Gregorek
Hi Sjur 2011/1/12 Sjur Brændeland > Hi Tomasz, don't worry the tone on the list is quite rough. If you > like marit or I can review tomorrow, but feel free to send patch as > well if you like. :) Sjur > > 2011/1/12, Tomasz Gregorek : > > Hi Marcel > > I already had my solution in head and misund

Re: [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

2011-01-12 Thread Sjur Brændeland
Hi Tomasz, don't worry the tone on the list is quite rough. If you like marit or I can review tomorrow, but feel free to send patch as well if you like. :) Sjur 2011/1/12, Tomasz Gregorek : > Hi Marcel > I already had my solution in head and misunderstood you. I will correct and > retest it. > Br

Re: [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

2011-01-12 Thread Marcel Holtmann
Hi Tomasz, > I already had my solution in head and misunderstood you. I will > correct and retest it. please do so. And NO top posting on this mailing list. Keep that in mind. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono

Re: [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

2011-01-12 Thread Tomasz Gregorek
Hi Marcel I already had my solution in head and misunderstood you. I will correct and retest it. Br Tomasz 2011/1/12 Marcel Holtmann > Hi Tomasz, > > > Combining mbm_disable and reopen_callback into one and removing 1 second > > delay between them to avoid call to reopen_callback after modem bei

Re: [PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

2011-01-12 Thread Marcel Holtmann
Hi Tomasz, > Combining mbm_disable and reopen_callback into one and removing 1 second > delay between them to avoid call to reopen_callback after modem being > disconnected. have you actually tested this? This will not work since you can not reopen the TTY right away. You need that delay in betwe

[PATCH] plugins-mbm: Combining mbm_disable and reopen_callback

2011-01-12 Thread Tomasz Gregorek
From: Tomasz Gregorek Combining mbm_disable and reopen_callback into one and removing 1 second delay between them to avoid call to reopen_callback after modem being disconnected. --- plugins/mbm.c | 41 +++-- 1 files changed, 11 insertions(+), 30 deletions(-