Re: [PATCH] ppp: implement MRU option

2010-04-22 Thread Kristen Carlson Accardi
On Thu, 22 Apr 2010 15:51:26 -0500 Denis Kenzior wrote: > Hi Kristen, > > > On Thu, 22 Apr 2010 15:16:58 -0500 > > > > Denis Kenzior wrote: > > > Hi Kristen, > > > > > > > @@ -80,7 +88,7 @@ static gboolean ppp_net_callback(GIOChannel *channel, > > > > GIOCondition cond, > > > > > > > >

Re: [PATCH] ppp: implement MRU option

2010-04-22 Thread Denis Kenzior
Hi Kristen, > On Thu, 22 Apr 2010 15:16:58 -0500 > > Denis Kenzior wrote: > > Hi Kristen, > > > > > @@ -80,7 +88,7 @@ static gboolean ppp_net_callback(GIOChannel *channel, > > > GIOCondition cond, > > > > > > if (cond & G_IO_IN) { > > > /* leave space to add PPP protocol field */ >

Re: [PATCH] ppp: implement MRU option

2010-04-22 Thread Kristen Carlson Accardi
On Thu, 22 Apr 2010 15:16:58 -0500 Denis Kenzior wrote: > Hi Kristen, > > > @@ -80,7 +88,7 @@ static gboolean ppp_net_callback(GIOChannel *channel, > > GIOCondition cond, > > > > if (cond & G_IO_IN) { > > /* leave space to add PPP protocol field */ > > - status = g_io

Re: [PATCH] ppp: implement MRU option

2010-04-22 Thread Denis Kenzior
Hi Kristen, > @@ -80,7 +88,7 @@ static gboolean ppp_net_callback(GIOChannel *channel, > GIOCondition cond, > > if (cond & G_IO_IN) { > /* leave space to add PPP protocol field */ > - status = g_io_channel_read_chars(channel, buf + 2, MAX_PACKET, > + st

Re: [PATCH] ppp: implement MRU option

2010-04-22 Thread Marcel Holtmann
Hi Kristen, > If the peer requests a MRU option, set the mtu for the network > phase. When we are in link establishment phase, we should > continue to behave as if no option has been set and the peer > should use the default MRU. > > This option is required for the Huawei E160G modem. can you a

Re: [PATCH] ppp: implement MRU option

2010-04-21 Thread Marcel Holtmann
Hi Kristen, > If the peer requests a MRU option, set the mtu for the network > phase. When we are in link establishment phase, we should > continue to behave as if no option has been set and the peer > should use the default MRU. > > This option is required for the Huawei E160G modem. patch has

[PATCH] ppp: implement MRU option

2010-04-21 Thread Kristen Carlson Accardi
If the peer requests a MRU option, set the mtu for the network phase. When we are in link establishment phase, we should continue to behave as if no option has been set and the peer should use the default MRU. This option is required for the Huawei E160G modem. --- gatchat/gatppp.c | 16 +