Re: [PATCH 6/8] plugins: add gps atom to mbm

2010-12-27 Thread Rafael Ignacio Zurita
Hi Denis, On Wed, Dec 22, 2010 at 03:58:53PM -0600, Denis Kenzior wrote: > Hi Rafael, > > > > > - if (modem_dev == NULL || data_dev == NULL) > > + if (modem_dev == NULL || data_dev == NULL || gps_dev == NULL) > > return -EINVAL; > > I don't think that failing because the gps de

Re: [PATCH 6/8] plugins: add gps atom to mbm

2010-12-22 Thread Denis Kenzior
Hi Rafael, > > - if (modem_dev == NULL || data_dev == NULL) > + if (modem_dev == NULL || data_dev == NULL || gps_dev == NULL) > return -EINVAL; I don't think that failing because the gps device isn't set is such a good idea. There might be mbm cards without a gps node. L

[PATCH 6/8] plugins: add gps atom to mbm

2010-12-16 Thread Rafael Ignacio Zurita
--- plugins/mbm.c | 30 -- 1 files changed, 28 insertions(+), 2 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index 62e3ae1..60681df 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #