Re: [PATCHv5] plugin: Add ste modem initd integration

Hi Marcel. +static void get_modems() +{ so these are declared as get_modems(void) btw. The compiler should have warned you about this. I don't get a compiler warning for this one, not even with -Wall -Wextra -Wpedantic on GCC 4.4.3. But a new rule in the coding-style should perhaps be

Re: [PATCHv5] plugin: Add ste modem initd integration

Hi Sjur, so these are declared as get_modems(void) btw. The compiler should have warned you about this. I don't get a compiler warning for this one, not even with -Wall -Wextra -Wpedantic on GCC 4.4.3. But a new rule in the coding-style should perhaps be added, e.g: M15: Use void if

Re: [PATCHv5] plugin: Add ste modem initd integration

Hi Marcel, On 01/11/2011 03:52 PM, Marcel Holtmann wrote: Hi Sjur, so these are declared as get_modems(void) btw. The compiler should have warned you about this. I don't get a compiler warning for this one, not even with -Wall -Wextra -Wpedantic on GCC 4.4.3. But a new rule in the

Re: [PATCHv5] plugin: Add ste modem initd integration

Hi Denis, so these are declared as get_modems(void) btw. The compiler should have warned you about this. I don't get a compiler warning for this one, not even with -Wall -Wextra -Wpedantic on GCC 4.4.3. But a new rule in the coding-style should perhaps be added, e.g: M15: Use void

[PATCHv5] plugin: Add ste modem initd integration

From: Sjur Brændeland sjur.brandel...@stericsson.com This patch introduces auto discovery of ST-Ericsson modems. ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a Modem Init Daemon responsible for start, power cycles, flashing etc. This STE plugin monitors the modem state exposed from the