Re: [RFC] magic numbers (145,129)

2011-01-17 Thread Denis Kenzior
Hi George, On 01/16/2011 12:39 PM, George Matveev wrote: Hi, this is proposal for a patch series which would replace magic numbers 145 and 129 with well defined enumeration. Currently we have the following (eliminating sms and CAIF related code): geo@fermat:/home/work/ofono/ofono$ grep

Re: [RFC] magic numbers (145,129)

2011-01-17 Thread George Matveev
Rajesh and Denis, thank you for your comments. It is really comforting to know that project maintainer knows about specifications and could provide guidance to other developers. This is what most contributors have come to expect from them. What makes me wonder is why don't we use those specs

Re: [RFC] magic numbers (145,129)

2011-01-17 Thread Denis Kenzior
Hi George, Kind reminder to please not top on this mailing list. On 01/17/2011 03:10 PM, George Matveev wrote: Rajesh and Denis, thank you for your comments. It is really comforting to know that project maintainer knows about specifications and could provide guidance to other developers.

[RFC] magic numbers (145,129)

2011-01-16 Thread George Matveev
Hi, this is proposal for a patch series which would replace magic numbers 145 and 129 with well defined enumeration. Currently we have the following (eliminating sms and CAIF related code): geo@fermat:/home/work/ofono/ofono$ grep -nr 145 drivers src|grep -v sms|grep -v CAIF

RE: [RFC] magic numbers (145,129)

2011-01-16 Thread Rajesh.Nagaiah
Hi George, Hi, this is proposal for a patch series which would replace magic numbers 145 and 129 with well defined enumeration. Currently we have the following (eliminating sms and CAIF related code): geo@fermat:/home/work/ofono/ofono$ grep -nr 145 drivers src|grep -v sms|grep -v