Re: [RFC v2 3/7] STE-plugin: STE modem driver definition

2010-01-19 Thread Marcel Holtmann
Hi Sjur, > Updates after review: Removed overriding of functions. > --- > + > +#ifdef HAVE_CONFIG_H > +#include > +#endif > + > +#include > +#include What are these two includes for? > +#define OFONO_API_SUBJECT_TO_CHANGE > +#include > +#include Why do you need the ofono/types.h include

[RFC v2 3/7] STE-plugin: STE modem driver definition

2010-01-19 Thread sjur . brandeland
Updates after review: Removed overriding of functions. --- drivers/stemodem/stemodem.c | 53 +++ drivers/stemodem/stemodem.h | 29 +++ 2 files changed, 82 insertions(+), 0 deletions(-) create mode 100644 drivers/stemodem/stemodem.c