Re: [isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

2010-11-22 Thread Denis Kenzior
Hi Pekka, On 11/22/2010 10:22 AM, Pekka Pessi wrote: > Hi Denis, > > 2010/11/22 Denis Kenzior : >>> +static void isi_wait_incoming(struct isi_call_req_context *irc, int event); >>> + >> >> Why is there a forward declaration for a static function? > > Because there is a dependency loop: isi_call_

Re: [isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

2010-11-22 Thread Pekka Pessi
Hi Denis, 2010/11/22 Denis Kenzior : >> +static void isi_wait_incoming(struct isi_call_req_context *irc, int event); >> + > > Why is there a forward declaration for a static function? Because there is a dependency loop: isi_call_answer_req uses isi_wait_incoming and isi_wait_incoming calls isi_ca

Re: [isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

2010-11-22 Thread Denis Kenzior
Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > The voicecall driver must wait until the incoming call is mt-alerting or > waiting before answering. > --- > drivers/isimodem/voicecall.c | 49 > +- > 1 files change

[isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

2010-11-17 Thread Pekka . Pessi
From: Pekka Pessi The voicecall driver must wait until the incoming call is mt-alerting or waiting before answering. --- drivers/isimodem/voicecall.c | 49 +- 1 files changed, 48 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/