Re: [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer

2010-01-14 Thread Denis Kenzior
Hi Zhenhua, > +gboolean g_at_util_set_io(GIOChannel *io) Rename this g_at_util_setup_io > +{ > + GIOFlags io_flags; > + > + if (g_io_channel_set_encoding(io, NULL, NULL) != > + G_IO_STATUS_NORMAL) > + return FALSE; > + > + io_flags = g_io_channel_get_f

RE: [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer

2010-01-14 Thread Zhang, Zhenhua
Hi Denis, Denis Kenzior wrote: > Hi Zhenhua, > >> +gboolean g_at_util_set_io(GIOChannel *io) > > Rename this g_at_util_setup_io > >> +typedef void (*GAtDisconnectFunc)(gpointer user_data); typedef void >> +(*GAtDebugFunc)(const char *str, gpointer user_data); > > These don't belong here, creat

Re: [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer

2010-01-20 Thread Denis Kenzior
Hi Zhenhua, > Hi Denis, > > Denis Kenzior wrote: > > Hi Zhenhua, > > > >> +gboolean g_at_util_set_io(GIOChannel *io) > > > > Rename this g_at_util_setup_io > > > >> +typedef void (*GAtDisconnectFunc)(gpointer user_data); typedef void > >> +(*GAtDebugFunc)(const char *str, gpointer user_data); > >