RE: [PATCH 1/4] radio settings: allow for more than one property

2010-10-25 Thread Mika.Liljeberg
Hi Denis, > I really don't want to argue about this. > > SetProperty("TechnologyPreference", ..) > -> Sets RADIO_SETTINGS_MODE_CACHED > > GetProperties() -> queries Fast dormancy > GetProperties() -> queries Fast dormancy > -> > > + } else if (rs->driver->query_fast_dormancy) { > +

Re: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Denis Kenzior
Hi Mika, On 10/22/2010 09:21 AM, mika.liljeb...@nokia.com wrote: > Hi Denis, > >>> Thanks. Still, I'd vote for a common checkpatch script in >> the oFono tree. ;) >>> >> >> Are you volunteering to maintain such a beast and make sure >> it is up to >> date with the kernel upstream version? > >

RE: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Mika.Liljeberg
Hi Denis, > > Thanks. Still, I'd vote for a common checkpatch script in > the oFono tree. ;) > > > > Are you volunteering to maintain such a beast and make sure > it is up to > date with the kernel upstream version? Only if I get to decide on the coding style. Otherwise, I'm proposing you guys

Re: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Denis Kenzior
Hi Mika, On 10/22/2010 02:08 AM, mika.liljeb...@nokia.com wrote: > Hi Denis, > >>> Oops, will fix. For some reason my checkpatch script did >> not complain about this. >>> >>> You must be using a script as well. To avoid unnecessary >> fuss like this, would it be possible to integrate it to th

RE: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Mika.Liljeberg
Hi Denis, > > Oops, will fix. For some reason my checkpatch script did > not complain about this. > > > > You must be using a script as well. To avoid unnecessary > fuss like this, would it be possible to integrate it to the > oFono tree so everyone would check their patches using the same th

Re: [PATCH 1/4] radio settings: allow for more than one property

2010-10-21 Thread Denis Kenzior
Hi Mika, On 10/21/2010 03:55 AM, mika.liljeb...@nokia.com wrote: > Hi, > >> Please don't mix and match tabs and spaces for indentation > > Oops, will fix. For some reason my checkpatch script did not complain about > this. > > You must be using a script as well. To avoid unnecessary fuss like

RE: [PATCH 1/4] radio settings: allow for more than one property

2010-10-21 Thread Mika.Liljeberg
Hi, > Please don't mix and match tabs and spaces for indentation Oops, will fix. For some reason my checkpatch script did not complain about this. You must be using a script as well. To avoid unnecessary fuss like this, would it be possible to integrate it to the oFono tree so everyone would c

Re: [PATCH 1/4] radio settings: allow for more than one property

2010-10-20 Thread Denis Kenzior
Hi Mika, On 10/07/2010 08:37 AM, Mika Liljeberg wrote: > Restructure code to allow other properties besides > TechnologyPreference to be returned. > --- > src/radio-settings.c | 59 + > 1 files changed, 30 insertions(+), 29 deletions(-) > > diff