RE: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-11-01 Thread Mika.Liljeberg
Hi, To give you a more complex example, it might well be that the gprs connection needs to be torn down when making an emergency call in 2G mode, there are such networks out there that prevents you from making an emergency call if your device is attached to a PDP context. In this

RE: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-11-01 Thread Marcel Holtmann
Hi Mika, To give you a more complex example, it might well be that the gprs connection needs to be torn down when making an emergency call in 2G mode, there are such networks out there that prevents you from making an emergency call if your device is attached to a PDP context.

RE: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-11-01 Thread Mika.Liljeberg
Hi Marcel, Have we established that this is actually still needed? I thought you guys said all the networks that have this problem have been fixed by now? AFAIK, this is still a product requirement for us. I can recheck, but I just asked last week and the answer was a very

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-11-01 Thread Andras Domokos
Hi Denis, On 10/29/2010 08:32 PM, ext Denis Kenzior wrote: Hi Andras, Just some general comments, but this patch seems to be backwards from the earlier proposal. Namely EmergencyMode is a property on the Modem interface, not on the VoiceCallManager. See doc/modem-api.txt, Emergency

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-29 Thread Andras Domokos
Hi Denis, Thank you for your comments, here is my response. On 10/28/2010 06:48 AM, ext Denis Kenzior wrote: Hi Andras, On 10/25/2010 03:03 AM, Andras Domokos wrote: From: Andras Domokosandras.domo...@nokia.com Signed-off-by: Andras Domokosandras.domo...@nokia.com ---

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-29 Thread Marcel Holtmann
Hi Andras, In general I think that the emergency_watch is unnecessary. Having a reference counted emergency tracking inside the modem object and a modem online state watch should be sufficient. The idea with the emergency watch is that any subsystem can get the notification when

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-29 Thread Denis Kenzior
Hi Andras, Just some general comments, but this patch seems to be backwards from the earlier proposal. Namely EmergencyMode is a property on the Modem interface, not on the VoiceCallManager. See doc/modem-api.txt, Emergency property. I thought it was more logical to have the

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-27 Thread Denis Kenzior
Hi Andras, On 10/25/2010 03:03 AM, Andras Domokos wrote: From: Andras Domokos andras.domo...@nokia.com Signed-off-by: Andras Domokos andras.domo...@nokia.com --- include/voicecall.h | 12 +++ src/voicecall.c | 221 ++ 2 files